All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: linux-s390@vger.kernel.org, Janosch Frank <frankja@linux.ibm.com>,
	"Lendacky, Thomas" <Thomas.Lendacky@amd.com>,
	Jason Wang <jasowang@redhat.com>,
	Cornelia Huck <cohuck@redhat.com>, Ram Pai <linuxram@us.ibm.com>,
	linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	Halil Pasic <pasic@linux.ibm.com>,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	iommu@lists.linux-foundation.org,
	David Gibson <david@gibson.dropbear.id.au>,
	Michael Mueller <mimu@linux.ibm.com>,
	Viktor Mihajlovski <mihajlov@linux.ibm.com>,
	Robin Murphy <robin.murphy@arm.com>,
	Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 2/2] virtio: let virtio use DMA API when guest RAM is protected
Date: Fri, 21 Feb 2020 17:35:23 +0100	[thread overview]
Message-ID: <20200221163523.GA10054@lst.de> (raw)
In-Reply-To: <20200221104901-mutt-send-email-mst@kernel.org>

On Fri, Feb 21, 2020 at 10:56:45AM -0500, Michael S. Tsirkin wrote:
> > >   - DMA API is giving us addresses that are actually also physical
> > >     addresses
> > 
> > In case of s390 this is given.
> > I talked with the power people before
> > posting this, and they ensured me they can are willing to deal with
> > this. I was hoping to talk abut this with the AMD SEV people here (hence
> > the cc).
> 
> We'd need a part of DMA API that promises this though. Platform
> maintainers aren't going to go out of their way to do the
> right thing just for virtio, and I can't track all arches
> to make sure they don't violate virtio requirements.

There is no way the DMA API is going to promise that you.  All kinds
of platforms have offsets to DMA, and they are communicated through
interfaces like the device tree or ACPI.  But the good thing is that
your hypervisors is in control of that, neither the DMA API nor
virtio have any business to interfer with that.  In fact for harware
virtio device we might need such an offset for them to work on
lots of SOCs.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Halil Pasic <pasic@linux.ibm.com>,
	Jason Wang <jasowang@redhat.com>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Robin Murphy <robin.murphy@arm.com>,
	Christoph Hellwig <hch@lst.de>,
	linux-s390@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Janosch Frank <frankja@linux.ibm.com>,
	Viktor Mihajlovski <mihajlov@linux.ibm.com>,
	Cornelia Huck <cohuck@redhat.com>, Ram Pai <linuxram@us.ibm.com>,
	Thiago Jung Bauermann <bauerman@linux.ibm.com>,
	David Gibson <david@gibson.dropbear.id.au>,
	"Lendacky, Thomas" <Thomas.Lendacky@amd.com>,
	Michael Mueller <mimu@linux.ibm.com>
Subject: Re: [PATCH 2/2] virtio: let virtio use DMA API when guest RAM is protected
Date: Fri, 21 Feb 2020 17:35:23 +0100	[thread overview]
Message-ID: <20200221163523.GA10054@lst.de> (raw)
In-Reply-To: <20200221104901-mutt-send-email-mst@kernel.org>

On Fri, Feb 21, 2020 at 10:56:45AM -0500, Michael S. Tsirkin wrote:
> > >   - DMA API is giving us addresses that are actually also physical
> > >     addresses
> > 
> > In case of s390 this is given.
> > I talked with the power people before
> > posting this, and they ensured me they can are willing to deal with
> > this. I was hoping to talk abut this with the AMD SEV people here (hence
> > the cc).
> 
> We'd need a part of DMA API that promises this though. Platform
> maintainers aren't going to go out of their way to do the
> right thing just for virtio, and I can't track all arches
> to make sure they don't violate virtio requirements.

There is no way the DMA API is going to promise that you.  All kinds
of platforms have offsets to DMA, and they are communicated through
interfaces like the device tree or ACPI.  But the good thing is that
your hypervisors is in control of that, neither the DMA API nor
virtio have any business to interfer with that.  In fact for harware
virtio device we might need such an offset for them to work on
lots of SOCs.

  reply	other threads:[~2020-02-21 16:35 UTC|newest]

Thread overview: 124+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-20 16:06 [PATCH 0/2] virtio: decouple protected guest RAM form VIRTIO_F_IOMMU_PLATFORM Halil Pasic
2020-02-20 16:06 ` Halil Pasic
2020-02-20 16:06 ` [PATCH 1/2] mm: move force_dma_unencrypted() to mem_encrypt.h Halil Pasic
2020-02-20 16:06   ` Halil Pasic
2020-02-20 16:11   ` Christoph Hellwig
2020-02-20 16:11     ` Christoph Hellwig
2020-02-20 16:23     ` Christian Borntraeger
2020-02-20 16:23       ` Christian Borntraeger
2020-02-20 16:31       ` Christoph Hellwig
2020-02-20 16:31         ` Christoph Hellwig
2020-02-20 16:31         ` Christoph Hellwig
2020-02-20 17:00         ` Christian Borntraeger
2020-02-20 17:00           ` Christian Borntraeger
2020-02-21  3:27         ` David Gibson
2020-02-21  3:27           ` David Gibson
2020-02-21 13:06           ` Halil Pasic
2020-02-21 13:06             ` Halil Pasic
2020-02-21 15:48             ` Michael S. Tsirkin
2020-02-21 15:48               ` Michael S. Tsirkin
2020-02-21 18:07               ` Halil Pasic
2020-02-21 18:07                 ` Halil Pasic
2020-02-24  3:33                 ` David Gibson
2020-02-24  3:33                   ` David Gibson
2020-02-24 18:49                   ` Halil Pasic
2020-02-24 18:49                     ` Halil Pasic
2020-02-25 18:08                     ` Cornelia Huck
2020-02-25 18:08                       ` Cornelia Huck
2020-02-28  0:23                       ` David Gibson
2020-02-28  0:23                         ` David Gibson
2020-02-20 16:06 ` [PATCH 2/2] virtio: let virtio use DMA API when guest RAM is protected Halil Pasic
2020-02-20 16:06   ` Halil Pasic
2020-02-20 16:13   ` Christoph Hellwig
2020-02-20 16:13     ` Christoph Hellwig
2020-02-21  2:59     ` David Gibson
2020-02-21  2:59       ` David Gibson
2020-02-21  3:41       ` Jason Wang
2020-02-21  3:41         ` Jason Wang
2020-02-21 13:31         ` Halil Pasic
2020-02-21 13:31           ` Halil Pasic
2020-02-21 13:27       ` Halil Pasic
2020-02-21 13:27         ` Halil Pasic
2020-02-21 16:36       ` Christoph Hellwig
2020-02-21 16:36         ` Christoph Hellwig
2020-02-24  6:50         ` David Gibson
2020-02-24  6:50           ` David Gibson
2020-02-24 18:59         ` Halil Pasic
2020-02-24 18:59           ` Halil Pasic
2020-02-24 18:59           ` Halil Pasic
2020-02-21 14:33     ` Halil Pasic
2020-02-21 14:33       ` Halil Pasic
2020-02-21 16:39       ` Christoph Hellwig
2020-02-21 16:39         ` Christoph Hellwig
2020-02-21 18:16         ` Halil Pasic
2020-02-21 18:16           ` Halil Pasic
2020-02-21 18:16           ` Halil Pasic
2020-02-22 19:07       ` Michael S. Tsirkin
2020-02-22 19:07         ` Michael S. Tsirkin
2020-02-24 17:16         ` Christoph Hellwig
2020-02-24 17:16           ` Christoph Hellwig
2020-10-28 14:24           ` Alexander Graf via iommu
2020-10-28 18:01             ` Michael S. Tsirkin
2020-10-28 18:01               ` Michael S. Tsirkin
2020-10-28 18:01               ` Michael S. Tsirkin
2020-02-20 20:55   ` Michael S. Tsirkin
2020-02-20 20:55     ` Michael S. Tsirkin
2020-02-21  1:17     ` Ram Pai
2020-02-21  1:17       ` Ram Pai
2020-02-21  1:17       ` Ram Pai
2020-02-21  3:29       ` David Gibson
2020-02-21  3:29         ` David Gibson
2020-02-21 13:12     ` Halil Pasic
2020-02-21 13:12       ` Halil Pasic
2020-02-21 15:39       ` Tom Lendacky
2020-02-21 15:39         ` Tom Lendacky
2020-02-24  6:40         ` David Gibson
2020-02-24  6:40           ` David Gibson
2020-02-24  6:40           ` David Gibson
2020-02-21 15:56       ` Michael S. Tsirkin
2020-02-21 15:56         ` Michael S. Tsirkin
2020-02-21 16:35         ` Christoph Hellwig [this message]
2020-02-21 16:35           ` Christoph Hellwig
2020-02-21 18:03         ` Halil Pasic
2020-02-21 18:03           ` Halil Pasic
2020-02-20 20:48 ` [PATCH 0/2] virtio: decouple protected guest RAM form VIRTIO_F_IOMMU_PLATFORM Michael S. Tsirkin
2020-02-20 20:48   ` Michael S. Tsirkin
2020-02-20 21:29 ` Michael S. Tsirkin
2020-02-20 21:29   ` Michael S. Tsirkin
2020-02-21 13:37   ` Halil Pasic
2020-02-21 13:37     ` Halil Pasic
2020-02-20 21:33 ` Michael S. Tsirkin
2020-02-20 21:33   ` Michael S. Tsirkin
2020-02-21 13:49   ` Halil Pasic
2020-02-21 13:49     ` Halil Pasic
2020-02-21 16:41   ` Christoph Hellwig
2020-02-21 16:41     ` Christoph Hellwig
2020-02-24  5:44     ` David Gibson
2020-02-24  5:44       ` David Gibson
2020-02-24  5:44       ` David Gibson
2020-02-21  6:22 ` Jason Wang
2020-02-21  6:22   ` Jason Wang
2020-02-21 14:56   ` Halil Pasic
2020-02-21 14:56     ` Halil Pasic
2020-02-24  3:38     ` David Gibson
2020-02-24  3:38       ` David Gibson
2020-02-24  4:01     ` Jason Wang
2020-02-24  4:01       ` Jason Wang
2020-02-24  4:01       ` Jason Wang
2020-02-24  6:06       ` Michael S. Tsirkin
2020-02-24  6:06         ` Michael S. Tsirkin
2020-02-24  6:45         ` Jason Wang
2020-02-24  6:45           ` Jason Wang
2020-02-24  7:48           ` Michael S. Tsirkin
2020-02-24  7:48             ` Michael S. Tsirkin
2020-02-24  9:26             ` Jason Wang
2020-02-24  9:26               ` Jason Wang
2020-02-24 13:40               ` Michael S. Tsirkin
2020-02-24 13:40                 ` Michael S. Tsirkin
2020-02-25  3:38                 ` Jason Wang
2020-02-25  3:38                   ` Jason Wang
2020-02-24 13:56               ` Halil Pasic
2020-02-24 13:56                 ` Halil Pasic
2020-02-25  3:30                 ` Jason Wang
2020-02-25  3:30                   ` Jason Wang
2020-02-25  3:30                   ` Jason Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200221163523.GA10054@lst.de \
    --to=hch@lst.de \
    --cc=Thomas.Lendacky@amd.com \
    --cc=borntraeger@de.ibm.com \
    --cc=cohuck@redhat.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=frankja@linux.ibm.com \
    --cc=iommu@lists.linux-foundation.org \
    --cc=jasowang@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=linuxram@us.ibm.com \
    --cc=mihajlov@linux.ibm.com \
    --cc=mimu@linux.ibm.com \
    --cc=mst@redhat.com \
    --cc=pasic@linux.ibm.com \
    --cc=robin.murphy@arm.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.