* [PATCH] xfs: mark ARM OABI as incompatible in Kconfig
@ 2020-02-25 0:49 ` Eric Sandeen
0 siblings, 0 replies; 8+ messages in thread
From: Eric Sandeen @ 2020-02-25 0:49 UTC (permalink / raw)
To: linux-xfs; +Cc: linux-arm-kernel
The old ARM OABI's structure alignment quirks break xfs disk structures,
let's just move on and disallow it rather than playing whack-a-mole
for the infrequent times someone selects this old config, which is
usually during "make randconfig" tests.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
diff --git a/fs/xfs/Kconfig b/fs/xfs/Kconfig
index e685299eb3d2..043624bd4ab2 100644
--- a/fs/xfs/Kconfig
+++ b/fs/xfs/Kconfig
@@ -2,6 +2,8 @@
config XFS_FS
tristate "XFS filesystem support"
depends on BLOCK
+ # We don't support OABI structure alignment on ARM
+ depends on (!ARM || AEABI)
select EXPORTFS
select LIBCRC32C
select FS_IOMAP
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] xfs: mark ARM OABI as incompatible in Kconfig
@ 2020-02-25 0:49 ` Eric Sandeen
0 siblings, 0 replies; 8+ messages in thread
From: Eric Sandeen @ 2020-02-25 0:49 UTC (permalink / raw)
To: linux-xfs; +Cc: linux-arm-kernel
The old ARM OABI's structure alignment quirks break xfs disk structures,
let's just move on and disallow it rather than playing whack-a-mole
for the infrequent times someone selects this old config, which is
usually during "make randconfig" tests.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
diff --git a/fs/xfs/Kconfig b/fs/xfs/Kconfig
index e685299eb3d2..043624bd4ab2 100644
--- a/fs/xfs/Kconfig
+++ b/fs/xfs/Kconfig
@@ -2,6 +2,8 @@
config XFS_FS
tristate "XFS filesystem support"
depends on BLOCK
+ # We don't support OABI structure alignment on ARM
+ depends on (!ARM || AEABI)
select EXPORTFS
select LIBCRC32C
select FS_IOMAP
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] xfs: mark ARM OABI as incompatible in Kconfig
2020-02-25 0:49 ` Eric Sandeen
@ 2020-02-25 0:55 ` Darrick J. Wong
-1 siblings, 0 replies; 8+ messages in thread
From: Darrick J. Wong @ 2020-02-25 0:55 UTC (permalink / raw)
To: Eric Sandeen; +Cc: linux-xfs, linux-arm-kernel
On Mon, Feb 24, 2020 at 04:49:12PM -0800, Eric Sandeen wrote:
> The old ARM OABI's structure alignment quirks break xfs disk structures,
> let's just move on and disallow it rather than playing whack-a-mole
> for the infrequent times someone selects this old config, which is
> usually during "make randconfig" tests.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
>
> diff --git a/fs/xfs/Kconfig b/fs/xfs/Kconfig
> index e685299eb3d2..043624bd4ab2 100644
> --- a/fs/xfs/Kconfig
> +++ b/fs/xfs/Kconfig
> @@ -2,6 +2,8 @@
> config XFS_FS
> tristate "XFS filesystem support"
> depends on BLOCK
> + # We don't support OABI structure alignment on ARM
Should this limitation be documented in the help screen?
> + depends on (!ARM || AEABI)
> select EXPORTFS
> select LIBCRC32C
> select FS_IOMAP
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] xfs: mark ARM OABI as incompatible in Kconfig
@ 2020-02-25 0:55 ` Darrick J. Wong
0 siblings, 0 replies; 8+ messages in thread
From: Darrick J. Wong @ 2020-02-25 0:55 UTC (permalink / raw)
To: Eric Sandeen; +Cc: linux-xfs, linux-arm-kernel
On Mon, Feb 24, 2020 at 04:49:12PM -0800, Eric Sandeen wrote:
> The old ARM OABI's structure alignment quirks break xfs disk structures,
> let's just move on and disallow it rather than playing whack-a-mole
> for the infrequent times someone selects this old config, which is
> usually during "make randconfig" tests.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
>
> diff --git a/fs/xfs/Kconfig b/fs/xfs/Kconfig
> index e685299eb3d2..043624bd4ab2 100644
> --- a/fs/xfs/Kconfig
> +++ b/fs/xfs/Kconfig
> @@ -2,6 +2,8 @@
> config XFS_FS
> tristate "XFS filesystem support"
> depends on BLOCK
> + # We don't support OABI structure alignment on ARM
Should this limitation be documented in the help screen?
> + depends on (!ARM || AEABI)
> select EXPORTFS
> select LIBCRC32C
> select FS_IOMAP
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] xfs: mark ARM OABI as incompatible in Kconfig
2020-02-25 0:55 ` Darrick J. Wong
@ 2020-02-25 0:58 ` Eric Sandeen
-1 siblings, 0 replies; 8+ messages in thread
From: Eric Sandeen @ 2020-02-25 0:58 UTC (permalink / raw)
To: Darrick J. Wong; +Cc: linux-xfs, linux-arm-kernel
On 2/24/20 4:55 PM, Darrick J. Wong wrote:
> On Mon, Feb 24, 2020 at 04:49:12PM -0800, Eric Sandeen wrote:
>> The old ARM OABI's structure alignment quirks break xfs disk structures,
>> let's just move on and disallow it rather than playing whack-a-mole
>> for the infrequent times someone selects this old config, which is
>> usually during "make randconfig" tests.
>>
>> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
>> ---
>>
>> diff --git a/fs/xfs/Kconfig b/fs/xfs/Kconfig
>> index e685299eb3d2..043624bd4ab2 100644
>> --- a/fs/xfs/Kconfig
>> +++ b/fs/xfs/Kconfig
>> @@ -2,6 +2,8 @@
>> config XFS_FS
>> tristate "XFS filesystem support"
>> depends on BLOCK
>> + # We don't support OABI structure alignment on ARM
>
> Should this limitation be documented in the help screen?
Yeah probably.
But now looking at
aa2dd0ad4d6d xfs: remove __arch_pack
hch indicates that some non-arm architectures have similar problems,
so is there any point to excluding this one config on this one arch?
-Eric
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] xfs: mark ARM OABI as incompatible in Kconfig
@ 2020-02-25 0:58 ` Eric Sandeen
0 siblings, 0 replies; 8+ messages in thread
From: Eric Sandeen @ 2020-02-25 0:58 UTC (permalink / raw)
To: Darrick J. Wong; +Cc: linux-xfs, linux-arm-kernel
On 2/24/20 4:55 PM, Darrick J. Wong wrote:
> On Mon, Feb 24, 2020 at 04:49:12PM -0800, Eric Sandeen wrote:
>> The old ARM OABI's structure alignment quirks break xfs disk structures,
>> let's just move on and disallow it rather than playing whack-a-mole
>> for the infrequent times someone selects this old config, which is
>> usually during "make randconfig" tests.
>>
>> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
>> ---
>>
>> diff --git a/fs/xfs/Kconfig b/fs/xfs/Kconfig
>> index e685299eb3d2..043624bd4ab2 100644
>> --- a/fs/xfs/Kconfig
>> +++ b/fs/xfs/Kconfig
>> @@ -2,6 +2,8 @@
>> config XFS_FS
>> tristate "XFS filesystem support"
>> depends on BLOCK
>> + # We don't support OABI structure alignment on ARM
>
> Should this limitation be documented in the help screen?
Yeah probably.
But now looking at
aa2dd0ad4d6d xfs: remove __arch_pack
hch indicates that some non-arm architectures have similar problems,
so is there any point to excluding this one config on this one arch?
-Eric
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] xfs: mark ARM OABI as incompatible in Kconfig
2020-02-25 0:58 ` Eric Sandeen
@ 2020-02-25 17:56 ` Christoph Hellwig
-1 siblings, 0 replies; 8+ messages in thread
From: Christoph Hellwig @ 2020-02-25 17:56 UTC (permalink / raw)
To: Eric Sandeen; +Cc: Darrick J. Wong, linux-xfs, linux-arm-kernel
On Mon, Feb 24, 2020 at 04:58:20PM -0800, Eric Sandeen wrote:
> Yeah probably.
>
> But now looking at
>
> aa2dd0ad4d6d xfs: remove __arch_pack
>
> hch indicates that some non-arm architectures have similar problems,
> so is there any point to excluding this one config on this one arch?
Yes, I think we just need to be more careful with our newly added
structure layouts and whenever we do a major reorganization of an
existing one.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-02-25 17:56 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-02-25 0:49 [PATCH] xfs: mark ARM OABI as incompatible in Kconfig Eric Sandeen
2020-02-25 0:49 ` Eric Sandeen
2020-02-25 0:55 ` Darrick J. Wong
2020-02-25 0:55 ` Darrick J. Wong
2020-02-25 0:58 ` Eric Sandeen
2020-02-25 0:58 ` Eric Sandeen
2020-02-25 17:56 ` Christoph Hellwig
2020-02-25 17:56 ` Christoph Hellwig
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.