Re: [PATCH v11 2/2] spi: cadence-quadspi: Add support for the Cadence QSPI controller

From: Boris Brezillon <boris.brezillon@collabora.com>
To: "Ramuthevar,
	Vadivel MuruganX" <vadivel.muruganx.ramuthevar@linux.intel.com>
Cc: mark.rutland@arm.com, tudor.ambarus@gmail.com, vigneshr@ti.com,
	linux-mtd@lists.infradead.org, miquel.raynal@bootlin.com,
	cyrille.pitchen@atmel.com, marex@denx.de,
	boris.brezillon@free-electrons.com, tien.fong.chee@intel.com,
	richard@nod.at, simon.k.r.goldschmidt@gmail.com,
	devicetree@vger.kernel.org, cheol.yong.kim@intel.com,
	robh+dt@kernel.org, qi-ming.wu@intel.com,
	david.oberhollenzer@sigma-star.at, linux-kernel@vger.kernel.org,
	linux-spi@vger.kernel.org, dinguyen@kernel.org,
	broonie@kernel.org, computersforpeace@gmail.com,
	dwmw2@infradead.org
Subject: Re: [PATCH v11 2/2] spi: cadence-quadspi: Add support for the Cadence QSPI controller
Date: Thu, 27 Feb 2020 18:30:32 +0100	[thread overview]
Message-ID: <20200227183032.77ef0795@collabora.com> (raw)
In-Reply-To: <20200227062708.21544-3-vadivel.muruganx.ramuthevar@linux.intel.com>

On Thu, 27 Feb 2020 14:27:08 +0800
"Ramuthevar, Vadivel MuruganX"
<vadivel.muruganx.ramuthevar@linux.intel.com> wrote:

> From: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com>
> 
> Add support for the Cadence QSPI controller. This controller is
> present in the Intel Lightning Mountain(LGM) SoCs, Altera and TI SoCs.
> This driver has been tested on the Intel LGM SoCs.
> 
> This driver does not support generic SPI and also the implementation
> only supports spi-mem interface to replace the existing driver in
> mtd/spi-nor/cadence-quadspi.c, the existing driver only support SPI-NOR
> flash memory.

Is it really supporting SPI NORs only, or is it just that you only
tested it with a spi-nor?

> 
> Signed-off-by: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com>
> Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
> Reported-by: kbuild test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

Reported-by? What has been reported?

> ---
>  drivers/mtd/spi-nor/Kconfig                        |  11 -
>  drivers/mtd/spi-nor/Makefile                       |   1 -
>  drivers/spi/Kconfig                                |  10 +
>  drivers/spi/Makefile                               |   1 +
>  .../spi-cadence-quadspi.c}                         | 641 ++++++++++-----------

Looks like this could be split in several patches to ease the review:

1/ convert to spi-mem
2/ move the driver to drivers/spi
3/ add support for intel,lgm-qspi

other than that, that's good to see one more spi-nor controller driver
converted to spi-mem.

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/