From: Rob Herring <robh@kernel.org>
To: Shengjiu Wang <shengjiu.wang@nxp.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org, timur@kernel.org,
Xiubo.Lee@gmail.com, shawnguo@kernel.org, s.hauer@pengutronix.de,
tiwai@suse.com, lgirdwood@gmail.com, nicoleotsuka@gmail.com,
broonie@kernel.org, linux-imx@nxp.com, kernel@pengutronix.de,
festevam@gmail.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 1/8] ASoC: dt-bindings: fsl_asrc: Change asrc-width to asrc-format
Date: Mon, 2 Mar 2020 19:41:33 -0600 [thread overview]
Message-ID: <20200303014133.GA24596@bogus> (raw)
In-Reply-To: <872c2e1082de6348318e14ccd31884d62355c282.1583039752.git.shengjiu.wang@nxp.com>
On Sun, Mar 01, 2020 at 01:24:12PM +0800, Shengjiu Wang wrote:
> asrc_format is more inteligent, which is align with the alsa
> definition snd_pcm_format_t, we don't need to convert it to
> format in driver, and it can distinguish S24_LE & S24_3LE.
>
> Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
> ---
> Documentation/devicetree/bindings/sound/fsl,asrc.txt | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/sound/fsl,asrc.txt b/Documentation/devicetree/bindings/sound/fsl,asrc.txt
> index cb9a25165503..0cbb86c026d5 100644
> --- a/Documentation/devicetree/bindings/sound/fsl,asrc.txt
> +++ b/Documentation/devicetree/bindings/sound/fsl,asrc.txt
> @@ -38,7 +38,9 @@ Required properties:
>
> - fsl,asrc-rate : Defines a mutual sample rate used by DPCM Back Ends.
>
> - - fsl,asrc-width : Defines a mutual sample width used by DPCM Back Ends.
> + - fsl,asrc-format : Defines a mutual sample format used by DPCM Back
> + Ends. The value is one of SNDRV_PCM_FORMAT_XX in
> + "include/uapi/sound/asound.h"
You can't just change properties. They are an ABI.
>
> - fsl,asrc-clk-map : Defines clock map used in driver. which is required
> by imx8qm/imx8qxp platform
> --
> 2.21.0
>
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Shengjiu Wang <shengjiu.wang@nxp.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org, timur@kernel.org,
Xiubo.Lee@gmail.com, shawnguo@kernel.org, s.hauer@pengutronix.de,
tiwai@suse.com, lgirdwood@gmail.com, perex@perex.cz,
nicoleotsuka@gmail.com, broonie@kernel.org, linux-imx@nxp.com,
kernel@pengutronix.de, festevam@gmail.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 1/8] ASoC: dt-bindings: fsl_asrc: Change asrc-width to asrc-format
Date: Mon, 2 Mar 2020 19:41:33 -0600 [thread overview]
Message-ID: <20200303014133.GA24596@bogus> (raw)
In-Reply-To: <872c2e1082de6348318e14ccd31884d62355c282.1583039752.git.shengjiu.wang@nxp.com>
On Sun, Mar 01, 2020 at 01:24:12PM +0800, Shengjiu Wang wrote:
> asrc_format is more inteligent, which is align with the alsa
> definition snd_pcm_format_t, we don't need to convert it to
> format in driver, and it can distinguish S24_LE & S24_3LE.
>
> Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
> ---
> Documentation/devicetree/bindings/sound/fsl,asrc.txt | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/sound/fsl,asrc.txt b/Documentation/devicetree/bindings/sound/fsl,asrc.txt
> index cb9a25165503..0cbb86c026d5 100644
> --- a/Documentation/devicetree/bindings/sound/fsl,asrc.txt
> +++ b/Documentation/devicetree/bindings/sound/fsl,asrc.txt
> @@ -38,7 +38,9 @@ Required properties:
>
> - fsl,asrc-rate : Defines a mutual sample rate used by DPCM Back Ends.
>
> - - fsl,asrc-width : Defines a mutual sample width used by DPCM Back Ends.
> + - fsl,asrc-format : Defines a mutual sample format used by DPCM Back
> + Ends. The value is one of SNDRV_PCM_FORMAT_XX in
> + "include/uapi/sound/asound.h"
You can't just change properties. They are an ABI.
>
> - fsl,asrc-clk-map : Defines clock map used in driver. which is required
> by imx8qm/imx8qxp platform
> --
> 2.21.0
>
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Shengjiu Wang <shengjiu.wang@nxp.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org, timur@kernel.org,
Xiubo.Lee@gmail.com, shawnguo@kernel.org, s.hauer@pengutronix.de,
tiwai@suse.com, lgirdwood@gmail.com, perex@perex.cz,
nicoleotsuka@gmail.com, broonie@kernel.org, linux-imx@nxp.com,
kernel@pengutronix.de, festevam@gmail.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 1/8] ASoC: dt-bindings: fsl_asrc: Change asrc-width to asrc-format
Date: Mon, 2 Mar 2020 19:41:33 -0600 [thread overview]
Message-ID: <20200303014133.GA24596@bogus> (raw)
In-Reply-To: <872c2e1082de6348318e14ccd31884d62355c282.1583039752.git.shengjiu.wang@nxp.com>
On Sun, Mar 01, 2020 at 01:24:12PM +0800, Shengjiu Wang wrote:
> asrc_format is more inteligent, which is align with the alsa
> definition snd_pcm_format_t, we don't need to convert it to
> format in driver, and it can distinguish S24_LE & S24_3LE.
>
> Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
> ---
> Documentation/devicetree/bindings/sound/fsl,asrc.txt | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/sound/fsl,asrc.txt b/Documentation/devicetree/bindings/sound/fsl,asrc.txt
> index cb9a25165503..0cbb86c026d5 100644
> --- a/Documentation/devicetree/bindings/sound/fsl,asrc.txt
> +++ b/Documentation/devicetree/bindings/sound/fsl,asrc.txt
> @@ -38,7 +38,9 @@ Required properties:
>
> - fsl,asrc-rate : Defines a mutual sample rate used by DPCM Back Ends.
>
> - - fsl,asrc-width : Defines a mutual sample width used by DPCM Back Ends.
> + - fsl,asrc-format : Defines a mutual sample format used by DPCM Back
> + Ends. The value is one of SNDRV_PCM_FORMAT_XX in
> + "include/uapi/sound/asound.h"
You can't just change properties. They are an ABI.
>
> - fsl,asrc-clk-map : Defines clock map used in driver. which is required
> by imx8qm/imx8qxp platform
> --
> 2.21.0
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Shengjiu Wang <shengjiu.wang@nxp.com>
Cc: timur@kernel.org, nicoleotsuka@gmail.com, Xiubo.Lee@gmail.com,
festevam@gmail.com, broonie@kernel.org,
alsa-devel@alsa-project.org, lgirdwood@gmail.com, perex@perex.cz,
tiwai@suse.com, mark.rutland@arm.com, devicetree@vger.kernel.org,
shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, linux-imx@nxp.com,
linux-arm-kernel@lists.infradead.org,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/8] ASoC: dt-bindings: fsl_asrc: Change asrc-width to asrc-format
Date: Mon, 2 Mar 2020 19:41:33 -0600 [thread overview]
Message-ID: <20200303014133.GA24596@bogus> (raw)
In-Reply-To: <872c2e1082de6348318e14ccd31884d62355c282.1583039752.git.shengjiu.wang@nxp.com>
On Sun, Mar 01, 2020 at 01:24:12PM +0800, Shengjiu Wang wrote:
> asrc_format is more inteligent, which is align with the alsa
> definition snd_pcm_format_t, we don't need to convert it to
> format in driver, and it can distinguish S24_LE & S24_3LE.
>
> Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
> ---
> Documentation/devicetree/bindings/sound/fsl,asrc.txt | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/sound/fsl,asrc.txt b/Documentation/devicetree/bindings/sound/fsl,asrc.txt
> index cb9a25165503..0cbb86c026d5 100644
> --- a/Documentation/devicetree/bindings/sound/fsl,asrc.txt
> +++ b/Documentation/devicetree/bindings/sound/fsl,asrc.txt
> @@ -38,7 +38,9 @@ Required properties:
>
> - fsl,asrc-rate : Defines a mutual sample rate used by DPCM Back Ends.
>
> - - fsl,asrc-width : Defines a mutual sample width used by DPCM Back Ends.
> + - fsl,asrc-format : Defines a mutual sample format used by DPCM Back
> + Ends. The value is one of SNDRV_PCM_FORMAT_XX in
> + "include/uapi/sound/asound.h"
You can't just change properties. They are an ABI.
>
> - fsl,asrc-clk-map : Defines clock map used in driver. which is required
> by imx8qm/imx8qxp platform
> --
> 2.21.0
>
next prev parent reply other threads:[~2020-03-03 1:42 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-01 5:24 [PATCH v4 0/8] ASoC: Add new module driver for new ASRC Shengjiu Wang
2020-03-01 5:24 ` Shengjiu Wang
2020-03-01 5:24 ` [PATCH v4 1/8] ASoC: dt-bindings: fsl_asrc: Change asrc-width to asrc-format Shengjiu Wang
2020-03-01 5:24 ` Shengjiu Wang
2020-03-03 1:41 ` Rob Herring [this message]
2020-03-03 1:41 ` Rob Herring
2020-03-03 1:41 ` Rob Herring
2020-03-03 1:41 ` Rob Herring
2020-03-03 3:59 ` Shengjiu Wang
2020-03-03 3:59 ` Shengjiu Wang
2020-03-03 3:59 ` Shengjiu Wang
2020-03-03 7:37 ` Nicolin Chen
2020-03-03 7:37 ` Nicolin Chen
2020-03-03 7:37 ` Nicolin Chen
2020-03-03 12:47 ` Mark Brown
2020-03-03 12:47 ` Mark Brown
2020-03-03 12:47 ` Mark Brown
2020-03-07 3:24 ` Shengjiu Wang
2020-03-07 3:24 ` Shengjiu Wang
2020-03-07 3:24 ` Shengjiu Wang
2020-03-01 5:24 ` [PATCH v4 2/8] ARM: dts: imx6qdl: " Shengjiu Wang
2020-03-01 5:24 ` Shengjiu Wang
2020-03-01 5:24 ` [PATCH v4 3/8] ASoC: fsl-asoc-card: " Shengjiu Wang
2020-03-01 5:24 ` Shengjiu Wang
2020-03-01 5:24 ` [PATCH v4 4/8] ASoC: fsl_asrc: Change asrc_width to asrc_format Shengjiu Wang
2020-03-01 5:24 ` Shengjiu Wang
2020-03-01 5:24 ` [PATCH v4 5/8] ASoC: fsl_asrc: rename asrc_priv to asrc Shengjiu Wang
2020-03-01 5:24 ` Shengjiu Wang
2020-03-01 5:24 ` [PATCH v4 6/8] ASoC: fsl_asrc: Move common definition to fsl_asrc_common Shengjiu Wang
2020-03-01 5:24 ` Shengjiu Wang
2020-03-01 5:24 ` [PATCH v4 7/8] ASoC: dt-bindings: fsl_easrc: Add document for EASRC Shengjiu Wang
2020-03-01 5:24 ` Shengjiu Wang
2020-03-03 1:46 ` Rob Herring
2020-03-03 1:46 ` Rob Herring
2020-03-03 1:46 ` Rob Herring
2020-03-03 1:46 ` Rob Herring
2020-03-01 5:24 ` [PATCH v4 8/8] ASoC: fsl_easrc: Add EASRC ASoC CPU DAI and platform drivers Shengjiu Wang
2020-03-01 5:24 ` Shengjiu Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200303014133.GA24596@bogus \
--to=robh@kernel.org \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mark.rutland@arm.com \
--cc=nicoleotsuka@gmail.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=shengjiu.wang@nxp.com \
--cc=timur@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.