From: Dan Carpenter <dan.carpenter@oracle.com>
To: Saeed Mahameed <saeedm@mellanox.com>
Cc: Eli Cohen <eli@mellanox.com>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
Mark Bloch <markb@mellanox.com>, Paul Blakey <paulb@mellanox.com>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"leon@kernel.org" <leon@kernel.org>
Subject: Re: [PATCH] net/mlx5e: Fix an IS_ERR() vs NULL check
Date: Thu, 05 Mar 2020 08:00:04 +0000 [thread overview]
Message-ID: <20200305080004.GA19839@kadam> (raw)
In-Reply-To: <10527910074442142431505e9d424af9128e8c5c.camel@mellanox.com>
On Wed, Mar 04, 2020 at 08:31:13PM +0000, Saeed Mahameed wrote:
> On Wed, 2020-03-04 at 17:22 +0300, Dan Carpenter wrote:
> > The esw_vport_tbl_get() function returns error pointers on error.
> >
> > Fixes: 96e326878fa5 ("net/mlx5e: Eswitch, Use per vport tables for
> > mirroring")
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> Hi Dan the patch looks fine, but you didn't cc netdev mailing list
> Two options:
>
> 1) I can pick this patch up and repost it myself in a future pull
> request
I assumed we would do this, because the original patch didn't have
Dave's signed-off-by.
> 2) you can re-post it and cc netdev also mark it for net [PATCH net]
If we were going to go that route then it would have to [PATCH net-next]
because it doesn't apply to the net tree.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Saeed Mahameed <saeedm@mellanox.com>
Cc: Eli Cohen <eli@mellanox.com>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
Mark Bloch <markb@mellanox.com>, Paul Blakey <paulb@mellanox.com>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"leon@kernel.org" <leon@kernel.org>
Subject: Re: [PATCH] net/mlx5e: Fix an IS_ERR() vs NULL check
Date: Thu, 5 Mar 2020 11:00:04 +0300 [thread overview]
Message-ID: <20200305080004.GA19839@kadam> (raw)
In-Reply-To: <10527910074442142431505e9d424af9128e8c5c.camel@mellanox.com>
On Wed, Mar 04, 2020 at 08:31:13PM +0000, Saeed Mahameed wrote:
> On Wed, 2020-03-04 at 17:22 +0300, Dan Carpenter wrote:
> > The esw_vport_tbl_get() function returns error pointers on error.
> >
> > Fixes: 96e326878fa5 ("net/mlx5e: Eswitch, Use per vport tables for
> > mirroring")
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> Hi Dan the patch looks fine, but you didn't cc netdev mailing list
> Two options:
>
> 1) I can pick this patch up and repost it myself in a future pull
> request
I assumed we would do this, because the original patch didn't have
Dave's signed-off-by.
> 2) you can re-post it and cc netdev also mark it for net [PATCH net]
If we were going to go that route then it would have to [PATCH net-next]
because it doesn't apply to the net tree.
regards,
dan carpenter
next prev parent reply other threads:[~2020-03-05 8:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-04 14:22 [PATCH] net/mlx5e: Fix an IS_ERR() vs NULL check Dan Carpenter
2020-03-04 14:22 ` Dan Carpenter
2020-03-04 20:31 ` Saeed Mahameed
2020-03-04 20:31 ` Saeed Mahameed
2020-03-05 8:00 ` Dan Carpenter [this message]
2020-03-05 8:00 ` Dan Carpenter
2020-03-05 23:11 ` Saeed Mahameed
2020-03-05 23:11 ` Saeed Mahameed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200305080004.GA19839@kadam \
--to=dan.carpenter@oracle.com \
--cc=eli@mellanox.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=markb@mellanox.com \
--cc=paulb@mellanox.com \
--cc=saeedm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.