[PATCH] net/mlx5e: Fix an IS_ERR() vs NULL check

[PATCH] net/mlx5e: Fix an IS_ERR() vs NULL check

[Dan Carpenter]

The esw_vport_tbl_get() function returns error pointers on error.

Fixes: 96e326878fa5 ("net/mlx5e: Eswitch, Use per vport tables for mirroring")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c b/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c
index 4b5b6618dff4..692fe9e6a08f 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c
@@ -198,7 +198,7 @@ int mlx5_esw_vport_tbl_get(struct mlx5_eswitch *esw)
 	mlx5_esw_for_all_vports(esw, i, vport) {
 		attr.in_rep->vport = vport->vport;
 		fdb = esw_vport_tbl_get(esw, &attr);
-		if (!fdb)
+		if (IS_ERR(fdb))
 			goto out;
 	}
 	return 0;
-- 
2.11.0

[PATCH] net/mlx5e: Fix an IS_ERR() vs NULL check

[Dan Carpenter]

The esw_vport_tbl_get() function returns error pointers on error.

Fixes: 96e326878fa5 ("net/mlx5e: Eswitch, Use per vport tables for mirroring")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c b/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c
index 4b5b6618dff4..692fe9e6a08f 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c
@@ -198,7 +198,7 @@ int mlx5_esw_vport_tbl_get(struct mlx5_eswitch *esw)
 	mlx5_esw_for_all_vports(esw, i, vport) {
 		attr.in_rep->vport = vport->vport;
 		fdb = esw_vport_tbl_get(esw, &attr);
-		if (!fdb)
+		if (IS_ERR(fdb))
 			goto out;
 	}
 	return 0;
-- 
2.11.0

Re: [PATCH] net/mlx5e: Fix an IS_ERR() vs NULL check

[Saeed Mahameed]

T24gV2VkLCAyMDIwLTAzLTA0IGF0IDE3OjIyICswMzAwLCBEYW4gQ2FycGVudGVyIHdyb3RlOg0K
PiBUaGUgZXN3X3Zwb3J0X3RibF9nZXQoKSBmdW5jdGlvbiByZXR1cm5zIGVycm9yIHBvaW50ZXJz
IG9uIGVycm9yLg0KPiANCj4gRml4ZXM6IDk2ZTMyNjg3OGZhNSAoIm5ldC9tbHg1ZTogRXN3aXRj
aCwgVXNlIHBlciB2cG9ydCB0YWJsZXMgZm9yDQo+IG1pcnJvcmluZyIpDQo+IFNpZ25lZC1vZmYt
Ynk6IERhbiBDYXJwZW50ZXIgPGRhbi5jYXJwZW50ZXJAb3JhY2xlLmNvbT4NCg0KSGkgRGFuIHRo
ZSBwYXRjaCBsb29rcyBmaW5lLCBidXQgeW91IGRpZG4ndCBjYyBuZXRkZXYgbWFpbGluZyBsaXN0
DQpUd28gb3B0aW9uczoNCg0KMSkgSSBjYW4gcGljayB0aGlzIHBhdGNoIHVwIGFuZCByZXBvc3Qg
aXQgbXlzZWxmIGluIGEgZnV0dXJlIHB1bGwNCnJlcXVlc3QNCjIpIHlvdSBjYW4gcmUtcG9zdCBp
dCBhbmQgY2MgbmV0ZGV2IGFsc28gbWFyayBpdCBmb3IgbmV0IFtQQVRDSCBuZXRdDQoNCmxldCBt
ZSBrbm93IHdoYXQgeW91IHByZWZlci4NCg0KVGhhbmtzLA0KU2FlZWQuDQoNCg0KPiAtLS0NCj4g
IGRyaXZlcnMvbmV0L2V0aGVybmV0L21lbGxhbm94L21seDUvY29yZS9lc3dpdGNoX29mZmxvYWRz
LmMgfCAyICstDQo+ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24o
LSkNCj4gDQo+IGRpZmYgLS1naXQNCj4gYS9kcml2ZXJzL25ldC9ldGhlcm5ldC9tZWxsYW5veC9t
bHg1L2NvcmUvZXN3aXRjaF9vZmZsb2Fkcy5jDQo+IGIvZHJpdmVycy9uZXQvZXRoZXJuZXQvbWVs
bGFub3gvbWx4NS9jb3JlL2Vzd2l0Y2hfb2ZmbG9hZHMuYw0KPiBpbmRleCA0YjViNjYxOGRmZjQu
LjY5MmZlOWU2YTA4ZiAxMDA2NDQNCj4gLS0tIGEvZHJpdmVycy9uZXQvZXRoZXJuZXQvbWVsbGFu
b3gvbWx4NS9jb3JlL2Vzd2l0Y2hfb2ZmbG9hZHMuYw0KPiArKysgYi9kcml2ZXJzL25ldC9ldGhl
cm5ldC9tZWxsYW5veC9tbHg1L2NvcmUvZXN3aXRjaF9vZmZsb2Fkcy5jDQo+IEBAIC0xOTgsNyAr
MTk4LDcgQEAgaW50IG1seDVfZXN3X3Zwb3J0X3RibF9nZXQoc3RydWN0IG1seDVfZXN3aXRjaA0K
PiAqZXN3KQ0KPiAgCW1seDVfZXN3X2Zvcl9hbGxfdnBvcnRzKGVzdywgaSwgdnBvcnQpIHsNCj4g
IAkJYXR0ci5pbl9yZXAtPnZwb3J0ID0gdnBvcnQtPnZwb3J0Ow0KPiAgCQlmZGIgPSBlc3dfdnBv
cnRfdGJsX2dldChlc3csICZhdHRyKTsNCj4gLQkJaWYgKCFmZGIpDQo+ICsJCWlmIChJU19FUlIo
ZmRiKSkNCj4gIAkJCWdvdG8gb3V0Ow0KPiAgCX0NCj4gIAlyZXR1cm4gMDsNCg=

Re: [PATCH] net/mlx5e: Fix an IS_ERR() vs NULL check

[Saeed Mahameed]

On Wed, 2020-03-04 at 17:22 +0300, Dan Carpenter wrote:
> The esw_vport_tbl_get() function returns error pointers on error.
> 
> Fixes: 96e326878fa5 ("net/mlx5e: Eswitch, Use per vport tables for
> mirroring")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Hi Dan the patch looks fine, but you didn't cc netdev mailing list
Two options:

1) I can pick this patch up and repost it myself in a future pull
request
2) you can re-post it and cc netdev also mark it for net [PATCH net]

let me know what you prefer.

Thanks,
Saeed.


> ---
>  drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git
> a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c
> b/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c
> index 4b5b6618dff4..692fe9e6a08f 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c
> @@ -198,7 +198,7 @@ int mlx5_esw_vport_tbl_get(struct mlx5_eswitch
> *esw)
>  	mlx5_esw_for_all_vports(esw, i, vport) {
>  		attr.in_rep->vport = vport->vport;
>  		fdb = esw_vport_tbl_get(esw, &attr);
> -		if (!fdb)
> +		if (IS_ERR(fdb))
>  			goto out;
>  	}
>  	return 0;

Re: [PATCH] net/mlx5e: Fix an IS_ERR() vs NULL check

[Dan Carpenter]

On Wed, Mar 04, 2020 at 08:31:13PM +0000, Saeed Mahameed wrote:
> On Wed, 2020-03-04 at 17:22 +0300, Dan Carpenter wrote:
> > The esw_vport_tbl_get() function returns error pointers on error.
> > 
> > Fixes: 96e326878fa5 ("net/mlx5e: Eswitch, Use per vport tables for
> > mirroring")
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> Hi Dan the patch looks fine, but you didn't cc netdev mailing list
> Two options:
> 
> 1) I can pick this patch up and repost it myself in a future pull
> request

I assumed we would do this, because the original patch didn't have
Dave's signed-off-by.

> 2) you can re-post it and cc netdev also mark it for net [PATCH net]

If we were going to go that route then it would have to [PATCH net-next]
because it doesn't apply to the net tree.

regards,
dan carpenter

Re: [PATCH] net/mlx5e: Fix an IS_ERR() vs NULL check

[Dan Carpenter]

On Wed, Mar 04, 2020 at 08:31:13PM +0000, Saeed Mahameed wrote:
> On Wed, 2020-03-04 at 17:22 +0300, Dan Carpenter wrote:
> > The esw_vport_tbl_get() function returns error pointers on error.
> > 
> > Fixes: 96e326878fa5 ("net/mlx5e: Eswitch, Use per vport tables for
> > mirroring")
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> Hi Dan the patch looks fine, but you didn't cc netdev mailing list
> Two options:
> 
> 1) I can pick this patch up and repost it myself in a future pull
> request

I assumed we would do this, because the original patch didn't have
Dave's signed-off-by.

> 2) you can re-post it and cc netdev also mark it for net [PATCH net]

If we were going to go that route then it would have to [PATCH net-next]
because it doesn't apply to the net tree.

regards,
dan carpenter

Re: [PATCH] net/mlx5e: Fix an IS_ERR() vs NULL check

[Saeed Mahameed]

T24gVGh1LCAyMDIwLTAzLTA1IGF0IDExOjAwICswMzAwLCBEYW4gQ2FycGVudGVyIHdyb3RlOg0K
PiBPbiBXZWQsIE1hciAwNCwgMjAyMCBhdCAwODozMToxM1BNICswMDAwLCBTYWVlZCBNYWhhbWVl
ZCB3cm90ZToNCj4gPiBPbiBXZWQsIDIwMjAtMDMtMDQgYXQgMTc6MjIgKzAzMDAsIERhbiBDYXJw
ZW50ZXIgd3JvdGU6DQo+ID4gPiBUaGUgZXN3X3Zwb3J0X3RibF9nZXQoKSBmdW5jdGlvbiByZXR1
cm5zIGVycm9yIHBvaW50ZXJzIG9uIGVycm9yLg0KPiA+ID4gDQo+ID4gPiBGaXhlczogOTZlMzI2
ODc4ZmE1ICgibmV0L21seDVlOiBFc3dpdGNoLCBVc2UgcGVyIHZwb3J0IHRhYmxlcw0KPiA+ID4g
Zm9yDQo+ID4gPiBtaXJyb3JpbmciKQ0KPiA+ID4gU2lnbmVkLW9mZi1ieTogRGFuIENhcnBlbnRl
ciA8ZGFuLmNhcnBlbnRlckBvcmFjbGUuY29tPg0KPiA+IA0KPiA+IEhpIERhbiB0aGUgcGF0Y2gg
bG9va3MgZmluZSwgYnV0IHlvdSBkaWRuJ3QgY2MgbmV0ZGV2IG1haWxpbmcgbGlzdA0KPiA+IFR3
byBvcHRpb25zOg0KPiA+IA0KPiA+IDEpIEkgY2FuIHBpY2sgdGhpcyBwYXRjaCB1cCBhbmQgcmVw
b3N0IGl0IG15c2VsZiBpbiBhIGZ1dHVyZSBwdWxsDQo+ID4gcmVxdWVzdA0KPiANCj4gSSBhc3N1
bWVkIHdlIHdvdWxkIGRvIHRoaXMsIGJlY2F1c2UgdGhlIG9yaWdpbmFsIHBhdGNoIGRpZG4ndCBo
YXZlDQo+IERhdmUncyBzaWduZWQtb2ZmLWJ5Lg0KPiANCg0KV2UgbWFpbnRhaW4gdGhlIG5ldC1u
ZXh0LW1seDUgYnJhbmNoIHVuZGVyIG5ldGRldiBtYWlsaW5nIGxpc3QuDQoNCj4gPiAyKSB5b3Ug
Y2FuIHJlLXBvc3QgaXQgYW5kIGNjIG5ldGRldiBhbHNvIG1hcmsgaXQgZm9yIG5ldCBbUEFUQ0gN
Cj4gPiBuZXRdDQo+IA0KPiBJZiB3ZSB3ZXJlIGdvaW5nIHRvIGdvIHRoYXQgcm91dGUgdGhlbiBp
dCB3b3VsZCBoYXZlIHRvIFtQQVRDSCBuZXQtDQo+IG5leHRdDQo+IGJlY2F1c2UgaXQgZG9lc24n
dCBhcHBseSB0byB0aGUgbmV0IHRyZWUuDQo+IA0KDQpJIHNlZSwgaSB3aWxsIHRha2UgaXQgbXlz
ZWxmIHRvIG5ldC1uZXh0LW1seDUgYW5kIHdpbGwgc3VibWl0IHRvIG5ldC0NCm5leHQgc29vbiBp
biBteSBuZXh0IHB1bGwgcmVxdWVzdCB0byBkYXZlLg0KDQpUaGFua3MsDQpTYWVlZC4NCg0K

Re: [PATCH] net/mlx5e: Fix an IS_ERR() vs NULL check

[Saeed Mahameed]

On Thu, 2020-03-05 at 11:00 +0300, Dan Carpenter wrote:
> On Wed, Mar 04, 2020 at 08:31:13PM +0000, Saeed Mahameed wrote:
> > On Wed, 2020-03-04 at 17:22 +0300, Dan Carpenter wrote:
> > > The esw_vport_tbl_get() function returns error pointers on error.
> > > 
> > > Fixes: 96e326878fa5 ("net/mlx5e: Eswitch, Use per vport tables
> > > for
> > > mirroring")
> > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > 
> > Hi Dan the patch looks fine, but you didn't cc netdev mailing list
> > Two options:
> > 
> > 1) I can pick this patch up and repost it myself in a future pull
> > request
> 
> I assumed we would do this, because the original patch didn't have
> Dave's signed-off-by.
> 

We maintain the net-next-mlx5 branch under netdev mailing list.

> > 2) you can re-post it and cc netdev also mark it for net [PATCH
> > net]
> 
> If we were going to go that route then it would have to [PATCH net-
> next]
> because it doesn't apply to the net tree.
> 

I see, i will take it myself to net-next-mlx5 and will submit to net-
next soon in my next pull request to dave.

Thanks,
Saeed.