From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: linux-integrity@vger.kernel.org, Mimi Zohar <zohar@linux.ibm.com>,
David Woodhouse <dwmw2@infradead.org>,
keyrings@vger.kernel.org
Subject: Re: [PATCH v7 1/6] lib: add ASN.1 encoder
Date: Fri, 06 Mar 2020 19:10:29 +0000 [thread overview]
Message-ID: <20200306191029.GI7472@linux.intel.com> (raw)
In-Reply-To: <20200305022744.12492-2-James.Bottomley@HansenPartnership.com>
On Wed, Mar 04, 2020 at 06:27:39PM -0800, James Bottomley wrote:
> We have a need in the TPM2 trusted keys to return the ASN.1 form of
> the TPM key blob so it can be operated on by tools outside of the
> kernel. The specific tools are the openssl_tpm2_engine, openconnect
> and the Intel tpm2-tss-engine. To do that, we have to be able to read
> and write the same binary key format the tools use. The current ASN.1
> decoder does fine for reading, but we need pieces of an ASN.1 encoder
> to write the key blob in binary compatible form.
>
> For backwards compatibility, the trusted key reader code will still
> accept the two TPM2B quantities that it uses today, but the writer
> will only output the ASN.1 form.
>
> The current implementation only encodes the ASN.1 bits we actually need.
>
> Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
For me this looks good (saw your other mail about spacing, no worries).
Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
/Jarkko
WARNING: multiple messages have this Message-ID (diff)
From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: linux-integrity@vger.kernel.org, Mimi Zohar <zohar@linux.ibm.com>,
David Woodhouse <dwmw2@infradead.org>,
keyrings@vger.kernel.org
Subject: Re: [PATCH v7 1/6] lib: add ASN.1 encoder
Date: Fri, 6 Mar 2020 21:10:29 +0200 [thread overview]
Message-ID: <20200306191029.GI7472@linux.intel.com> (raw)
In-Reply-To: <20200305022744.12492-2-James.Bottomley@HansenPartnership.com>
On Wed, Mar 04, 2020 at 06:27:39PM -0800, James Bottomley wrote:
> We have a need in the TPM2 trusted keys to return the ASN.1 form of
> the TPM key blob so it can be operated on by tools outside of the
> kernel. The specific tools are the openssl_tpm2_engine, openconnect
> and the Intel tpm2-tss-engine. To do that, we have to be able to read
> and write the same binary key format the tools use. The current ASN.1
> decoder does fine for reading, but we need pieces of an ASN.1 encoder
> to write the key blob in binary compatible form.
>
> For backwards compatibility, the trusted key reader code will still
> accept the two TPM2B quantities that it uses today, but the writer
> will only output the ASN.1 form.
>
> The current implementation only encodes the ASN.1 bits we actually need.
>
> Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
For me this looks good (saw your other mail about spacing, no worries).
Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
/Jarkko
next prev parent reply other threads:[~2020-03-06 19:10 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-05 2:27 [PATCH v7 0/6] TPM 2.0 trusted keys with attached policy James Bottomley
2020-03-05 2:27 ` James Bottomley
2020-03-05 2:27 ` [PATCH v7 1/6] lib: add ASN.1 encoder James Bottomley
2020-03-05 2:27 ` James Bottomley
2020-03-05 16:20 ` James Bottomley
2020-03-05 16:20 ` James Bottomley
2020-03-06 19:10 ` Jarkko Sakkinen [this message]
2020-03-06 19:10 ` Jarkko Sakkinen
2020-03-05 2:27 ` [PATCH v7 2/6] oid_registry: Add TCG defined OIDS for TPM keys James Bottomley
2020-03-05 2:27 ` James Bottomley
2020-03-05 2:27 ` [PATCH v7 3/6] security: keys: trusted: fix TPM2 authorizations James Bottomley
2020-03-05 2:27 ` James Bottomley
2020-03-06 19:52 ` Jarkko Sakkinen
2020-03-06 19:52 ` Jarkko Sakkinen
2020-03-05 2:27 ` [PATCH v7 4/6] security: keys: trusted: use ASN.1 TPM2 key format for the blobs James Bottomley
2020-03-05 2:27 ` James Bottomley
2020-03-06 20:03 ` Jarkko Sakkinen
2020-03-06 20:03 ` Jarkko Sakkinen
2020-03-07 22:00 ` Jarkko Sakkinen
2020-03-07 22:00 ` Jarkko Sakkinen
2020-03-09 13:59 ` James Bottomley
2020-03-09 13:59 ` James Bottomley
2020-03-09 22:08 ` James Bottomley
2020-03-09 22:08 ` James Bottomley
2020-03-05 2:27 ` [PATCH v7 5/6] security: keys: trusted: add ability to specify arbitrary policy James Bottomley
2020-03-05 2:27 ` James Bottomley
2020-03-05 2:27 ` [PATCH v7 6/6] security: keys: trusted: implement counter/timer policy James Bottomley
2020-03-05 2:27 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200306191029.GI7472@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=dwmw2@infradead.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.