From: Lu Baolu <baolu.lu@linux.intel.com>
To: Joerg Roedel <joro@8bytes.org>
Cc: kevin.tian@intel.com, ashok.raj@intel.com,
linux-kernel@vger.kernel.org, Daniel Drake <drake@endlessm.com>,
iommu@lists.linux-foundation.org,
Robin Murphy <robin.murphy@arm.com>,
Christoph Hellwig <hch@lst.de>,
Derrick Jonathan <jonathan.derrick@intel.com>
Subject: [PATCH 1/6] iommu: Add dev_def_domain_type() callback in iommu_ops
Date: Sat, 7 Mar 2020 14:20:09 +0800 [thread overview]
Message-ID: <20200307062014.3288-2-baolu.lu@linux.intel.com> (raw)
In-Reply-To: <20200307062014.3288-1-baolu.lu@linux.intel.com>
From: Sai Praneeth Prakhya <sai.praneeth.prakhya@intel.com>
Some devices are reqired to use a specific type (identity or dma)
of default domain when they are used with a vendor iommu. When the
system level default domain type is different from it, the vendor
iommu driver has to request a new default domain with
iommu_request_dma_domain_for_dev() and iommu_request_dm_for_dev()
in the add_dev() callback. Unfortunately, these two helpers only
work when the group hasn't been assigned to any other devices,
hence, some vendor iommu driver has to use a private domain if
it fails to request a new default one.
This adds dev_def_domain_type() callback in the iommu_ops, so that
the special requirement of default domain for a device could be
aware by the iommu generic layer.
Signed-off-by: Sai Praneeth Prakhya <sai.praneeth.prakhya@intel.com>
Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
---
include/linux/iommu.h | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/include/linux/iommu.h b/include/linux/iommu.h
index d1b5f4d98569..0c1e95e6b263 100644
--- a/include/linux/iommu.h
+++ b/include/linux/iommu.h
@@ -248,6 +248,10 @@ struct iommu_iotlb_gather {
* @cache_invalidate: invalidate translation caches
* @sva_bind_gpasid: bind guest pasid and mm
* @sva_unbind_gpasid: unbind guest pasid and mm
+ * @dev_def_domain_type: device default domain type, return value:
+ * - IOMMU_DOMAIN_IDENTITY: must use an identity domain
+ * - IOMMU_DOMAIN_DMA: must use a dma domain
+ * - 0: use the default setting
* @pgsize_bitmap: bitmap of all possible supported page sizes
* @owner: Driver module providing these ops
*/
@@ -318,6 +322,8 @@ struct iommu_ops {
int (*sva_unbind_gpasid)(struct device *dev, int pasid);
+ int (*dev_def_domain_type)(struct device *dev);
+
unsigned long pgsize_bitmap;
struct module *owner;
};
--
2.17.1
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Lu Baolu <baolu.lu@linux.intel.com>
To: Joerg Roedel <joro@8bytes.org>
Cc: ashok.raj@intel.com, jacob.jun.pan@linux.intel.com,
kevin.tian@intel.com, iommu@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, Daniel Drake <drake@endlessm.com>,
Derrick Jonathan <jonathan.derrick@intel.com>,
Jerry Snitselaar <jsnitsel@redhat.com>,
Robin Murphy <robin.murphy@arm.com>,
Christoph Hellwig <hch@lst.de>,
Sai Praneeth Prakhya <sai.praneeth.prakhya@intel.com>,
Lu Baolu <baolu.lu@linux.intel.com>
Subject: [PATCH 1/6] iommu: Add dev_def_domain_type() callback in iommu_ops
Date: Sat, 7 Mar 2020 14:20:09 +0800 [thread overview]
Message-ID: <20200307062014.3288-2-baolu.lu@linux.intel.com> (raw)
In-Reply-To: <20200307062014.3288-1-baolu.lu@linux.intel.com>
From: Sai Praneeth Prakhya <sai.praneeth.prakhya@intel.com>
Some devices are reqired to use a specific type (identity or dma)
of default domain when they are used with a vendor iommu. When the
system level default domain type is different from it, the vendor
iommu driver has to request a new default domain with
iommu_request_dma_domain_for_dev() and iommu_request_dm_for_dev()
in the add_dev() callback. Unfortunately, these two helpers only
work when the group hasn't been assigned to any other devices,
hence, some vendor iommu driver has to use a private domain if
it fails to request a new default one.
This adds dev_def_domain_type() callback in the iommu_ops, so that
the special requirement of default domain for a device could be
aware by the iommu generic layer.
Signed-off-by: Sai Praneeth Prakhya <sai.praneeth.prakhya@intel.com>
Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
---
include/linux/iommu.h | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/include/linux/iommu.h b/include/linux/iommu.h
index d1b5f4d98569..0c1e95e6b263 100644
--- a/include/linux/iommu.h
+++ b/include/linux/iommu.h
@@ -248,6 +248,10 @@ struct iommu_iotlb_gather {
* @cache_invalidate: invalidate translation caches
* @sva_bind_gpasid: bind guest pasid and mm
* @sva_unbind_gpasid: unbind guest pasid and mm
+ * @dev_def_domain_type: device default domain type, return value:
+ * - IOMMU_DOMAIN_IDENTITY: must use an identity domain
+ * - IOMMU_DOMAIN_DMA: must use a dma domain
+ * - 0: use the default setting
* @pgsize_bitmap: bitmap of all possible supported page sizes
* @owner: Driver module providing these ops
*/
@@ -318,6 +322,8 @@ struct iommu_ops {
int (*sva_unbind_gpasid)(struct device *dev, int pasid);
+ int (*dev_def_domain_type)(struct device *dev);
+
unsigned long pgsize_bitmap;
struct module *owner;
};
--
2.17.1
next prev parent reply other threads:[~2020-03-07 6:23 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-07 6:20 [PATCH 0/6] Replace private domain with per-group default Lu Baolu
2020-03-07 6:20 ` Lu Baolu
2020-03-07 6:20 ` Lu Baolu [this message]
2020-03-07 6:20 ` [PATCH 1/6] iommu: Add dev_def_domain_type() callback in iommu_ops Lu Baolu
2020-03-07 14:18 ` Christoph Hellwig
2020-03-07 14:18 ` Christoph Hellwig
2020-03-08 2:08 ` Lu Baolu
2020-03-08 2:08 ` Lu Baolu
2020-03-07 6:20 ` [PATCH 2/6] iommu: Configure default domain with dev_def_domain_type Lu Baolu
2020-03-07 6:20 ` Lu Baolu
2020-03-07 6:20 ` [PATCH 3/6] iommu/vt-d: Don't force 32bit devices to uses DMA domain Lu Baolu
2020-03-07 6:20 ` Lu Baolu
2020-03-07 14:21 ` Christoph Hellwig
2020-03-07 14:21 ` Christoph Hellwig
2020-03-08 2:15 ` Lu Baolu
2020-03-08 2:15 ` Lu Baolu
2020-03-10 10:58 ` Joerg Roedel
2020-03-10 10:58 ` Joerg Roedel
2020-03-07 6:20 ` [PATCH 4/6] iommu/vt-d: Don't force PCI sub-hierarchy to use " Lu Baolu
2020-03-07 6:20 ` Lu Baolu
2020-03-07 6:20 ` [PATCH 5/6] iommu/vt-d: Add dev_def_domain_type callback Lu Baolu
2020-03-07 6:20 ` Lu Baolu
2020-03-07 6:20 ` [PATCH 6/6] iommu/vt-d: Apply per-device dma_ops Lu Baolu
2020-03-07 6:20 ` Lu Baolu
2020-03-10 11:15 ` [PATCH 0/6] Replace private domain with per-group default Joerg Roedel
2020-03-10 11:15 ` Joerg Roedel
2020-03-11 6:50 ` Lu Baolu
2020-03-11 6:50 ` Lu Baolu
2020-03-13 13:36 ` Joerg Roedel
2020-03-13 13:36 ` Joerg Roedel
2020-03-14 1:13 ` Lu Baolu
2020-03-14 1:13 ` Lu Baolu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200307062014.3288-2-baolu.lu@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=ashok.raj@intel.com \
--cc=drake@endlessm.com \
--cc=hch@lst.de \
--cc=iommu@lists.linux-foundation.org \
--cc=jonathan.derrick@intel.com \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.