All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joerg Roedel <joro@8bytes.org>
To: Lu Baolu <baolu.lu@linux.intel.com>
Cc: kevin.tian@intel.com, ashok.raj@intel.com,
	linux-kernel@vger.kernel.org, Daniel Drake <drake@endlessm.com>,
	iommu@lists.linux-foundation.org,
	Robin Murphy <robin.murphy@arm.com>,
	Christoph Hellwig <hch@lst.de>,
	Derrick Jonathan <jonathan.derrick@intel.com>
Subject: Re: [PATCH 0/6] Replace private domain with per-group default
Date: Fri, 13 Mar 2020 14:36:44 +0100	[thread overview]
Message-ID: <20200313133644.GO3794@8bytes.org> (raw)
In-Reply-To: <cd0f526c-da68-ef59-580f-665ad08a395f@linux.intel.com>

On Wed, Mar 11, 2020 at 02:50:39PM +0800, Lu Baolu wrote:
> On 2020/3/10 19:15, Joerg Roedel wrote:
> > Hi Baolu,
> > 
> > On Sat, Mar 07, 2020 at 02:20:08PM +0800, Lu Baolu wrote:
> > > Lu Baolu (5):
> > >    iommu: Configure default domain with dev_def_domain_type
> > >    iommu/vt-d: Don't force 32bit devices to uses DMA domain
> > >    iommu/vt-d: Don't force PCI sub-hierarchy to use DMA domain
> > >    iommu/vt-d: Add dev_def_domain_type callback
> > >    iommu/vt-d: Apply per-device dma_ops
> > > 
> > > Sai Praneeth Prakhya (1):
> > >    iommu: Add dev_def_domain_type() callback in iommu_ops
> > 
> > I like this patch-set, but I fear some regressions from patch
> > "iommu/vt-d: Don't force 32bit devices to uses DMA domain". Have you
> > tested this series on a couple of machines, ideally even older ones from
> > the first generation of VT-d hardware?
> 
> The oldest hardware I have is Ivy Bridge. :-) Actually, The effect of
> using identity domain for 32-bit devices is the same as that of adding
> intel_iommu=off in the kernel parameter. Hence, if there is any
> regression, people should also find it with intel_iommu=off.
> intel_iommu=off support is added at the very beginning of VT-d driver.

Okay, I will also do some testing on it, one of my VT-d machines is a
Haswell. Please send a new version with the recent comments addressed.

Regards,

	Joerg
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Lu Baolu <baolu.lu@linux.intel.com>
Cc: ashok.raj@intel.com, jacob.jun.pan@linux.intel.com,
	kevin.tian@intel.com, iommu@lists.linux-foundation.org,
	linux-kernel@vger.kernel.org, Daniel Drake <drake@endlessm.com>,
	Derrick Jonathan <jonathan.derrick@intel.com>,
	Jerry Snitselaar <jsnitsel@redhat.com>,
	Robin Murphy <robin.murphy@arm.com>,
	Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 0/6] Replace private domain with per-group default
Date: Fri, 13 Mar 2020 14:36:44 +0100	[thread overview]
Message-ID: <20200313133644.GO3794@8bytes.org> (raw)
In-Reply-To: <cd0f526c-da68-ef59-580f-665ad08a395f@linux.intel.com>

On Wed, Mar 11, 2020 at 02:50:39PM +0800, Lu Baolu wrote:
> On 2020/3/10 19:15, Joerg Roedel wrote:
> > Hi Baolu,
> > 
> > On Sat, Mar 07, 2020 at 02:20:08PM +0800, Lu Baolu wrote:
> > > Lu Baolu (5):
> > >    iommu: Configure default domain with dev_def_domain_type
> > >    iommu/vt-d: Don't force 32bit devices to uses DMA domain
> > >    iommu/vt-d: Don't force PCI sub-hierarchy to use DMA domain
> > >    iommu/vt-d: Add dev_def_domain_type callback
> > >    iommu/vt-d: Apply per-device dma_ops
> > > 
> > > Sai Praneeth Prakhya (1):
> > >    iommu: Add dev_def_domain_type() callback in iommu_ops
> > 
> > I like this patch-set, but I fear some regressions from patch
> > "iommu/vt-d: Don't force 32bit devices to uses DMA domain". Have you
> > tested this series on a couple of machines, ideally even older ones from
> > the first generation of VT-d hardware?
> 
> The oldest hardware I have is Ivy Bridge. :-) Actually, The effect of
> using identity domain for 32-bit devices is the same as that of adding
> intel_iommu=off in the kernel parameter. Hence, if there is any
> regression, people should also find it with intel_iommu=off.
> intel_iommu=off support is added at the very beginning of VT-d driver.

Okay, I will also do some testing on it, one of my VT-d machines is a
Haswell. Please send a new version with the recent comments addressed.

Regards,

	Joerg

  reply	other threads:[~2020-03-13 13:36 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-07  6:20 [PATCH 0/6] Replace private domain with per-group default Lu Baolu
2020-03-07  6:20 ` Lu Baolu
2020-03-07  6:20 ` [PATCH 1/6] iommu: Add dev_def_domain_type() callback in iommu_ops Lu Baolu
2020-03-07  6:20   ` Lu Baolu
2020-03-07 14:18   ` Christoph Hellwig
2020-03-07 14:18     ` Christoph Hellwig
2020-03-08  2:08     ` Lu Baolu
2020-03-08  2:08       ` Lu Baolu
2020-03-07  6:20 ` [PATCH 2/6] iommu: Configure default domain with dev_def_domain_type Lu Baolu
2020-03-07  6:20   ` Lu Baolu
2020-03-07  6:20 ` [PATCH 3/6] iommu/vt-d: Don't force 32bit devices to uses DMA domain Lu Baolu
2020-03-07  6:20   ` Lu Baolu
2020-03-07 14:21   ` Christoph Hellwig
2020-03-07 14:21     ` Christoph Hellwig
2020-03-08  2:15     ` Lu Baolu
2020-03-08  2:15       ` Lu Baolu
2020-03-10 10:58     ` Joerg Roedel
2020-03-10 10:58       ` Joerg Roedel
2020-03-07  6:20 ` [PATCH 4/6] iommu/vt-d: Don't force PCI sub-hierarchy to use " Lu Baolu
2020-03-07  6:20   ` Lu Baolu
2020-03-07  6:20 ` [PATCH 5/6] iommu/vt-d: Add dev_def_domain_type callback Lu Baolu
2020-03-07  6:20   ` Lu Baolu
2020-03-07  6:20 ` [PATCH 6/6] iommu/vt-d: Apply per-device dma_ops Lu Baolu
2020-03-07  6:20   ` Lu Baolu
2020-03-10 11:15 ` [PATCH 0/6] Replace private domain with per-group default Joerg Roedel
2020-03-10 11:15   ` Joerg Roedel
2020-03-11  6:50   ` Lu Baolu
2020-03-11  6:50     ` Lu Baolu
2020-03-13 13:36     ` Joerg Roedel [this message]
2020-03-13 13:36       ` Joerg Roedel
2020-03-14  1:13       ` Lu Baolu
2020-03-14  1:13         ` Lu Baolu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200313133644.GO3794@8bytes.org \
    --to=joro@8bytes.org \
    --cc=ashok.raj@intel.com \
    --cc=baolu.lu@linux.intel.com \
    --cc=drake@endlessm.com \
    --cc=hch@lst.de \
    --cc=iommu@lists.linux-foundation.org \
    --cc=jonathan.derrick@intel.com \
    --cc=kevin.tian@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robin.murphy@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.