* Re: [Outreachy kernel] [PATCH] staging : comedi : dt2801 : remove old unused code
2020-03-10 15:50 [PATCH] staging : comedi : dt2801 : remove old unused code Deepak R Varma
@ 2020-03-10 16:22 ` Julia Lawall
2020-03-10 17:45 ` Deepak Varma
` (2 subsequent siblings)
3 siblings, 0 replies; 7+ messages in thread
From: Julia Lawall @ 2020-03-10 16:22 UTC (permalink / raw)
To: Deepak R Varma; +Cc: outreachy-kernel, abbotti, hsweeten, gregkh, daniel.baluta
Subject lines don't have spaces before the colons.
You can alywas looks at other subject lines on the same file to see what
others have done:
git log --oneline filename.c
julia
On Tue, 10 Mar 2020, Deepak R Varma wrote:
> there are 2 #if 0 blocks that have no recent history of any change. We
> can remove those code blocks for improved readability of the code.
>
> Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com>
> ---
> drivers/staging/comedi/drivers/dt2801.c | 22 ----------------------
> 1 file changed, 22 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/dt2801.c b/drivers/staging/comedi/drivers/dt2801.c
> index a29880981d81..aad02faa2f83 100644
> --- a/drivers/staging/comedi/drivers/dt2801.c
> +++ b/drivers/staging/comedi/drivers/dt2801.c
> @@ -87,17 +87,6 @@
> #define DT2801_STATUS 1
> #define DT2801_CMD 1
>
> -#if 0
> -/* ignore 'defined but not used' warning */
> -static const struct comedi_lrange range_dt2801_ai_pgh_bipolar = {
> - 4, {
> - BIP_RANGE(10),
> - BIP_RANGE(5),
> - BIP_RANGE(2.5),
> - BIP_RANGE(1.25)
> - }
> -};
> -#endif
> static const struct comedi_lrange range_dt2801_ai_pgl_bipolar = {
> 4, {
> BIP_RANGE(10),
> @@ -107,17 +96,6 @@ static const struct comedi_lrange range_dt2801_ai_pgl_bipolar = {
> }
> };
>
> -#if 0
> -/* ignore 'defined but not used' warning */
> -static const struct comedi_lrange range_dt2801_ai_pgh_unipolar = {
> - 4, {
> - UNI_RANGE(10),
> - UNI_RANGE(5),
> - UNI_RANGE(2.5),
> - UNI_RANGE(1.25)
> - }
> -};
> -#endif
> static const struct comedi_lrange range_dt2801_ai_pgl_unipolar = {
> 4, {
> UNI_RANGE(10),
> --
> 2.17.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200310155053.GA27759%40deeUbuntu.
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] staging : comedi : dt2801 : remove old unused code
2020-03-10 15:50 [PATCH] staging : comedi : dt2801 : remove old unused code Deepak R Varma
2020-03-10 16:22 ` [Outreachy kernel] " Julia Lawall
@ 2020-03-10 17:45 ` Deepak Varma
2020-03-10 17:53 ` [Outreachy kernel] " Julia Lawall
2020-03-10 18:38 ` Deepak Varma
2020-03-10 20:35 ` Deepak Varma
3 siblings, 1 reply; 7+ messages in thread
From: Deepak Varma @ 2020-03-10 17:45 UTC (permalink / raw)
To: outreachy-kernel
[-- Attachment #1.1: Type: text/plain, Size: 1839 bytes --]
Thank you Julia. I will update the subject line and resubmit the patch.
Deepak.
On Tuesday, 10 March 2020 21:21:05 UTC+5:30, Deepak Varma wrote:
>
> there are 2 #if 0 blocks that have no recent history of any change. We
> can remove those code blocks for improved readability of the code.
>
> Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com>
> ---
> drivers/staging/comedi/drivers/dt2801.c | 22 ----------------------
> 1 file changed, 22 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/dt2801.c
> b/drivers/staging/comedi/drivers/dt2801.c
> index a29880981d81..aad02faa2f83 100644
> --- a/drivers/staging/comedi/drivers/dt2801.c
> +++ b/drivers/staging/comedi/drivers/dt2801.c
> @@ -87,17 +87,6 @@
> #define DT2801_STATUS 1
> #define DT2801_CMD 1
>
> -#if 0
> -/* ignore 'defined but not used' warning */
> -static const struct comedi_lrange range_dt2801_ai_pgh_bipolar = {
> - 4, {
> - BIP_RANGE(10),
> - BIP_RANGE(5),
> - BIP_RANGE(2.5),
> - BIP_RANGE(1.25)
> - }
> -};
> -#endif
> static const struct comedi_lrange range_dt2801_ai_pgl_bipolar = {
> 4, {
> BIP_RANGE(10),
> @@ -107,17 +96,6 @@ static const struct comedi_lrange
> range_dt2801_ai_pgl_bipolar = {
> }
> };
>
> -#if 0
> -/* ignore 'defined but not used' warning */
> -static const struct comedi_lrange range_dt2801_ai_pgh_unipolar = {
> - 4, {
> - UNI_RANGE(10),
> - UNI_RANGE(5),
> - UNI_RANGE(2.5),
> - UNI_RANGE(1.25)
> - }
> -};
> -#endif
> static const struct comedi_lrange range_dt2801_ai_pgl_unipolar = {
> 4, {
> UNI_RANGE(10),
> --
> 2.17.1
>
>
[-- Attachment #1.2: Type: text/html, Size: 2698 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [Outreachy kernel] Re: [PATCH] staging : comedi : dt2801 : remove old unused code
2020-03-10 17:45 ` Deepak Varma
@ 2020-03-10 17:53 ` Julia Lawall
0 siblings, 0 replies; 7+ messages in thread
From: Julia Lawall @ 2020-03-10 17:53 UTC (permalink / raw)
To: Deepak Varma; +Cc: outreachy-kernel
On Tue, 10 Mar 2020, Deepak Varma wrote:
> Thank you Julia. I will update the subject line and resubmit the patch.
Please don't top post. You seem to have removed my comment completely (I
put it at the top because it was referring to the subject line, which was
just above).
julia
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] staging : comedi : dt2801 : remove old unused code
2020-03-10 15:50 [PATCH] staging : comedi : dt2801 : remove old unused code Deepak R Varma
2020-03-10 16:22 ` [Outreachy kernel] " Julia Lawall
2020-03-10 17:45 ` Deepak Varma
@ 2020-03-10 18:38 ` Deepak Varma
2020-03-10 20:35 ` Deepak Varma
3 siblings, 0 replies; 7+ messages in thread
From: Deepak Varma @ 2020-03-10 18:38 UTC (permalink / raw)
To: outreachy-kernel
[-- Attachment #1.1: Type: text/plain, Size: 1824 bytes --]
Thank you once again Julia. I will review and resend v3.
Deepak.
On Tuesday, 10 March 2020 21:21:05 UTC+5:30, Deepak Varma wrote:
>
> there are 2 #if 0 blocks that have no recent history of any change. We
> can remove those code blocks for improved readability of the code.
>
> Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com>
> ---
> drivers/staging/comedi/drivers/dt2801.c | 22 ----------------------
> 1 file changed, 22 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/dt2801.c
> b/drivers/staging/comedi/drivers/dt2801.c
> index a29880981d81..aad02faa2f83 100644
> --- a/drivers/staging/comedi/drivers/dt2801.c
> +++ b/drivers/staging/comedi/drivers/dt2801.c
> @@ -87,17 +87,6 @@
> #define DT2801_STATUS 1
> #define DT2801_CMD 1
>
> -#if 0
> -/* ignore 'defined but not used' warning */
> -static const struct comedi_lrange range_dt2801_ai_pgh_bipolar = {
> - 4, {
> - BIP_RANGE(10),
> - BIP_RANGE(5),
> - BIP_RANGE(2.5),
> - BIP_RANGE(1.25)
> - }
> -};
> -#endif
> static const struct comedi_lrange range_dt2801_ai_pgl_bipolar = {
> 4, {
> BIP_RANGE(10),
> @@ -107,17 +96,6 @@ static const struct comedi_lrange
> range_dt2801_ai_pgl_bipolar = {
> }
> };
>
> -#if 0
> -/* ignore 'defined but not used' warning */
> -static const struct comedi_lrange range_dt2801_ai_pgh_unipolar = {
> - 4, {
> - UNI_RANGE(10),
> - UNI_RANGE(5),
> - UNI_RANGE(2.5),
> - UNI_RANGE(1.25)
> - }
> -};
> -#endif
> static const struct comedi_lrange range_dt2801_ai_pgl_unipolar = {
> 4, {
> UNI_RANGE(10),
> --
> 2.17.1
>
>
[-- Attachment #1.2: Type: text/html, Size: 2683 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] staging : comedi : dt2801 : remove old unused code
2020-03-10 15:50 [PATCH] staging : comedi : dt2801 : remove old unused code Deepak R Varma
` (2 preceding siblings ...)
2020-03-10 18:38 ` Deepak Varma
@ 2020-03-10 20:35 ` Deepak Varma
2020-03-10 20:41 ` [Outreachy kernel] " Julia Lawall
3 siblings, 1 reply; 7+ messages in thread
From: Deepak Varma @ 2020-03-10 20:35 UTC (permalink / raw)
To: outreachy-kernel
[-- Attachment #1.1: Type: text/plain, Size: 1924 bytes --]
True. I added those manually to be sure. Would you suggest I resubmit v4 or
it is okay for now and should be taken care in my next submission???
Thank you.
Deepak.
On Tuesday, 10 March 2020 21:21:05 UTC+5:30, Deepak Varma wrote:
>
> there are 2 #if 0 blocks that have no recent history of any change. We
> can remove those code blocks for improved readability of the code.
>
> Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com>
> ---
> drivers/staging/comedi/drivers/dt2801.c | 22 ----------------------
> 1 file changed, 22 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/dt2801.c
> b/drivers/staging/comedi/drivers/dt2801.c
> index a29880981d81..aad02faa2f83 100644
> --- a/drivers/staging/comedi/drivers/dt2801.c
> +++ b/drivers/staging/comedi/drivers/dt2801.c
> @@ -87,17 +87,6 @@
> #define DT2801_STATUS 1
> #define DT2801_CMD 1
>
> -#if 0
> -/* ignore 'defined but not used' warning */
> -static const struct comedi_lrange range_dt2801_ai_pgh_bipolar = {
> - 4, {
> - BIP_RANGE(10),
> - BIP_RANGE(5),
> - BIP_RANGE(2.5),
> - BIP_RANGE(1.25)
> - }
> -};
> -#endif
> static const struct comedi_lrange range_dt2801_ai_pgl_bipolar = {
> 4, {
> BIP_RANGE(10),
> @@ -107,17 +96,6 @@ static const struct comedi_lrange
> range_dt2801_ai_pgl_bipolar = {
> }
> };
>
> -#if 0
> -/* ignore 'defined but not used' warning */
> -static const struct comedi_lrange range_dt2801_ai_pgh_unipolar = {
> - 4, {
> - UNI_RANGE(10),
> - UNI_RANGE(5),
> - UNI_RANGE(2.5),
> - UNI_RANGE(1.25)
> - }
> -};
> -#endif
> static const struct comedi_lrange range_dt2801_ai_pgl_unipolar = {
> 4, {
> UNI_RANGE(10),
> --
> 2.17.1
>
>
[-- Attachment #1.2: Type: text/html, Size: 2793 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [Outreachy kernel] Re: [PATCH] staging : comedi : dt2801 : remove old unused code
2020-03-10 20:35 ` Deepak Varma
@ 2020-03-10 20:41 ` Julia Lawall
0 siblings, 0 replies; 7+ messages in thread
From: Julia Lawall @ 2020-03-10 20:41 UTC (permalink / raw)
To: Deepak Varma; +Cc: outreachy-kernel
[-- Attachment #1: Type: text/plain, Size: 3248 bytes --]
On Tue, 10 Mar 2020, Deepak Varma wrote:
> True. I added those manually to be sure. Would you suggest I resubmit v4 or
> it is okay for now and should be taken care in my next submission???
Please stop top posting and please stop removing the comments that you are
replying to. Your message should be self contained. The person looking
at only the message should understand the whole context of what you are
saying.
I think you are asking about the extra ---. Don't worry about it.
julia
>
> Thank you.
> Deepak.
>
> On Tuesday, 10 March 2020 21:21:05 UTC+5:30, Deepak Varma wrote:
> there are 2 #if 0 blocks that have no recent history of any
> change. We
> can remove those code blocks for improved readability of the
> code.
>
> Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com>
> ---
> drivers/staging/comedi/drivers/dt2801.c | 22
> ----------------------
> 1 file changed, 22 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/dt2801.c
> b/drivers/staging/comedi/drivers/dt2801.c
> index a29880981d81..aad02faa2f83 100644
> --- a/drivers/staging/comedi/drivers/dt2801.c
> +++ b/drivers/staging/comedi/drivers/dt2801.c
> @@ -87,17 +87,6 @@
> #define DT2801_STATUS 1
> #define DT2801_CMD 1
>
> -#if 0
> -/* ignore 'defined but not used' warning */
> -static const struct comedi_lrange range_dt2801_ai_pgh_bipolar =
> {
> - 4, {
> - BIP_RANGE(10),
> - BIP_RANGE(5),
> - BIP_RANGE(2.5),
> - BIP_RANGE(1.25)
> - }
> -};
> -#endif
> static const struct comedi_lrange range_dt2801_ai_pgl_bipolar =
> {
> 4, {
> BIP_RANGE(10),
> @@ -107,17 +96,6 @@ static const struct comedi_lrange
> range_dt2801_ai_pgl_bipolar = {
> }
> };
>
> -#if 0
> -/* ignore 'defined but not used' warning */
> -static const struct comedi_lrange range_dt2801_ai_pgh_unipolar
> = {
> - 4, {
> - UNI_RANGE(10),
> - UNI_RANGE(5),
> - UNI_RANGE(2.5),
> - UNI_RANGE(1.25)
> - }
> -};
> -#endif
> static const struct comedi_lrange range_dt2801_ai_pgl_unipolar
> = {
> 4, {
> UNI_RANGE(10),
> --
> 2.17.1
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/b14f8972-f6c7-4ca6-8fe6-
> 55fc3517a186%40googlegroups.com.
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread