From: Boris Brezillon <boris.brezillon@collabora.com>
To: masonccyang@mxic.com.tw
Cc: vigneshr@ti.com, bbrezillon@kernel.org, juliensu@mxic.com.tw,
richard@nod.at, s.hauer@pengutronix.de, yuehaibing@huawei.com,
linux-kernel@vger.kernel.org, frieder.schrempf@kontron.de,
rfontana@redhat.com, linux-mtd@lists.infradead.org,
stefan@agner.ch, miquel.raynal@bootlin.com, tglx@linutronix.de,
allison@lohutok.net
Subject: Re: [PATCH v3 3/4] mtd: rawnand: Add support manufacturer specific suspend/resume operation
Date: Wed, 11 Mar 2020 09:01:01 +0100 [thread overview]
Message-ID: <20200311090101.5ac66997@collabora.com> (raw)
In-Reply-To: <OF4AD2D1A1.2B35FBFA-ON48258528.0021AD65-48258528.00223C9B@mxic.com.tw>
On Wed, 11 Mar 2020 14:13:57 +0800
masonccyang@mxic.com.tw wrote:
> Hi Boris,
>
> > > > ---
> > > > drivers/mtd/nand/raw/nand_base.c | 11 ++++++++---
> > > > include/linux/mtd/rawnand.h | 4 ++++
> > > > 2 files changed, 12 insertions(+), 3 deletions(-)
> > > >
> > > > diff --git a/drivers/mtd/nand/raw/nand_base.c
> b/drivers/mtd/nand/raw/nand_base.c
> > > > index 769be81..b44e460 100644
> > > > --- a/drivers/mtd/nand/raw/nand_base.c
> > > > +++ b/drivers/mtd/nand/raw/nand_base.c
> > > > @@ -4327,7 +4327,9 @@ static int nand_suspend(struct mtd_info *mtd)
> > > > struct nand_chip *chip = mtd_to_nand(mtd);
> > > >
> > > > mutex_lock(&chip->lock);
> > > > - chip->suspended = 1;
> > > > + if (chip->_suspend)
> > > > + if (!chip->_suspend(chip))
> > > > + chip->suspended = 1;
> >
> > Shouldn't you propagate the error to the caller if chip->_suspend()
> > fails?
>
> Currently, chip->suspend() just do sending command to nand chip and
> I think caller could check chip->suspend = 1 or 0 to know the status
> of nand chip.
No, it can't. The caller (AKA the MTD layer) has no idea about this
chip->suspend field, actually it doesn't even know about the nand_chip
struct. The mtd->_suspend() hook is here to abstract HW details, so
it's the raw NAND framework responsibility to propagate the error code
returned by chip->suspend().
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
WARNING: multiple messages have this Message-ID (diff)
From: Boris Brezillon <boris.brezillon@collabora.com>
To: masonccyang@mxic.com.tw
Cc: allison@lohutok.net, bbrezillon@kernel.org,
frieder.schrempf@kontron.de, juliensu@mxic.com.tw,
linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,
miquel.raynal@bootlin.com, rfontana@redhat.com, richard@nod.at,
s.hauer@pengutronix.de, stefan@agner.ch, tglx@linutronix.de,
vigneshr@ti.com, yuehaibing@huawei.com
Subject: Re: [PATCH v3 3/4] mtd: rawnand: Add support manufacturer specific suspend/resume operation
Date: Wed, 11 Mar 2020 09:01:01 +0100 [thread overview]
Message-ID: <20200311090101.5ac66997@collabora.com> (raw)
In-Reply-To: <OF4AD2D1A1.2B35FBFA-ON48258528.0021AD65-48258528.00223C9B@mxic.com.tw>
On Wed, 11 Mar 2020 14:13:57 +0800
masonccyang@mxic.com.tw wrote:
> Hi Boris,
>
> > > > ---
> > > > drivers/mtd/nand/raw/nand_base.c | 11 ++++++++---
> > > > include/linux/mtd/rawnand.h | 4 ++++
> > > > 2 files changed, 12 insertions(+), 3 deletions(-)
> > > >
> > > > diff --git a/drivers/mtd/nand/raw/nand_base.c
> b/drivers/mtd/nand/raw/nand_base.c
> > > > index 769be81..b44e460 100644
> > > > --- a/drivers/mtd/nand/raw/nand_base.c
> > > > +++ b/drivers/mtd/nand/raw/nand_base.c
> > > > @@ -4327,7 +4327,9 @@ static int nand_suspend(struct mtd_info *mtd)
> > > > struct nand_chip *chip = mtd_to_nand(mtd);
> > > >
> > > > mutex_lock(&chip->lock);
> > > > - chip->suspended = 1;
> > > > + if (chip->_suspend)
> > > > + if (!chip->_suspend(chip))
> > > > + chip->suspended = 1;
> >
> > Shouldn't you propagate the error to the caller if chip->_suspend()
> > fails?
>
> Currently, chip->suspend() just do sending command to nand chip and
> I think caller could check chip->suspend = 1 or 0 to know the status
> of nand chip.
No, it can't. The caller (AKA the MTD layer) has no idea about this
chip->suspend field, actually it doesn't even know about the nand_chip
struct. The mtd->_suspend() hook is here to abstract HW details, so
it's the raw NAND framework responsibility to propagate the error code
returned by chip->suspend().
next prev parent reply other threads:[~2020-03-11 8:01 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-03 7:21 [PATCH v3 0/4] mtd: rawnand: Add support Macronix Block Portection & Deep Power Down mode Mason Yang
2020-03-03 7:21 ` Mason Yang
2020-03-03 7:21 ` [PATCH v3 1/4] mtd: rawnand: Add support manufacturer specific lock/unlock operation Mason Yang
2020-03-03 7:21 ` Mason Yang
2020-03-10 18:30 ` Miquel Raynal
2020-03-10 18:30 ` Miquel Raynal
2020-03-10 19:27 ` Boris Brezillon
2020-03-10 19:27 ` Boris Brezillon
2020-03-11 2:40 ` masonccyang
2020-03-11 2:40 ` masonccyang
2020-03-11 7:25 ` Miquel Raynal
2020-03-11 7:25 ` Miquel Raynal
2020-03-03 7:21 ` [PATCH v3 2/4] mtd: rawnand: Add support Macronix Block Protection function Mason Yang
2020-03-03 7:21 ` Mason Yang
2020-03-03 7:21 ` [PATCH v3 3/4] mtd: rawnand: Add support manufacturer specific suspend/resume operation Mason Yang
2020-03-03 7:21 ` Mason Yang
2020-03-10 18:30 ` Miquel Raynal
2020-03-10 18:30 ` Miquel Raynal
2020-03-10 19:33 ` Boris Brezillon
2020-03-10 19:33 ` Boris Brezillon
2020-03-11 5:40 ` masonccyang
2020-03-11 5:40 ` masonccyang
2020-03-11 7:43 ` Miquel Raynal
2020-03-11 7:43 ` Miquel Raynal
2020-03-11 7:56 ` Boris Brezillon
2020-03-11 7:56 ` Boris Brezillon
2020-03-12 1:45 ` masonccyang
2020-03-12 1:45 ` masonccyang
2020-03-10 19:39 ` Boris Brezillon
2020-03-10 19:39 ` Boris Brezillon
2020-03-10 19:41 ` Boris Brezillon
2020-03-10 19:41 ` Boris Brezillon
2020-03-11 6:13 ` masonccyang
2020-03-11 6:13 ` masonccyang
2020-03-11 8:01 ` Boris Brezillon [this message]
2020-03-11 8:01 ` Boris Brezillon
2020-03-12 1:48 ` masonccyang
2020-03-12 1:48 ` masonccyang
2020-03-03 7:21 ` [PATCH v3 4/4] mtd: rawnand: Add support Macronix deep power down mode Mason Yang
2020-03-03 7:21 ` Mason Yang
2020-03-09 13:14 ` [PATCH v3 0/4] mtd: rawnand: Add support Macronix Block Portection & Deep Power Down mode Miquel Raynal
2020-03-09 13:14 ` Miquel Raynal
2020-03-10 2:30 ` masonccyang
2020-03-10 2:30 ` masonccyang
2020-03-10 7:44 ` Miquel Raynal
2020-03-10 7:44 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200311090101.5ac66997@collabora.com \
--to=boris.brezillon@collabora.com \
--cc=allison@lohutok.net \
--cc=bbrezillon@kernel.org \
--cc=frieder.schrempf@kontron.de \
--cc=juliensu@mxic.com.tw \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=masonccyang@mxic.com.tw \
--cc=miquel.raynal@bootlin.com \
--cc=rfontana@redhat.com \
--cc=richard@nod.at \
--cc=s.hauer@pengutronix.de \
--cc=stefan@agner.ch \
--cc=tglx@linutronix.de \
--cc=vigneshr@ti.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.