From: Lourdes Pedrajas <lu@pplo.net>
To: outreachy-kernel@googlegroups.com, gregkh@linuxfoundation.org,
vireshk@kernel.org, johan@kernel.org, elder@kernel.org
Cc: Lourdes Pedrajas <lu@pplo.net>
Subject: [PATCH] staging: greybus: i2c: remove unused pointers
Date: Thu, 12 Mar 2020 13:12:22 +0100 [thread overview]
Message-ID: <20200312121222.6609-1-lu@pplo.net> (raw)
Remove unused pointers in gb_i2c_functionality() and int gb_i2c_probe()
functions.
Signed-off-by: Lourdes Pedrajas <lu@pplo.net>
Suggested-by: Johan Hovold <johan@kernel.org>
---
drivers/staging/greybus/i2c.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/greybus/i2c.c b/drivers/staging/greybus/i2c.c
index c48fa1de89b0..de2f6516da09 100644
--- a/drivers/staging/greybus/i2c.c
+++ b/drivers/staging/greybus/i2c.c
@@ -224,7 +224,6 @@ static u32 gb_i2c_functionality(struct i2c_adapter *adap)
static const struct i2c_algorithm gb_i2c_algorithm = {
.master_xfer = gb_i2c_master_xfer,
- /* .smbus_xfer = gb_i2c_smbus_xfer, */
.functionality = gb_i2c_functionality,
};
@@ -267,7 +266,6 @@ static int gb_i2c_probe(struct gbphy_device *gbphy_dev,
adapter->owner = THIS_MODULE;
adapter->class = I2C_CLASS_HWMON | I2C_CLASS_SPD;
adapter->algo = &gb_i2c_algorithm;
- /* adapter->algo_data = what? */
adapter->dev.parent = &gbphy_dev->dev;
snprintf(adapter->name, sizeof(adapter->name), "Greybus i2c adapter");
--
2.17.1
next reply other threads:[~2020-03-12 12:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-12 12:12 Lourdes Pedrajas [this message]
2020-03-12 12:41 ` [Outreachy kernel] [PATCH] staging: greybus: i2c: remove unused pointers Julia Lawall
2020-03-12 16:21 ` Lourdes Pedrajas
2020-03-12 12:42 ` Stefano Brivio
2020-03-12 16:24 ` Lourdes Pedrajas
2020-03-12 12:47 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200312121222.6609-1-lu@pplo.net \
--to=lu@pplo.net \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=outreachy-kernel@googlegroups.com \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.