From: Lourdes Pedrajas <lu@pplo.net>
To: Julia Lawall <julia.lawall@inria.fr>
Cc: outreachy-kernel@googlegroups.com, gregkh@linuxfoundation.org,
vireshk@kernel.org, johan@kernel.org, elder@kernel.org
Subject: Re: [Outreachy kernel] [PATCH] staging: greybus: i2c: remove unused pointers
Date: Thu, 12 Mar 2020 17:21:19 +0100 [thread overview]
Message-ID: <20200312162119.GA6485@supernova> (raw)
In-Reply-To: <alpine.DEB.2.21.2003121339270.2418@hadrien>
On Thu, Mar 12, 2020 at 01:41:40PM +0100, Julia Lawall wrote:
>
>
> On Thu, 12 Mar 2020, Lourdes Pedrajas wrote:
>
> > Remove unused pointers in gb_i2c_functionality() and int gb_i2c_probe()
> > functions.
>
> There is no connection to gb_i2c_functionality. Diff doesn't provide the
> right location information when the code extract covers two top level
> entities.
>
> You can refer to gb_i2c_probe without the return type.
>
> It could be helpful to mention how long this code has been commented out.
> You can find this with git blame.
>
> julia
>
I agree, thank you, Julia.
Lourdes.
next prev parent reply other threads:[~2020-03-12 16:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-12 12:12 [PATCH] staging: greybus: i2c: remove unused pointers Lourdes Pedrajas
2020-03-12 12:41 ` [Outreachy kernel] " Julia Lawall
2020-03-12 16:21 ` Lourdes Pedrajas [this message]
2020-03-12 12:42 ` Stefano Brivio
2020-03-12 16:24 ` Lourdes Pedrajas
2020-03-12 12:47 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200312162119.GA6485@supernova \
--to=lu@pplo.net \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=julia.lawall@inria.fr \
--cc=outreachy-kernel@googlegroups.com \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.