From: Stefano Brivio <sbrivio@redhat.com>
To: Lourdes Pedrajas <lu@pplo.net>
Cc: outreachy-kernel@googlegroups.com, gregkh@linuxfoundation.org,
vireshk@kernel.org, johan@kernel.org, elder@kernel.org
Subject: Re: [Outreachy kernel] [PATCH] staging: greybus: i2c: remove unused pointers
Date: Thu, 12 Mar 2020 13:42:02 +0100 [thread overview]
Message-ID: <20200312134202.729e9b8b@elisabeth> (raw)
In-Reply-To: <20200312121222.6609-1-lu@pplo.net>
On Thu, 12 Mar 2020 13:12:22 +0100
Lourdes Pedrajas <lu@pplo.net> wrote:
> Remove unused pointers in gb_i2c_functionality() and int gb_i2c_probe()
No, wait, gb_i2c_functionality() is a function, but you're not touching
it. I guess you got confused by 'git diff'.
> functions.
>
> Signed-off-by: Lourdes Pedrajas <lu@pplo.net>
> Suggested-by: Johan Hovold <johan@kernel.org>
This might be a pet peeve of mine, I'm quite sure I've seen similar
observations by others (on netdev?) but I can't find related messages
right now: I think it's nice to reflect a temporal or causal ordering
here.
That is, Johan suggested it, and you made the change, so Suggested-by:
should come first. It helps following the logic, especially with
growing numbers of tags.
What I personally do, and this is totally subject to taste (hence not
documented or formalised), is:
1. Reported-by/Suggested-by: (if any)
2. Fixes: (if any)
3. Co-authored-by: (if any)
4. Signed-off-by:
5. Reviewed-by/Acked-by: (if I'm carrying any before they are added by
the maintainer)
--
Stefano
next prev parent reply other threads:[~2020-03-12 12:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-12 12:12 [PATCH] staging: greybus: i2c: remove unused pointers Lourdes Pedrajas
2020-03-12 12:41 ` [Outreachy kernel] " Julia Lawall
2020-03-12 16:21 ` Lourdes Pedrajas
2020-03-12 12:42 ` Stefano Brivio [this message]
2020-03-12 16:24 ` Lourdes Pedrajas
2020-03-12 12:47 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200312134202.729e9b8b@elisabeth \
--to=sbrivio@redhat.com \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=lu@pplo.net \
--cc=outreachy-kernel@googlegroups.com \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.