* [PATCH] Staging: iio: adc: eliminate spaces at the start of lineslinux-iio@vger.kernel.org
@ 2020-03-12 14:09 Enrique Vargas
2020-03-15 20:35 ` [Outreachy kernel] " Stefano Brivio
0 siblings, 1 reply; 2+ messages in thread
From: Enrique Vargas @ 2020-03-12 14:09 UTC (permalink / raw)
To: Lars-Peter Clausen, Michael Hennerich, Stefan Popa,
Jonathan Cameron, Hartmut Knaack, Peter Meerwald-Stadler,
Greg Kroah-Hartman, outreachy-kernel
Eliminate WARNING found with checkpatch.pl related to spaces
inconsistency on identation.
Signed-off-by: Enrique Vargas <jevargas@seas.upenn.edu>
---
drivers/staging/iio/adc/ad7192.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c
index bf3e2a9cc07f..51b1cd3ad1de 100644
--- a/drivers/staging/iio/adc/ad7192.c
+++ b/drivers/staging/iio/adc/ad7192.c
@@ -156,8 +156,8 @@
*/
enum {
- AD7192_SYSCALIB_ZERO_SCALE,
- AD7192_SYSCALIB_FULL_SCALE,
+ AD7192_SYSCALIB_ZERO_SCALE,
+ AD7192_SYSCALIB_FULL_SCALE,
};
struct ad7192_state {
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Outreachy kernel] [PATCH] Staging: iio: adc: eliminate spaces at the start of lineslinux-iio@vger.kernel.org
2020-03-12 14:09 [PATCH] Staging: iio: adc: eliminate spaces at the start of lineslinux-iio@vger.kernel.org Enrique Vargas
@ 2020-03-15 20:35 ` Stefano Brivio
0 siblings, 0 replies; 2+ messages in thread
From: Stefano Brivio @ 2020-03-15 20:35 UTC (permalink / raw)
To: Enrique Vargas
Cc: Lars-Peter Clausen, Michael Hennerich, Stefan Popa,
Jonathan Cameron, Hartmut Knaack, Peter Meerwald-Stadler,
Greg Kroah-Hartman, outreachy-kernel
Hi Enrique,
For some reason, an address you wanted to Cc: ended up in the subject.
A couple of comments:
- well, yes, I see you're removing spaces at the start of some lines,
but you're also replacing them by tabs, and doing it in an enum...
maybe that could be part of the commit title?
Also,
On Thu, 12 Mar 2020 08:09:11 -0600
Enrique Vargas <jevargas@seas.upenn.edu> wrote:
> Eliminate WARNING found with checkpatch.pl related to spaces
> inconsistency on identation.
^^^ indentation.
The rest looks good to me! Can you please send a new version?
--
Stefano
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-15 20:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-12 14:09 [PATCH] Staging: iio: adc: eliminate spaces at the start of lineslinux-iio@vger.kernel.org Enrique Vargas
2020-03-15 20:35 ` [Outreachy kernel] " Stefano Brivio
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.