From: Quentin Perret <qperret@google.com>
To: Lukasz Luba <lukasz.luba@arm.com>
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
dri-devel@lists.freedesktop.org, linux-omap@vger.kernel.org,
linux-mediatek@lists.infradead.org,
linux-arm-msm@vger.kernel.org, linux-imx@nxp.com,
Morten.Rasmussen@arm.com, Dietmar.Eggemann@arm.com,
javi.merino@arm.com, cw00.choi@samsung.com,
b.zolnierkie@samsung.com, rjw@rjwysocki.net,
sudeep.holla@arm.com, viresh.kumar@linaro.org, nm@ti.com,
sboyd@kernel.org, rui.zhang@intel.com,
amit.kucheria@verdurent.com, daniel.lezcano@linaro.org,
mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
vincent.guittot@linaro.org, rostedt@goodmis.org,
bsegall@google.com, mgorman@suse.de, shawnguo@kernel.org,
s.hauer@pengutronix.de, festevam@gmail.com,
kernel@pengutronix.de, khilman@kernel.org, agross@kernel.org,
bjorn.andersson@linaro.org, robh@kernel.org,
matthias.bgg@gmail.com, steven.price@arm.com,
tomeu.vizoso@collabora.com, alyssa.rosenzweig@collabora.com,
airlied@linux.ie, daniel@ffwll.ch, liviu.dudau@arm.com,
lorenzo.pieralisi@arm.com, patrick.bellasi@matbug.net,
orjan.eide@arm.com, rdunlap@infradead.org
Subject: Re: [PATCH v4 2/4] OPP: change parameter to device pointer in dev_pm_opp_of_register_em()
Date: Fri, 13 Mar 2020 10:15:24 +0000 [thread overview]
Message-ID: <20200313101524.GA150397@google.com> (raw)
In-Reply-To: <20200309134117.2331-3-lukasz.luba@arm.com>
On Monday 09 Mar 2020 at 13:41:15 (+0000), Lukasz Luba wrote:
> diff --git a/drivers/cpufreq/cpufreq-dt.c b/drivers/cpufreq/cpufreq-dt.c
> index d2b5f062a07b..676b56424886 100644
> --- a/drivers/cpufreq/cpufreq-dt.c
> +++ b/drivers/cpufreq/cpufreq-dt.c
> @@ -275,7 +275,9 @@ static int cpufreq_init(struct cpufreq_policy *policy)
> policy->cpuinfo.transition_latency = transition_latency;
> policy->dvfs_possible_from_any_cpu = true;
>
> - dev_pm_opp_of_register_em(policy->cpus);
> + ret = dev_pm_opp_of_register_em(cpu_dev, policy->cpus);
> + if (ret)
> + dev_dbg(cpu_dev, "Couldn't register Energy Model %d\n", ret);
>
> return 0;
Ah, that answers my comment on patch 01. You're adding the error
messages here.
Isn't this more boilerplate for the drivers ? All they do is print the
same debug message. Maybe just move it inside dev_pm_opp_of_register_em
directly ?
Thanks,
Quentin
WARNING: multiple messages have this Message-ID (diff)
From: Quentin Perret <qperret@google.com>
To: Lukasz Luba <lukasz.luba@arm.com>
Cc: nm@ti.com, juri.lelli@redhat.com, peterz@infradead.org,
viresh.kumar@linaro.org, liviu.dudau@arm.com,
dri-devel@lists.freedesktop.org, bjorn.andersson@linaro.org,
bsegall@google.com, alyssa.rosenzweig@collabora.com,
festevam@gmail.com, Morten.Rasmussen@arm.com, robh@kernel.org,
amit.kucheria@verdurent.com, lorenzo.pieralisi@arm.com,
vincent.guittot@linaro.org, khilman@kernel.org,
agross@kernel.org, daniel.lezcano@linaro.org,
steven.price@arm.com, cw00.choi@samsung.com, mingo@redhat.com,
linux-imx@nxp.com, rui.zhang@intel.com, mgorman@suse.de,
orjan.eide@arm.com, daniel@ffwll.ch, linux-pm@vger.kernel.org,
linux-arm-msm@vger.kernel.org, s.hauer@pengutronix.de,
rostedt@goodmis.org, linux-mediatek@lists.infradead.org,
matthias.bgg@gmail.com, linux-omap@vger.kernel.org,
Dietmar.Eggemann@arm.com, linux-arm-kernel@lists.infradead.org,
airlied@linux.ie, javi.merino@arm.com,
tomeu.vizoso@collabora.com, sboyd@kernel.org,
rdunlap@infradead.org, rjw@rjwysocki.net,
linux-kernel@vger.kernel.org, b.zolnierkie@samsung.com,
kernel@pengutronix.de, sudeep.holla@arm.com,
patrick.bellasi@matbug.net, shawnguo@kernel.org
Subject: Re: [PATCH v4 2/4] OPP: change parameter to device pointer in dev_pm_opp_of_register_em()
Date: Fri, 13 Mar 2020 10:15:24 +0000 [thread overview]
Message-ID: <20200313101524.GA150397@google.com> (raw)
In-Reply-To: <20200309134117.2331-3-lukasz.luba@arm.com>
On Monday 09 Mar 2020 at 13:41:15 (+0000), Lukasz Luba wrote:
> diff --git a/drivers/cpufreq/cpufreq-dt.c b/drivers/cpufreq/cpufreq-dt.c
> index d2b5f062a07b..676b56424886 100644
> --- a/drivers/cpufreq/cpufreq-dt.c
> +++ b/drivers/cpufreq/cpufreq-dt.c
> @@ -275,7 +275,9 @@ static int cpufreq_init(struct cpufreq_policy *policy)
> policy->cpuinfo.transition_latency = transition_latency;
> policy->dvfs_possible_from_any_cpu = true;
>
> - dev_pm_opp_of_register_em(policy->cpus);
> + ret = dev_pm_opp_of_register_em(cpu_dev, policy->cpus);
> + if (ret)
> + dev_dbg(cpu_dev, "Couldn't register Energy Model %d\n", ret);
>
> return 0;
Ah, that answers my comment on patch 01. You're adding the error
messages here.
Isn't this more boilerplate for the drivers ? All they do is print the
same debug message. Maybe just move it inside dev_pm_opp_of_register_em
directly ?
Thanks,
Quentin
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Quentin Perret <qperret@google.com>
To: Lukasz Luba <lukasz.luba@arm.com>
Cc: nm@ti.com, juri.lelli@redhat.com, peterz@infradead.org,
viresh.kumar@linaro.org, liviu.dudau@arm.com,
dri-devel@lists.freedesktop.org, bjorn.andersson@linaro.org,
bsegall@google.com, alyssa.rosenzweig@collabora.com,
festevam@gmail.com, Morten.Rasmussen@arm.com, robh@kernel.org,
amit.kucheria@verdurent.com, lorenzo.pieralisi@arm.com,
khilman@kernel.org, agross@kernel.org, daniel.lezcano@linaro.org,
steven.price@arm.com, cw00.choi@samsung.com, mingo@redhat.com,
linux-imx@nxp.com, rui.zhang@intel.com, mgorman@suse.de,
orjan.eide@arm.com, daniel@ffwll.ch, linux-pm@vger.kernel.org,
linux-arm-msm@vger.kernel.org, s.hauer@pengutronix.de,
rostedt@goodmis.org, linux-mediatek@lists.infradead.org,
matthias.bgg@gmail.com, linux-omap@vger.kernel.org,
Dietmar.Eggemann@arm.com, linux-arm-kernel@lists.infradead.org,
airlied@linux.ie, javi.merino@arm.com,
tomeu.vizoso@collabora.com, sboyd@kernel.org,
rdunlap@infradead.org, rjw@rjwysocki.net,
linux-kernel@vger.kernel.org, b.zolnierkie@samsung.com,
kernel@pengutronix.de, sudeep.holla@arm.com,
patrick.bellasi@matbug.net, shawnguo@kernel.org
Subject: Re: [PATCH v4 2/4] OPP: change parameter to device pointer in dev_pm_opp_of_register_em()
Date: Fri, 13 Mar 2020 10:15:24 +0000 [thread overview]
Message-ID: <20200313101524.GA150397@google.com> (raw)
In-Reply-To: <20200309134117.2331-3-lukasz.luba@arm.com>
On Monday 09 Mar 2020 at 13:41:15 (+0000), Lukasz Luba wrote:
> diff --git a/drivers/cpufreq/cpufreq-dt.c b/drivers/cpufreq/cpufreq-dt.c
> index d2b5f062a07b..676b56424886 100644
> --- a/drivers/cpufreq/cpufreq-dt.c
> +++ b/drivers/cpufreq/cpufreq-dt.c
> @@ -275,7 +275,9 @@ static int cpufreq_init(struct cpufreq_policy *policy)
> policy->cpuinfo.transition_latency = transition_latency;
> policy->dvfs_possible_from_any_cpu = true;
>
> - dev_pm_opp_of_register_em(policy->cpus);
> + ret = dev_pm_opp_of_register_em(cpu_dev, policy->cpus);
> + if (ret)
> + dev_dbg(cpu_dev, "Couldn't register Energy Model %d\n", ret);
>
> return 0;
Ah, that answers my comment on patch 01. You're adding the error
messages here.
Isn't this more boilerplate for the drivers ? All they do is print the
same debug message. Maybe just move it inside dev_pm_opp_of_register_em
directly ?
Thanks,
Quentin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Quentin Perret <qperret@google.com>
To: Lukasz Luba <lukasz.luba@arm.com>
Cc: nm@ti.com, juri.lelli@redhat.com, peterz@infradead.org,
viresh.kumar@linaro.org, liviu.dudau@arm.com,
dri-devel@lists.freedesktop.org, bjorn.andersson@linaro.org,
bsegall@google.com, alyssa.rosenzweig@collabora.com,
Morten.Rasmussen@arm.com, amit.kucheria@verdurent.com,
lorenzo.pieralisi@arm.com, vincent.guittot@linaro.org,
khilman@kernel.org, agross@kernel.org, daniel.lezcano@linaro.org,
steven.price@arm.com, cw00.choi@samsung.com, mingo@redhat.com,
linux-imx@nxp.com, rui.zhang@intel.com, mgorman@suse.de,
orjan.eide@arm.com, linux-pm@vger.kernel.org,
linux-arm-msm@vger.kernel.org, s.hauer@pengutronix.de,
rostedt@goodmis.org, linux-mediatek@lists.infradead.org,
matthias.bgg@gmail.com, linux-omap@vger.kernel.org,
Dietmar.Eggemann@arm.com, linux-arm-kernel@lists.infradead.org,
airlied@linux.ie, javi.merino@arm.com,
tomeu.vizoso@collabora.com, sboyd@kernel.org,
rdunlap@infradead.org, rjw@rjwysocki.net,
linux-kernel@vger.kernel.org, b.zolnierkie@samsung.com,
kernel@pengutronix.de, sudeep.holla@arm.com,
patrick.bellasi@matbug.net, shawnguo@kernel.org
Subject: Re: [PATCH v4 2/4] OPP: change parameter to device pointer in dev_pm_opp_of_register_em()
Date: Fri, 13 Mar 2020 10:15:24 +0000 [thread overview]
Message-ID: <20200313101524.GA150397@google.com> (raw)
In-Reply-To: <20200309134117.2331-3-lukasz.luba@arm.com>
On Monday 09 Mar 2020 at 13:41:15 (+0000), Lukasz Luba wrote:
> diff --git a/drivers/cpufreq/cpufreq-dt.c b/drivers/cpufreq/cpufreq-dt.c
> index d2b5f062a07b..676b56424886 100644
> --- a/drivers/cpufreq/cpufreq-dt.c
> +++ b/drivers/cpufreq/cpufreq-dt.c
> @@ -275,7 +275,9 @@ static int cpufreq_init(struct cpufreq_policy *policy)
> policy->cpuinfo.transition_latency = transition_latency;
> policy->dvfs_possible_from_any_cpu = true;
>
> - dev_pm_opp_of_register_em(policy->cpus);
> + ret = dev_pm_opp_of_register_em(cpu_dev, policy->cpus);
> + if (ret)
> + dev_dbg(cpu_dev, "Couldn't register Energy Model %d\n", ret);
>
> return 0;
Ah, that answers my comment on patch 01. You're adding the error
messages here.
Isn't this more boilerplate for the drivers ? All they do is print the
same debug message. Maybe just move it inside dev_pm_opp_of_register_em
directly ?
Thanks,
Quentin
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-03-13 10:15 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-09 13:41 [PATCH v4 0/4] Add support for devices in the Energy Model Lukasz Luba
2020-03-09 13:41 ` Lukasz Luba
2020-03-09 13:41 ` Lukasz Luba
2020-03-09 13:41 ` Lukasz Luba
2020-03-09 13:41 ` [PATCH v4 1/4] PM / EM: add devices to " Lukasz Luba
2020-03-09 13:41 ` Lukasz Luba
2020-03-09 13:41 ` Lukasz Luba
2020-03-09 13:41 ` Lukasz Luba
2020-03-13 10:04 ` Quentin Perret
2020-03-13 10:04 ` Quentin Perret
2020-03-13 10:04 ` Quentin Perret
2020-03-13 10:04 ` Quentin Perret
2020-03-13 10:05 ` Quentin Perret
2020-03-13 10:05 ` Quentin Perret
2020-03-13 10:05 ` Quentin Perret
2020-03-13 10:05 ` Quentin Perret
2020-03-13 16:49 ` Lukasz Luba
2020-03-13 16:49 ` Lukasz Luba
2020-03-13 16:49 ` Lukasz Luba
2020-03-13 16:49 ` Lukasz Luba
2020-03-13 17:15 ` Quentin Perret
2020-03-13 17:15 ` Quentin Perret
2020-03-13 17:15 ` Quentin Perret
2020-03-13 17:15 ` Quentin Perret
2020-03-09 13:41 ` [PATCH v4 2/4] OPP: change parameter to device pointer in dev_pm_opp_of_register_em() Lukasz Luba
2020-03-09 13:41 ` Lukasz Luba
2020-03-09 13:41 ` Lukasz Luba
2020-03-09 13:41 ` Lukasz Luba
2020-03-13 10:15 ` Quentin Perret [this message]
2020-03-13 10:15 ` Quentin Perret
2020-03-13 10:15 ` Quentin Perret
2020-03-13 10:15 ` Quentin Perret
2020-03-13 17:11 ` Lukasz Luba
2020-03-13 17:11 ` Lukasz Luba
2020-03-13 17:11 ` Lukasz Luba
2020-03-13 17:11 ` Lukasz Luba
2020-03-13 17:16 ` Quentin Perret
2020-03-13 17:16 ` Quentin Perret
2020-03-13 17:16 ` Quentin Perret
2020-03-13 17:16 ` Quentin Perret
2020-03-09 13:41 ` [PATCH v4 3/4] thermal: devfreq_cooling: Refactor code and switch to use Energy Model Lukasz Luba
2020-03-09 13:41 ` Lukasz Luba
2020-03-09 13:41 ` Lukasz Luba
2020-03-09 13:41 ` Lukasz Luba
2020-03-09 13:41 ` [PATCH v4 4/4] drm/panfrost: Register devfreq cooling and attempt to add " Lukasz Luba
2020-03-09 13:41 ` Lukasz Luba
2020-03-09 13:41 ` Lukasz Luba
2020-03-09 13:41 ` Lukasz Luba
2020-03-09 14:15 ` Steven Price
2020-03-09 14:15 ` Steven Price
2020-03-09 14:15 ` Steven Price
2020-03-13 16:51 ` Lukasz Luba
2020-03-13 16:51 ` Lukasz Luba
2020-03-13 16:51 ` Lukasz Luba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200313101524.GA150397@google.com \
--to=qperret@google.com \
--cc=Dietmar.Eggemann@arm.com \
--cc=Morten.Rasmussen@arm.com \
--cc=agross@kernel.org \
--cc=airlied@linux.ie \
--cc=alyssa.rosenzweig@collabora.com \
--cc=amit.kucheria@verdurent.com \
--cc=b.zolnierkie@samsung.com \
--cc=bjorn.andersson@linaro.org \
--cc=bsegall@google.com \
--cc=cw00.choi@samsung.com \
--cc=daniel.lezcano@linaro.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=festevam@gmail.com \
--cc=javi.merino@arm.com \
--cc=juri.lelli@redhat.com \
--cc=kernel@pengutronix.de \
--cc=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=liviu.dudau@arm.com \
--cc=lorenzo.pieralisi@arm.com \
--cc=lukasz.luba@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=nm@ti.com \
--cc=orjan.eide@arm.com \
--cc=patrick.bellasi@matbug.net \
--cc=peterz@infradead.org \
--cc=rdunlap@infradead.org \
--cc=rjw@rjwysocki.net \
--cc=robh@kernel.org \
--cc=rostedt@goodmis.org \
--cc=rui.zhang@intel.com \
--cc=s.hauer@pengutronix.de \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
--cc=steven.price@arm.com \
--cc=sudeep.holla@arm.com \
--cc=tomeu.vizoso@collabora.com \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.