From: Sam Ravnborg <sam@ravnborg.org>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: dri-devel@lists.freedesktop.org, marmarek@invisiblethingslab.com,
David Airlie <airlied@linux.ie>,
open list <linux-kernel@vger.kernel.org>,
"open list:DRM DRIVER FOR BOCHS VIRTUAL GPU"
<virtualization@lists.linux-foundation.org>
Subject: Re: [PATCH v3] drm/bochs: downgrade pci_request_region failure from error to warning
Date: Fri, 13 Mar 2020 19:16:02 +0100 [thread overview]
Message-ID: <20200313181602.GA16474@ravnborg.org> (raw)
In-Reply-To: <20200313143530.6aoagldak3kpe3xv@sirius.home.kraxel.org>
On Fri, Mar 13, 2020 at 03:35:30PM +0100, Gerd Hoffmann wrote:
> Hi,
>
> > > + if (pci_request_region(pdev, 0, "bochs-drm") != 0)
> > > + DRM_WARN("Cannot request framebuffer, boot fb still active?\n");
> > So you could use drm_WARN() which is what is preferred these days.
>
> Nope, this isn't yet in -fixes.
Ups, did not see this was for -fixes.
My ack stands without ths change then.
Sam
WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: David Airlie <airlied@linux.ie>,
"open list:DRM DRIVER FOR BOCHS VIRTUAL GPU"
<virtualization@lists.linux-foundation.org>,
marmarek@invisiblethingslab.com, dri-devel@lists.freedesktop.org,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] drm/bochs: downgrade pci_request_region failure from error to warning
Date: Fri, 13 Mar 2020 19:16:02 +0100 [thread overview]
Message-ID: <20200313181602.GA16474@ravnborg.org> (raw)
In-Reply-To: <20200313143530.6aoagldak3kpe3xv@sirius.home.kraxel.org>
On Fri, Mar 13, 2020 at 03:35:30PM +0100, Gerd Hoffmann wrote:
> Hi,
>
> > > + if (pci_request_region(pdev, 0, "bochs-drm") != 0)
> > > + DRM_WARN("Cannot request framebuffer, boot fb still active?\n");
> > So you could use drm_WARN() which is what is preferred these days.
>
> Nope, this isn't yet in -fixes.
Ups, did not see this was for -fixes.
My ack stands without ths change then.
Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-03-13 18:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-13 8:41 [PATCH v3] drm/bochs: downgrade pci_request_region failure from error to warning Gerd Hoffmann
2020-03-13 8:41 ` Gerd Hoffmann
2020-03-13 8:41 ` Gerd Hoffmann
2020-03-13 9:03 ` Sam Ravnborg
2020-03-13 9:03 ` Sam Ravnborg
2020-03-13 14:35 ` Gerd Hoffmann
2020-03-13 14:35 ` Gerd Hoffmann
2020-03-13 18:16 ` Sam Ravnborg [this message]
2020-03-13 18:16 ` Sam Ravnborg
2020-03-17 16:49 ` Daniel Vetter
2020-03-17 16:49 ` Daniel Vetter
2020-03-18 6:42 ` Gerd Hoffmann
2020-03-18 6:42 ` Gerd Hoffmann
2020-03-19 8:39 ` Daniel Vetter
2020-03-19 8:39 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200313181602.GA16474@ravnborg.org \
--to=sam@ravnborg.org \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=kraxel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marmarek@invisiblethingslab.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.