* [PATCH] staging: rts5208: Fix long line in C func call argument @ 2020-03-14 6:05 R Veera Kumar 2020-03-14 11:51 ` [Outreachy kernel] " Julia Lawall 0 siblings, 1 reply; 4+ messages in thread From: R Veera Kumar @ 2020-03-14 6:05 UTC (permalink / raw) To: Greg Kroah-Hartman; +Cc: outreachy-kernel A simple fix of long line in C function call argument. Found using checkpatch.pl. Signed-off-by: R Veera Kumar <vkor@vkten.in> --- drivers/staging/rts5208/rtsx_chip.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rts5208/rtsx_chip.c b/drivers/staging/rts5208/rtsx_chip.c index 17c4131f5f62..c6f9375468eb 100644 --- a/drivers/staging/rts5208/rtsx_chip.c +++ b/drivers/staging/rts5208/rtsx_chip.c @@ -940,7 +940,8 @@ static void rtsx_monitor_aspm_config(struct rtsx_chip *chip) if (maybe_support_aspm) chip->aspm_l0s_l1_en = 0x03; - dev_dbg(rtsx_dev(chip), "aspm_level[0] = 0x%02x, aspm_level[1] = 0x%02x\n", + dev_dbg(rtsx_dev(chip), + "aspm_level[0] = 0x%02x, aspm_level[1] = 0x%02x\n", chip->aspm_level[0], chip->aspm_level[1]); if (chip->aspm_l0s_l1_en) { -- 2.20.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: rts5208: Fix long line in C func call argument 2020-03-14 6:05 [PATCH] staging: rts5208: Fix long line in C func call argument R Veera Kumar @ 2020-03-14 11:51 ` Julia Lawall 2020-03-14 13:33 ` R Veera Kumar 0 siblings, 1 reply; 4+ messages in thread From: Julia Lawall @ 2020-03-14 11:51 UTC (permalink / raw) To: R Veera Kumar; +Cc: Greg Kroah-Hartman, outreachy-kernel On Sat, 14 Mar 2020, R Veera Kumar wrote: > A simple fix of long line in C function call argument. Try to rewrite the whole thing without using the word "fix". What did you do and why? Simple is not a good word to use, because it is your opinion. It is probably everyone's opinion in this case, but it is still an opinion. julia > Found using checkpatch.pl. > > Signed-off-by: R Veera Kumar <vkor@vkten.in> > --- > drivers/staging/rts5208/rtsx_chip.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/rts5208/rtsx_chip.c b/drivers/staging/rts5208/rtsx_chip.c > index 17c4131f5f62..c6f9375468eb 100644 > --- a/drivers/staging/rts5208/rtsx_chip.c > +++ b/drivers/staging/rts5208/rtsx_chip.c > @@ -940,7 +940,8 @@ static void rtsx_monitor_aspm_config(struct rtsx_chip *chip) > if (maybe_support_aspm) > chip->aspm_l0s_l1_en = 0x03; > > - dev_dbg(rtsx_dev(chip), "aspm_level[0] = 0x%02x, aspm_level[1] = 0x%02x\n", > + dev_dbg(rtsx_dev(chip), > + "aspm_level[0] = 0x%02x, aspm_level[1] = 0x%02x\n", > chip->aspm_level[0], chip->aspm_level[1]); > > if (chip->aspm_l0s_l1_en) { > -- > 2.20.1 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200314060539.GA2709%40tulip.local. > ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: rts5208: Fix long line in C func call argument 2020-03-14 11:51 ` [Outreachy kernel] " Julia Lawall @ 2020-03-14 13:33 ` R Veera Kumar 2020-03-14 13:47 ` Julia Lawall 0 siblings, 1 reply; 4+ messages in thread From: R Veera Kumar @ 2020-03-14 13:33 UTC (permalink / raw) To: Julia Lawall; +Cc: Greg Kroah-Hartman, outreachy-kernel On Sat, Mar 14, 2020 at 12:51:16PM +0100, Julia Lawall wrote: > > > On Sat, 14 Mar 2020, R Veera Kumar wrote: > > > A simple fix of long line in C function call argument. > > Try to rewrite the whole thing without using the word "fix". What did you > do and why? > > Simple is not a good word to use, because it is your opinion. It is > probably everyone's opinion in this case, but it is still an opinion. > > julia > Is subject line ok? I mean the word 'fix' in it. Is this ok for body: A correction of long line function call with arguments exceeding the 80 columns limit of coding style. > > > Found using checkpatch.pl. > > > > Signed-off-by: R Veera Kumar <vkor@vkten.in> > > --- > > drivers/staging/rts5208/rtsx_chip.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/staging/rts5208/rtsx_chip.c b/drivers/staging/rts5208/rtsx_chip.c > > index 17c4131f5f62..c6f9375468eb 100644 > > --- a/drivers/staging/rts5208/rtsx_chip.c > > +++ b/drivers/staging/rts5208/rtsx_chip.c > > @@ -940,7 +940,8 @@ static void rtsx_monitor_aspm_config(struct rtsx_chip *chip) > > if (maybe_support_aspm) > > chip->aspm_l0s_l1_en = 0x03; > > > > - dev_dbg(rtsx_dev(chip), "aspm_level[0] = 0x%02x, aspm_level[1] = 0x%02x\n", > > + dev_dbg(rtsx_dev(chip), > > + "aspm_level[0] = 0x%02x, aspm_level[1] = 0x%02x\n", > > chip->aspm_level[0], chip->aspm_level[1]); > > > > if (chip->aspm_l0s_l1_en) { > > -- > > 2.20.1 > > ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: rts5208: Fix long line in C func call argument 2020-03-14 13:33 ` R Veera Kumar @ 2020-03-14 13:47 ` Julia Lawall 0 siblings, 0 replies; 4+ messages in thread From: Julia Lawall @ 2020-03-14 13:47 UTC (permalink / raw) To: R Veera Kumar; +Cc: Greg Kroah-Hartman, outreachy-kernel On Sat, 14 Mar 2020, R Veera Kumar wrote: > On Sat, Mar 14, 2020 at 12:51:16PM +0100, Julia Lawall wrote: > > > > > > On Sat, 14 Mar 2020, R Veera Kumar wrote: > > > > > A simple fix of long line in C function call argument. > > > > Try to rewrite the whole thing without using the word "fix". What did you > > do and why? > > > > Simple is not a good word to use, because it is your opinion. It is > > probably everyone's opinion in this case, but it is still an opinion. > > > > julia > > > > Is subject line ok? I mean the word 'fix' in it. > > Is this ok for body: > > A correction of long line function call with arguments exceeding the > 80 columns limit of coding style. No. What you did: add a newline after the first argument Why did you do it: respect the 80 character line limit I guess one could live with Fix in the subject line, but the current subject line is too verbose. All of the code in the kernel is C code, for example, so there is not much point to mention that. Something like "shorten long line" would be fine. julia > > > > > > Found using checkpatch.pl. > > > > > > Signed-off-by: R Veera Kumar <vkor@vkten.in> > > > --- > > > drivers/staging/rts5208/rtsx_chip.c | 3 ++- > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/staging/rts5208/rtsx_chip.c b/drivers/staging/rts5208/rtsx_chip.c > > > index 17c4131f5f62..c6f9375468eb 100644 > > > --- a/drivers/staging/rts5208/rtsx_chip.c > > > +++ b/drivers/staging/rts5208/rtsx_chip.c > > > @@ -940,7 +940,8 @@ static void rtsx_monitor_aspm_config(struct rtsx_chip *chip) > > > if (maybe_support_aspm) > > > chip->aspm_l0s_l1_en = 0x03; > > > > > > - dev_dbg(rtsx_dev(chip), "aspm_level[0] = 0x%02x, aspm_level[1] = 0x%02x\n", > > > + dev_dbg(rtsx_dev(chip), > > > + "aspm_level[0] = 0x%02x, aspm_level[1] = 0x%02x\n", > > > chip->aspm_level[0], chip->aspm_level[1]); > > > > > > if (chip->aspm_l0s_l1_en) { > > > -- > > > 2.20.1 > > > > ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-03-14 13:47 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2020-03-14 6:05 [PATCH] staging: rts5208: Fix long line in C func call argument R Veera Kumar 2020-03-14 11:51 ` [Outreachy kernel] " Julia Lawall 2020-03-14 13:33 ` R Veera Kumar 2020-03-14 13:47 ` Julia Lawall
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.