Re: [PATCH v2 1/2] staging: greybus: gpio: improve bit fields formatting.

[Johan Hovold <johan@kernel.org>]

On Sat, Mar 14, 2020 at 09:40:20PM +0100, Lourdes Pedrajas wrote:
> Fix the formatting of bit fields on structure gb_gpio_line, in order to
> not confuse them with indented labels.
> Issue found with checkpatch.

This is not an in issue found by checkpatch. Rather, you've found an
issue *with* checkpatch, which gets confused by these bit fields.

I'd just leave this as is, since there's nothing wrong with the code.

> Signed-off-by: Lourdes Pedrajas <lu@pplo.net>
> ---
> v2: log message correction
> 
>  drivers/staging/greybus/gpio.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/greybus/gpio.c b/drivers/staging/greybus/gpio.c
> index 36d99f9e419e..50e93a393dba 100644
> --- a/drivers/staging/greybus/gpio.c
> +++ b/drivers/staging/greybus/gpio.c
> @@ -20,9 +20,9 @@
>  struct gb_gpio_line {
>  	/* The following has to be an array of line_max entries */
>  	/* --> make them just a flags field */
> -	u8			active:    1,
> +	u8			active: 1,
>  				direction: 1,	/* 0 = output, 1 = input */
> -				value:     1;	/* 0 = low, 1 = high */
> +				value: 1;	/* 0 = low, 1 = high */
>  	u16			debounce_usec;
>  
>  	u8			irq_type;

Johan