From: Lourdes Pedrajas <lu@pplo.net>
To: Johan Hovold <johan@kernel.org>
Cc: outreachy-kernel@googlegroups.com, rmfrfs@gmail.com,
elder@kernel.org, gregkh@linuxfoundation.org, vireshk@kernel.org
Subject: Re: [PATCH v2 1/2] staging: greybus: gpio: improve bit fields formatting.
Date: Mon, 16 Mar 2020 21:01:23 +0100 [thread overview]
Message-ID: <20200316200123.GB8362@supernova> (raw)
In-Reply-To: <20200316095511.GV14211@localhost>
On Mon, Mar 16, 2020 at 10:55:11AM +0100, Johan Hovold wrote:
> On Sat, Mar 14, 2020 at 09:40:20PM +0100, Lourdes Pedrajas wrote:
> > Fix the formatting of bit fields on structure gb_gpio_line, in order to
> > not confuse them with indented labels.
> > Issue found with checkpatch.
>
> This is not an in issue found by checkpatch. Rather, you've found an
> issue *with* checkpatch, which gets confused by these bit fields.
>
> I'd just leave this as is, since there's nothing wrong with the code.
>
> Johan
Agreed, thank you!
Lourdes
next prev parent reply other threads:[~2020-03-16 20:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-13 20:49 [PATCH 0/2] staging: greybus: simple formatting cleanup Lourdes Pedrajas
2020-03-13 20:49 ` [PATCH 1/2] staging: greybus: gpio: improve bit fields formatting Lourdes Pedrajas
2020-03-13 21:03 ` [Outreachy kernel] " Julia Lawall
2020-03-14 20:42 ` Lourdes Pedrajas
2020-03-16 9:55 ` [PATCH v2 " Johan Hovold
2020-03-16 20:01 ` Lourdes Pedrajas [this message]
2020-03-13 20:49 ` [PATCH 2/2] staging: greybus: hid: remove unneded braces Lourdes Pedrajas
2020-03-17 11:47 ` Greg KH
2020-03-17 17:07 ` Lourdes Pedrajas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200316200123.GB8362@supernova \
--to=lu@pplo.net \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=outreachy-kernel@googlegroups.com \
--cc=rmfrfs@gmail.com \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.