From: Greg KH <gregkh@linuxfoundation.org>
To: Lourdes Pedrajas <lu@pplo.net>
Cc: outreachy-kernel@googlegroups.com, rmfrfs@gmail.com,
johan@kernel.org, elder@kernel.org, vireshk@kernel.org
Subject: Re: [PATCH 2/2] staging: greybus: hid: remove unneded braces
Date: Tue, 17 Mar 2020 12:47:15 +0100 [thread overview]
Message-ID: <20200317114715.GA1233900@kroah.com> (raw)
In-Reply-To: <3626ab8e2feb4e1a43476c9f1c721d314c345cfc.1584131593.git.lu@pplo.net>
On Fri, Mar 13, 2020 at 09:49:37PM +0100, Lourdes Pedrajas wrote:
> Braces are not necessary for single statement blocks.
> Issue found with checkpatch.
>
> Signed-off-by: Lourdes Pedrajas <lu@pplo.net>
> ---
> drivers/staging/greybus/hid.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/greybus/hid.c b/drivers/staging/greybus/hid.c
> index 04bfd9110502..9d4ca66e1c8d 100644
> --- a/drivers/staging/greybus/hid.c
> +++ b/drivers/staging/greybus/hid.c
> @@ -290,9 +290,8 @@ static int gb_hid_parse(struct hid_device *hid)
> }
>
> rdesc = kzalloc(rsize, GFP_KERNEL);
> - if (!rdesc) {
> + if (!rdesc)
> return -ENOMEM;
> - }
>
> ret = gb_hid_get_report_desc(ghid, rdesc);
> if (ret) {
This patch _ADDS_ checkpatch warnings :(
Please always verify that your patch does what you think it does
before you send it out...
thanks,
greg k-h
next prev parent reply other threads:[~2020-03-17 11:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-13 20:49 [PATCH 0/2] staging: greybus: simple formatting cleanup Lourdes Pedrajas
2020-03-13 20:49 ` [PATCH 1/2] staging: greybus: gpio: improve bit fields formatting Lourdes Pedrajas
2020-03-13 21:03 ` [Outreachy kernel] " Julia Lawall
2020-03-14 20:42 ` Lourdes Pedrajas
2020-03-16 9:55 ` [PATCH v2 " Johan Hovold
2020-03-16 20:01 ` Lourdes Pedrajas
2020-03-13 20:49 ` [PATCH 2/2] staging: greybus: hid: remove unneded braces Lourdes Pedrajas
2020-03-17 11:47 ` Greg KH [this message]
2020-03-17 17:07 ` Lourdes Pedrajas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200317114715.GA1233900@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=elder@kernel.org \
--cc=johan@kernel.org \
--cc=lu@pplo.net \
--cc=outreachy-kernel@googlegroups.com \
--cc=rmfrfs@gmail.com \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.