From: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Oleksandr Suvorov
<oleksandr.suvorov-2KBjVHiyJgBBDgjK7y7TUQ@public.gmane.org>
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-pwm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"Paul Barker" <pbarker-OWPKS81ov/FWk0Htik3J/w@public.gmane.org>,
"Uwe Kleine-König"
<u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
"Laurent Pinchart"
<laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>,
"Marcel Ziswiler"
<marcel.ziswiler-2KBjVHiyJgBBDgjK7y7TUQ@public.gmane.org>,
"Igor Opaniuk"
<igor.opaniuk-2KBjVHiyJgBBDgjK7y7TUQ@public.gmane.org>,
"Philippe Schenker"
<philippe.schenker-2KBjVHiyJgBBDgjK7y7TUQ@public.gmane.org>,
"Rob Herring" <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [RFC PATCH 2/7] dt-bindings: pwm: document the PWM polarity flag
Date: Tue, 17 Mar 2020 18:43:44 +0100 [thread overview]
Message-ID: <20200317174344.GB1464607@ulmo> (raw)
In-Reply-To: <20200317123231.2843297-3-oleksandr.suvorov-2KBjVHiyJgBBDgjK7y7TUQ@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1228 bytes --]
On Tue, Mar 17, 2020 at 02:32:26PM +0200, Oleksandr Suvorov wrote:
> Add the description of PWM_POLARITY_NORMAL flag.
>
> Signed-off-by: Oleksandr Suvorov <oleksandr.suvorov-2KBjVHiyJgBBDgjK7y7TUQ@public.gmane.org>
> ---
>
> Documentation/devicetree/bindings/pwm/pwm.txt | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/pwm/pwm.txt b/Documentation/devicetree/bindings/pwm/pwm.txt
> index 084886bd721e..440c6b9a6a4e 100644
> --- a/Documentation/devicetree/bindings/pwm/pwm.txt
> +++ b/Documentation/devicetree/bindings/pwm/pwm.txt
> @@ -46,6 +46,7 @@ period in nanoseconds.
> Optionally, the pwm-specifier can encode a number of flags (defined in
> <dt-bindings/pwm/pwm.h>) in a third cell:
> - PWM_POLARITY_INVERTED: invert the PWM signal polarity
> +- PWM_POLARITY_NORMAL: don't invert the PWM signal polarity
This doesn't make sense. PWM_POLARITY_NORMAL is not part of the DT ABI.
The third cell of the specifier is a bitmask of flags.
PWM_POLARITY_NORMAL is an enumeration value that evaluates to 0, so it
makes absolutely no sense as a flag. PWM signals are considered to be
"normal" by default, so no flag is necessary to specify that.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding@gmail.com>
To: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>
Cc: devicetree@vger.kernel.org, linux-pwm@vger.kernel.org,
"Paul Barker" <pbarker@konsulko.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
"Marcel Ziswiler" <marcel.ziswiler@toradex.com>,
"Igor Opaniuk" <igor.opaniuk@toradex.com>,
"Philippe Schenker" <philippe.schenker@toradex.com>,
"Rob Herring" <robh+dt@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 2/7] dt-bindings: pwm: document the PWM polarity flag
Date: Tue, 17 Mar 2020 18:43:44 +0100 [thread overview]
Message-ID: <20200317174344.GB1464607@ulmo> (raw)
In-Reply-To: <20200317123231.2843297-3-oleksandr.suvorov@toradex.com>
[-- Attachment #1: Type: text/plain, Size: 1200 bytes --]
On Tue, Mar 17, 2020 at 02:32:26PM +0200, Oleksandr Suvorov wrote:
> Add the description of PWM_POLARITY_NORMAL flag.
>
> Signed-off-by: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>
> ---
>
> Documentation/devicetree/bindings/pwm/pwm.txt | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/pwm/pwm.txt b/Documentation/devicetree/bindings/pwm/pwm.txt
> index 084886bd721e..440c6b9a6a4e 100644
> --- a/Documentation/devicetree/bindings/pwm/pwm.txt
> +++ b/Documentation/devicetree/bindings/pwm/pwm.txt
> @@ -46,6 +46,7 @@ period in nanoseconds.
> Optionally, the pwm-specifier can encode a number of flags (defined in
> <dt-bindings/pwm/pwm.h>) in a third cell:
> - PWM_POLARITY_INVERTED: invert the PWM signal polarity
> +- PWM_POLARITY_NORMAL: don't invert the PWM signal polarity
This doesn't make sense. PWM_POLARITY_NORMAL is not part of the DT ABI.
The third cell of the specifier is a bitmask of flags.
PWM_POLARITY_NORMAL is an enumeration value that evaluates to 0, so it
makes absolutely no sense as a flag. PWM signals are considered to be
"normal" by default, so no flag is necessary to specify that.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-03-17 17:43 UTC|newest]
Thread overview: 134+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-17 12:32 [RFC PATCH 0/7] Rework PWM_POLARITY_* flags Oleksandr Suvorov
2020-03-17 12:32 ` Oleksandr Suvorov
2020-03-17 12:32 ` Oleksandr Suvorov
2020-03-17 12:32 ` Oleksandr Suvorov
2020-03-17 12:32 ` [RFC PATCH 1/7] pwm: rename the PWM_POLARITY_INVERSED enum Oleksandr Suvorov
2020-03-17 12:32 ` Oleksandr Suvorov
2020-03-17 12:32 ` Oleksandr Suvorov
2020-03-17 12:32 ` Oleksandr Suvorov
2020-03-17 12:32 ` Oleksandr Suvorov
2020-03-17 13:34 ` Paul Barker
2020-03-17 13:34 ` Paul Barker
2020-03-17 13:34 ` Paul Barker
2020-03-17 13:34 ` Paul Barker
2020-03-17 13:34 ` Paul Barker
2020-03-17 21:32 ` Uwe Kleine-König
2020-03-17 21:32 ` Uwe Kleine-König
2020-03-17 21:32 ` Uwe Kleine-König
2020-03-17 21:32 ` Uwe Kleine-König
2020-03-17 21:32 ` Uwe Kleine-König
2020-03-17 16:26 ` Claudiu.Beznea
2020-03-17 16:26 ` Claudiu.Beznea
2020-03-17 16:26 ` Claudiu.Beznea
2020-03-17 16:26 ` Claudiu.Beznea
2020-03-17 16:26 ` Claudiu.Beznea-UWL1GkI3JZL3oGB3hsPCZA
2020-03-17 16:39 ` Oleksandr Suvorov
2020-03-17 16:39 ` Oleksandr Suvorov
2020-03-17 16:39 ` Oleksandr Suvorov
2020-03-17 16:39 ` Oleksandr Suvorov
2020-03-17 16:39 ` Oleksandr Suvorov
2020-03-17 17:40 ` Thierry Reding
2020-03-17 17:40 ` Thierry Reding
2020-03-17 17:40 ` Thierry Reding
2020-03-17 17:40 ` Thierry Reding
2020-03-17 17:40 ` Thierry Reding
2020-03-17 21:00 ` Uwe Kleine-König
2020-03-17 21:00 ` Uwe Kleine-König
2020-03-17 21:00 ` Uwe Kleine-König
2020-03-17 21:00 ` Uwe Kleine-König
2020-03-17 21:00 ` Uwe Kleine-König
2020-03-18 22:59 ` Thierry Reding
2020-03-18 22:59 ` Thierry Reding
2020-03-18 22:59 ` Thierry Reding
2020-03-18 22:59 ` Thierry Reding
2020-03-18 22:59 ` Thierry Reding
2020-03-19 6:50 ` Uwe Kleine-König
2020-03-19 6:50 ` Uwe Kleine-König
2020-03-19 6:50 ` Uwe Kleine-König
2020-03-19 6:50 ` Uwe Kleine-König
2020-03-19 6:50 ` Uwe Kleine-König
2020-03-19 16:37 ` Thierry Reding
2020-03-19 16:37 ` Thierry Reding
2020-03-19 16:37 ` Thierry Reding
2020-03-19 16:37 ` Thierry Reding
2020-03-19 16:37 ` Thierry Reding
2020-03-19 17:30 ` Uwe Kleine-König
2020-03-19 17:30 ` Uwe Kleine-König
2020-03-19 17:30 ` Uwe Kleine-König
2020-03-19 17:30 ` Uwe Kleine-König
2020-03-19 17:30 ` Uwe Kleine-König
2020-03-19 11:40 ` Oleksandr Suvorov
2020-03-19 11:40 ` Oleksandr Suvorov
2020-03-19 11:40 ` Oleksandr Suvorov
2020-03-19 11:40 ` Oleksandr Suvorov
2020-03-19 11:40 ` Oleksandr Suvorov
2020-03-19 12:10 ` Uwe Kleine-König
2020-03-19 12:10 ` Uwe Kleine-König
2020-03-19 12:10 ` Uwe Kleine-König
2020-03-19 12:10 ` Uwe Kleine-König
2020-03-19 12:10 ` Uwe Kleine-König
2020-03-19 12:57 ` Oleksandr Suvorov
2020-03-19 12:57 ` Oleksandr Suvorov
2020-03-19 12:57 ` Oleksandr Suvorov
2020-03-19 12:57 ` Oleksandr Suvorov
2020-03-19 12:57 ` Oleksandr Suvorov
2020-03-19 16:44 ` Thierry Reding
2020-03-19 16:44 ` Thierry Reding
2020-03-19 16:44 ` Thierry Reding
2020-03-19 16:44 ` Thierry Reding
2020-03-19 16:44 ` Thierry Reding
2020-03-18 11:47 ` Oleksandr Suvorov
2020-03-18 11:47 ` Oleksandr Suvorov
2020-03-18 11:47 ` Oleksandr Suvorov
2020-03-18 11:47 ` Oleksandr Suvorov
2020-03-18 11:47 ` Oleksandr Suvorov
2020-03-17 12:32 ` [RFC PATCH 2/7] dt-bindings: pwm: document the PWM polarity flag Oleksandr Suvorov
[not found] ` <20200317123231.2843297-3-oleksandr.suvorov-2KBjVHiyJgBBDgjK7y7TUQ@public.gmane.org>
2020-03-17 17:43 ` Thierry Reding [this message]
2020-03-17 17:43 ` Thierry Reding
2020-03-17 21:30 ` Uwe Kleine-König
2020-03-17 21:30 ` Uwe Kleine-König
2020-03-18 23:05 ` Thierry Reding
2020-03-19 7:05 ` Uwe Kleine-König
2020-03-19 7:05 ` Uwe Kleine-König
[not found] ` <20200319070510.gc6hr53gn7n2osvb-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2020-03-19 17:04 ` Thierry Reding
2020-03-19 17:04 ` Thierry Reding
2020-03-30 21:00 ` Rob Herring
[not found] ` <20200317213056.futfiwn4qgr2njye-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2020-03-18 23:19 ` Thierry Reding
2020-03-18 23:19 ` Thierry Reding
2020-03-17 22:58 ` Laurent Pinchart
2020-03-17 12:32 ` [RFC PATCH 3/7] dt-bindings: pwm: add normal " Oleksandr Suvorov
[not found] ` <20200317123231.2843297-4-oleksandr.suvorov-2KBjVHiyJgBBDgjK7y7TUQ@public.gmane.org>
2020-03-17 13:36 ` Paul Barker
2020-03-17 13:36 ` Paul Barker
2020-03-17 14:06 ` Oleksandr Suvorov
2020-03-17 21:36 ` Uwe Kleine-König
2020-03-17 21:36 ` Uwe Kleine-König
2020-03-17 22:56 ` Laurent Pinchart
2020-03-18 9:20 ` Uwe Kleine-König
[not found] ` <20200317123231.2843297-1-oleksandr.suvorov-2KBjVHiyJgBBDgjK7y7TUQ@public.gmane.org>
2020-03-17 12:32 ` [RFC PATCH 4/7] dt-bindings: pwm: add description of PWM polarity Oleksandr Suvorov
2020-03-17 12:32 ` Oleksandr Suvorov
2020-03-17 23:01 ` Laurent Pinchart
2020-03-18 11:37 ` Oleksandr Suvorov
2020-03-18 12:29 ` Laurent Pinchart
[not found] ` <20200318122942.GA7833-N3hz7ZxfLydczECFQUw77jytWr6r+dGw0E9HWUfgJXw@public.gmane.org>
2020-03-18 12:36 ` Oleksandr Suvorov
2020-03-18 12:36 ` Oleksandr Suvorov
2020-03-17 12:32 ` [RFC PATCH 5/7] pwm: replace polarity enum with macros Oleksandr Suvorov
2020-03-17 12:32 ` Oleksandr Suvorov
2020-03-17 12:32 ` Oleksandr Suvorov
2020-03-17 12:32 ` Oleksandr Suvorov
2020-03-17 12:32 ` Oleksandr Suvorov
2020-03-17 12:32 ` [RFC PATCH 6/7] arm64: dts: pwm: replace polarity constant with macro Oleksandr Suvorov
2020-03-17 12:32 ` Oleksandr Suvorov
2020-03-17 12:32 ` Oleksandr Suvorov
2020-03-17 12:32 ` Oleksandr Suvorov
2020-03-20 10:03 ` Krzysztof Kozlowski
2020-03-20 10:03 ` Krzysztof Kozlowski
2020-03-20 10:03 ` Krzysztof Kozlowski
2020-03-20 10:03 ` Krzysztof Kozlowski
2020-03-17 12:32 ` [RFC PATCH 7/7] arm: " Oleksandr Suvorov
2020-03-17 12:32 ` Oleksandr Suvorov
2020-03-17 12:32 ` Oleksandr Suvorov
2020-03-17 12:32 ` Oleksandr Suvorov
2020-03-20 10:02 ` Krzysztof Kozlowski
2020-03-20 10:02 ` Krzysztof Kozlowski
2020-03-20 10:02 ` Krzysztof Kozlowski
2020-03-20 10:02 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200317174344.GB1464607@ulmo \
--to=thierry.reding-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=igor.opaniuk-2KBjVHiyJgBBDgjK7y7TUQ@public.gmane.org \
--cc=laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-pwm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=marcel.ziswiler-2KBjVHiyJgBBDgjK7y7TUQ@public.gmane.org \
--cc=oleksandr.suvorov-2KBjVHiyJgBBDgjK7y7TUQ@public.gmane.org \
--cc=pbarker-OWPKS81ov/FWk0Htik3J/w@public.gmane.org \
--cc=philippe.schenker-2KBjVHiyJgBBDgjK7y7TUQ@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.