[PATCH v6] staging: rtl8192u: r8192U_wx: use netdev_warn() instead of printk()

[PATCH v6] staging: rtl8192u: r8192U_wx: use netdev_warn() instead of printk()

[Lourdes Pedrajas]

printk() is deprecated, use netdev_warn() instead, which is a message printing
function specific for network devices.
Issue found by checkpatch.

Suggested-by: Julia Lawall <julia.lawall@inria.fr>
Suggested-by: Stefano Brivio <sbrivio@redhat.com>
Signed-off-by: Lourdes Pedrajas <lu@pplo.net>
---
Changes since v5:
- Subject correction.

 drivers/staging/rtl8192u/r8192U_wx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8192u/r8192U_wx.c b/drivers/staging/rtl8192u/r8192U_wx.c
index 0118edb0b9ab..100532598781 100644
--- a/drivers/staging/rtl8192u/r8192U_wx.c
+++ b/drivers/staging/rtl8192u/r8192U_wx.c
@@ -588,7 +588,7 @@ static int r8192_wx_set_enc(struct net_device *dev,
 				hwkey);                 /* KeyContent */
 
 		} else {
-			printk("wrong type in WEP, not WEP40 and WEP104\n");
+			netdev_warn(dev, "wrong type in WEP, not WEP40 and WEP104\n");
 		}
 
 	}
-- 
2.17.1

Re: [PATCH v6] staging: rtl8192u: r8192U_wx: use netdev_warn() instead of printk()

[Greg KH]

On Tue, Mar 17, 2020 at 05:59:17PM +0100, Lourdes Pedrajas wrote:
> printk() is deprecated, use netdev_warn() instead, which is a message printing
> function specific for network devices.
> Issue found by checkpatch.
> 
> Suggested-by: Julia Lawall <julia.lawall@inria.fr>
> Suggested-by: Stefano Brivio <sbrivio@redhat.com>
> Signed-off-by: Lourdes Pedrajas <lu@pplo.net>
> ---
> Changes since v5:
> - Subject correction.

Thanks for sticking with this.

One further note, you should list _all_ the changes that have happened
over the series, v1-v6, in this list.  That makes it more obvious what
has happened over time.

I've queued this patch up now, no need to do it this time.

thanks,

greg k-h

Re: [PATCH v6] staging: rtl8192u: r8192U_wx: use netdev_warn() instead of printk()

[Lourdes Pedrajas]

On Wed, Mar 18, 2020 at 11:14:39AM +0100, Greg KH wrote:
> On Tue, Mar 17, 2020 at 05:59:17PM +0100, Lourdes Pedrajas wrote:
> > printk() is deprecated, use netdev_warn() instead, which is a message printing
> > function specific for network devices.
> > Issue found by checkpatch.
> > 
> > Suggested-by: Julia Lawall <julia.lawall@inria.fr>
> > Suggested-by: Stefano Brivio <sbrivio@redhat.com>
> > Signed-off-by: Lourdes Pedrajas <lu@pplo.net>
> > ---
> > Changes since v5:
> > - Subject correction.
> 
> Thanks for sticking with this.
> 
> One further note, you should list _all_ the changes that have happened
> over the series, v1-v6, in this list.  That makes it more obvious what
> has happened over time.
> 
> I've queued this patch up now, no need to do it this time.
> 
> thanks,
> 
> greg k-h

I will do so from now! :)

Thank you,
Lourdes