All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2 0/4] Correction of typos in comments
@ 2020-03-19 10:56 R Veera Kumar
  2020-03-19 10:56 ` [PATCH v2 1/4] staging: rtl8723bs: os_dep: Correct " R Veera Kumar
                   ` (4 more replies)
  0 siblings, 5 replies; 8+ messages in thread
From: R Veera Kumar @ 2020-03-19 10:56 UTC (permalink / raw)
  To: Greg Kroah-Hartman
  Cc: R Veera Kumar, Hans de Goede, Larry Finger, outreachy-kernel

Correct typos in comments.
Misspellings found using checkpatch.pl

---
R Veera Kumar (4):
  staging: rtl8723bs: os_dep: Correct typos in comments
  staging: rtl8723bs: os_dep: Correct typos in comments
  staging: rtl8723bs: os_dep: Correct typo in comment
  staging: rtl8723bs: os_dep: Correct typo in comment

 drivers/staging/rtl8723bs/os_dep/ioctl_linux.c   | 4 ++--
 drivers/staging/rtl8723bs/os_dep/os_intfs.c      | 4 ++--
 drivers/staging/rtl8723bs/os_dep/osdep_service.c | 2 +-
 drivers/staging/rtl8723bs/os_dep/recv_linux.c    | 2 +-
 4 files changed, 6 insertions(+), 6 deletions(-)

-- 
2.20.1



^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH v2 1/4] staging: rtl8723bs: os_dep: Correct typos in comments
  2020-03-19 10:56 [PATCH v2 0/4] Correction of typos in comments R Veera Kumar
@ 2020-03-19 10:56 ` R Veera Kumar
  2020-03-19 10:56 ` [PATCH v2 2/4] " R Veera Kumar
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 8+ messages in thread
From: R Veera Kumar @ 2020-03-19 10:56 UTC (permalink / raw)
  To: Greg Kroah-Hartman
  Cc: R Veera Kumar, Hans de Goede, Larry Finger, outreachy-kernel

Correct typos in comments.
Misspelling found using checkpatch.pl.

Signed-off-by: R Veera Kumar <vkor@vkten.in>
---
Changes in v2:
 - Remove word "Fix" from subject line
 - Change "C comments" to "comments" in subject line
 - Change "C comments" to "comments" in body
---
 drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
index 29f36cca3972..5059b874080e 100644
--- a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
+++ b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
@@ -1093,7 +1093,7 @@ static int rtw_wx_get_range(struct net_device *dev,
 /*  Commented by Albert 2009/10/13 */
 /*  The following code will proivde the security capability to network manager. */
 /*  If the driver doesn't provide this capability to network manager, */
-/*  the WPA/WPA2 routers can't be choosen in the network manager. */
+/*  the WPA/WPA2 routers can't be chosen in the network manager. */
 
 /*
 #define IW_SCAN_CAPA_NONE		0x00
@@ -1391,7 +1391,7 @@ static int rtw_wx_set_scan(struct net_device *dev, struct iw_request_info *a,
 
 		}
 
-		/* jeff: it has still some scan paramater to parse, we only do this now... */
+		/* jeff: it has still some scan parameter to parse, we only do this now... */
 		_status = rtw_set_802_11_bssid_list_scan(padapter, ssid, RTW_SSID_SCAN_AMOUNT);
 
 	} else {
-- 
2.20.1



^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH v2 2/4] staging: rtl8723bs: os_dep: Correct typos in comments
  2020-03-19 10:56 [PATCH v2 0/4] Correction of typos in comments R Veera Kumar
  2020-03-19 10:56 ` [PATCH v2 1/4] staging: rtl8723bs: os_dep: Correct " R Veera Kumar
@ 2020-03-19 10:56 ` R Veera Kumar
  2020-03-19 10:56 ` [PATCH v2 3/4] staging: rtl8723bs: os_dep: Correct typo in comment R Veera Kumar
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 8+ messages in thread
From: R Veera Kumar @ 2020-03-19 10:56 UTC (permalink / raw)
  To: Greg Kroah-Hartman
  Cc: R Veera Kumar, Hans de Goede, Larry Finger, outreachy-kernel

Correct typos in comments.
Misspelling found using checkpatch.pl.

Signed-off-by: R Veera Kumar <vkor@vkten.in>
---
Changes in v2:
 - Remove word "Fix" from subject line
 - Change "C comments" to "comments" in subject line
 - Change "C comments" to "comments" in body
---
 drivers/staging/rtl8723bs/os_dep/os_intfs.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
index 17e65934fb5b..d29f59bbb613 100644
--- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c
+++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
@@ -1274,7 +1274,7 @@ void rtw_suspend_wow(struct adapter *padapter)
 			padapter->intf_stop(padapter);
 		}
 
-		/*  2.1 clean interupt */
+		/*  2.1 clean interrupt */
 		if (padapter->HalFunc.clear_interrupt)
 			padapter->HalFunc.clear_interrupt(padapter);
 
@@ -1348,7 +1348,7 @@ void rtw_suspend_ap_wow(struct adapter *padapter)
 	/*  2. disable interrupt */
 	rtw_hal_disable_interrupt(padapter); /*  It need wait for leaving 32K. */
 
-	/*  2.1 clean interupt */
+	/*  2.1 clean interrupt */
 	if (padapter->HalFunc.clear_interrupt)
 		padapter->HalFunc.clear_interrupt(padapter);
 
-- 
2.20.1



^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH v2 3/4] staging: rtl8723bs: os_dep: Correct typo in comment
  2020-03-19 10:56 [PATCH v2 0/4] Correction of typos in comments R Veera Kumar
  2020-03-19 10:56 ` [PATCH v2 1/4] staging: rtl8723bs: os_dep: Correct " R Veera Kumar
  2020-03-19 10:56 ` [PATCH v2 2/4] " R Veera Kumar
@ 2020-03-19 10:56 ` R Veera Kumar
  2020-03-19 10:56 ` [PATCH v2 4/4] " R Veera Kumar
  2020-03-19 12:14 ` [PATCH v2 0/4] Correction of typos in comments Greg Kroah-Hartman
  4 siblings, 0 replies; 8+ messages in thread
From: R Veera Kumar @ 2020-03-19 10:56 UTC (permalink / raw)
  To: Greg Kroah-Hartman
  Cc: R Veera Kumar, Hans de Goede, Larry Finger, outreachy-kernel

Correct typos in comment.
Misspelling found using checkpatch.pl.

Signed-off-by: R Veera Kumar <vkor@vkten.in>
---
Changes in v2:
 - Remove word "Fix" from subject line
 - Change "C comments" to "comments" in subject line
 - Change "C comments" to "comments" in body
---
 drivers/staging/rtl8723bs/os_dep/osdep_service.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/os_dep/osdep_service.c b/drivers/staging/rtl8723bs/os_dep/osdep_service.c
index f5614e56371e..4238209ec175 100644
--- a/drivers/staging/rtl8723bs/os_dep/osdep_service.c
+++ b/drivers/staging/rtl8723bs/os_dep/osdep_service.c
@@ -289,7 +289,7 @@ void *rtw_cbuf_pop(struct rtw_cbuf *cbuf)
 }
 
 /**
- * rtw_cbuf_alloc - allocte a rtw_cbuf with given size and do initialization
+ * rtw_cbuf_alloc - allocate a rtw_cbuf with given size and do initialization
  * @size: size of pointer
  *
  * Returns: pointer of srtuct rtw_cbuf, NULL for allocation failure
-- 
2.20.1



^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH v2 4/4] staging: rtl8723bs: os_dep: Correct typo in comment
  2020-03-19 10:56 [PATCH v2 0/4] Correction of typos in comments R Veera Kumar
                   ` (2 preceding siblings ...)
  2020-03-19 10:56 ` [PATCH v2 3/4] staging: rtl8723bs: os_dep: Correct typo in comment R Veera Kumar
@ 2020-03-19 10:56 ` R Veera Kumar
  2020-03-19 12:14 ` [PATCH v2 0/4] Correction of typos in comments Greg Kroah-Hartman
  4 siblings, 0 replies; 8+ messages in thread
From: R Veera Kumar @ 2020-03-19 10:56 UTC (permalink / raw)
  To: Greg Kroah-Hartman
  Cc: R Veera Kumar, Hans de Goede, Larry Finger, outreachy-kernel

Correct typos in comment.
Misspelling found using checkpatch.pl.

Signed-off-by: R Veera Kumar <vkor@vkten.in>
---
Changes in v2:
 - Remove word "Fix" from subject line
 - Change "C comments" to "comments" in subject line
 - Change "C comments" to "comments" in body
---
 drivers/staging/rtl8723bs/os_dep/recv_linux.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/os_dep/recv_linux.c b/drivers/staging/rtl8723bs/os_dep/recv_linux.c
index 22059bbbed9d..a6491f163272 100644
--- a/drivers/staging/rtl8723bs/os_dep/recv_linux.c
+++ b/drivers/staging/rtl8723bs/os_dep/recv_linux.c
@@ -101,7 +101,7 @@ void rtw_os_recv_indicate_pkt(struct adapter *padapter, _pkt *pkt, struct rx_pkt
 	struct mlme_priv*pmlmepriv = &padapter->mlmepriv;
 	int ret;
 
-	/* Indicat the packets to upper layer */
+	/* Indicate the packets to upper layer */
 	if (pkt) {
 		if (check_fwstate(pmlmepriv, WIFI_AP_STATE) == true) {
 			_pkt *pskb2 = NULL;
-- 
2.20.1



^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH v2 0/4] Correction of typos in comments
  2020-03-19 10:56 [PATCH v2 0/4] Correction of typos in comments R Veera Kumar
                   ` (3 preceding siblings ...)
  2020-03-19 10:56 ` [PATCH v2 4/4] " R Veera Kumar
@ 2020-03-19 12:14 ` Greg Kroah-Hartman
  2020-03-19 12:44   ` [Outreachy kernel] " R Veera Kumar
  4 siblings, 1 reply; 8+ messages in thread
From: Greg Kroah-Hartman @ 2020-03-19 12:14 UTC (permalink / raw)
  To: R Veera Kumar; +Cc: Hans de Goede, Larry Finger, outreachy-kernel

On Thu, Mar 19, 2020 at 04:26:37PM +0530, R Veera Kumar wrote:
> Correct typos in comments.
> Misspellings found using checkpatch.pl
> 
> ---
> R Veera Kumar (4):
>   staging: rtl8723bs: os_dep: Correct typos in comments
>   staging: rtl8723bs: os_dep: Correct typos in comments
>   staging: rtl8723bs: os_dep: Correct typo in comment
>   staging: rtl8723bs: os_dep: Correct typo in comment

You need unique subject lines, please.


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [Outreachy kernel] Re: [PATCH v2 0/4] Correction of typos in comments
  2020-03-19 12:14 ` [PATCH v2 0/4] Correction of typos in comments Greg Kroah-Hartman
@ 2020-03-19 12:44   ` R Veera Kumar
  2020-03-19 12:47     ` Greg Kroah-Hartman
  0 siblings, 1 reply; 8+ messages in thread
From: R Veera Kumar @ 2020-03-19 12:44 UTC (permalink / raw)
  To: Greg Kroah-Hartman; +Cc: outreachy-kernel

On Thu, Mar 19, 2020 at 01:14:07PM +0100, Greg Kroah-Hartman wrote:
> On Thu, Mar 19, 2020 at 04:26:37PM +0530, R Veera Kumar wrote:
> > Correct typos in comments.
> > Misspellings found using checkpatch.pl
> > 
> > ---
> > R Veera Kumar (4):
> >   staging: rtl8723bs: os_dep: Correct typos in comments
> >   staging: rtl8723bs: os_dep: Correct typos in comments
> >   staging: rtl8723bs: os_dep: Correct typo in comment
> >   staging: rtl8723bs: os_dep: Correct typo in comment
> 
> You need unique subject lines, please.
> 

I do not know what to put.
Should I put the file names in subject. Someone told not to do so.
All the four patches correct one or two single letter misspellings
in one or two comments.

Can you give me a suggestion.

Veera


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [Outreachy kernel] Re: [PATCH v2 0/4] Correction of typos in comments
  2020-03-19 12:44   ` [Outreachy kernel] " R Veera Kumar
@ 2020-03-19 12:47     ` Greg Kroah-Hartman
  0 siblings, 0 replies; 8+ messages in thread
From: Greg Kroah-Hartman @ 2020-03-19 12:47 UTC (permalink / raw)
  To: R Veera Kumar; +Cc: outreachy-kernel

On Thu, Mar 19, 2020 at 06:14:33PM +0530, R Veera Kumar wrote:
> On Thu, Mar 19, 2020 at 01:14:07PM +0100, Greg Kroah-Hartman wrote:
> > On Thu, Mar 19, 2020 at 04:26:37PM +0530, R Veera Kumar wrote:
> > > Correct typos in comments.
> > > Misspellings found using checkpatch.pl
> > > 
> > > ---
> > > R Veera Kumar (4):
> > >   staging: rtl8723bs: os_dep: Correct typos in comments
> > >   staging: rtl8723bs: os_dep: Correct typos in comments
> > >   staging: rtl8723bs: os_dep: Correct typo in comment
> > >   staging: rtl8723bs: os_dep: Correct typo in comment
> > 
> > You need unique subject lines, please.
> > 
> 
> I do not know what to put.
> Should I put the file names in subject. Someone told not to do so.
> All the four patches correct one or two single letter misspellings
> in one or two comments.
> 
> Can you give me a suggestion.

That is up to you.  If you are not doing something unique in each
individual patch, then why did you think to break them up?  If they are
not doing the same exact thing, then you should be able to describe them
in a unique way.

good luck!

greg k-h


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2020-03-19 12:47 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-19 10:56 [PATCH v2 0/4] Correction of typos in comments R Veera Kumar
2020-03-19 10:56 ` [PATCH v2 1/4] staging: rtl8723bs: os_dep: Correct " R Veera Kumar
2020-03-19 10:56 ` [PATCH v2 2/4] " R Veera Kumar
2020-03-19 10:56 ` [PATCH v2 3/4] staging: rtl8723bs: os_dep: Correct typo in comment R Veera Kumar
2020-03-19 10:56 ` [PATCH v2 4/4] " R Veera Kumar
2020-03-19 12:14 ` [PATCH v2 0/4] Correction of typos in comments Greg Kroah-Hartman
2020-03-19 12:44   ` [Outreachy kernel] " R Veera Kumar
2020-03-19 12:47     ` Greg Kroah-Hartman

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.