From: Joerg Roedel <joro@8bytes.org>
To: iommu@lists.linux-foundation.org
Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-mediatek@lists.infradead.org, guohanjun@huawei.com,
Sudeep Holla <sudeep.holla@arm.com>,
Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>,
Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Joerg Roedel <joro@8bytes.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Thierry Reding <thierry.reding@gmail.com>,
Jean-Philippe Brucker <jean-philippe@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Joerg Roedel <jroedel@suse.de>
Subject: [PATCH v3 07/15] iommu/arm-smmu: Fix uninitilized variable warning
Date: Fri, 20 Mar 2020 10:14:06 +0100 [thread overview]
Message-ID: <20200320091414.3941-8-joro@8bytes.org> (raw)
In-Reply-To: <20200320091414.3941-1-joro@8bytes.org>
From: Joerg Roedel <jroedel@suse.de>
Some unrelated changes in the iommu code caused a new warning to
appear in the arm-smmu driver:
CC drivers/iommu/arm-smmu.o
drivers/iommu/arm-smmu.c: In function 'arm_smmu_add_device':
drivers/iommu/arm-smmu.c:1441:2: warning: 'smmu' may be used uninitialized in this function [-Wmaybe-uninitialized]
arm_smmu_rpm_put(smmu);
^~~~~~~~~~~~~~~~~~~~~~
The warning is a false positive, but initialize the variable to NULL
to get rid of it.
Tested-by: Will Deacon <will@kernel.org> # arm-smmu
Reviewed-by: Jean-Philippe Brucker <jean-philippe@linaro.org>
Signed-off-by: Joerg Roedel <jroedel@suse.de>
---
drivers/iommu/arm-smmu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c
index 16c4b87af42b..980aae73b45b 100644
--- a/drivers/iommu/arm-smmu.c
+++ b/drivers/iommu/arm-smmu.c
@@ -1383,7 +1383,7 @@ struct arm_smmu_device *arm_smmu_get_by_fwnode(struct fwnode_handle *fwnode)
static int arm_smmu_add_device(struct device *dev)
{
- struct arm_smmu_device *smmu;
+ struct arm_smmu_device *smmu = NULL;
struct arm_smmu_master_cfg *cfg;
struct iommu_fwspec *fwspec = dev_iommu_fwspec_get(dev);
int i, ret;
--
2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: iommu@lists.linux-foundation.org
Cc: Jean-Philippe Brucker <jean-philippe@linaro.org>,
Joerg Roedel <jroedel@suse.de>, Will Deacon <will@kernel.org>,
linux-arm-msm@vger.kernel.org, guohanjun@huawei.com,
linux-kernel@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Thierry Reding <thierry.reding@gmail.com>,
linux-mediatek@lists.infradead.org,
Andy Gross <agross@kernel.org>,
Sudeep Holla <sudeep.holla@arm.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Sean Paul <sean@poorly.run>, Robin Murphy <robin.murphy@arm.com>
Subject: [PATCH v3 07/15] iommu/arm-smmu: Fix uninitilized variable warning
Date: Fri, 20 Mar 2020 10:14:06 +0100 [thread overview]
Message-ID: <20200320091414.3941-8-joro@8bytes.org> (raw)
In-Reply-To: <20200320091414.3941-1-joro@8bytes.org>
From: Joerg Roedel <jroedel@suse.de>
Some unrelated changes in the iommu code caused a new warning to
appear in the arm-smmu driver:
CC drivers/iommu/arm-smmu.o
drivers/iommu/arm-smmu.c: In function 'arm_smmu_add_device':
drivers/iommu/arm-smmu.c:1441:2: warning: 'smmu' may be used uninitialized in this function [-Wmaybe-uninitialized]
arm_smmu_rpm_put(smmu);
^~~~~~~~~~~~~~~~~~~~~~
The warning is a false positive, but initialize the variable to NULL
to get rid of it.
Tested-by: Will Deacon <will@kernel.org> # arm-smmu
Reviewed-by: Jean-Philippe Brucker <jean-philippe@linaro.org>
Signed-off-by: Joerg Roedel <jroedel@suse.de>
---
drivers/iommu/arm-smmu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c
index 16c4b87af42b..980aae73b45b 100644
--- a/drivers/iommu/arm-smmu.c
+++ b/drivers/iommu/arm-smmu.c
@@ -1383,7 +1383,7 @@ struct arm_smmu_device *arm_smmu_get_by_fwnode(struct fwnode_handle *fwnode)
static int arm_smmu_add_device(struct device *dev)
{
- struct arm_smmu_device *smmu;
+ struct arm_smmu_device *smmu = NULL;
struct arm_smmu_master_cfg *cfg;
struct iommu_fwspec *fwspec = dev_iommu_fwspec_get(dev);
int i, ret;
--
2.17.1
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: iommu@lists.linux-foundation.org
Cc: Jean-Philippe Brucker <jean-philippe@linaro.org>,
Joerg Roedel <jroedel@suse.de>, Will Deacon <will@kernel.org>,
linux-arm-msm@vger.kernel.org, Joerg Roedel <joro@8bytes.org>,
guohanjun@huawei.com, linux-kernel@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Clark <robdclark@gmail.com>,
Thierry Reding <thierry.reding@gmail.com>,
linux-mediatek@lists.infradead.org,
Andy Gross <agross@kernel.org>,
Sudeep Holla <sudeep.holla@arm.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Sean Paul <sean@poorly.run>, Robin Murphy <robin.murphy@arm.com>
Subject: [PATCH v3 07/15] iommu/arm-smmu: Fix uninitilized variable warning
Date: Fri, 20 Mar 2020 10:14:06 +0100 [thread overview]
Message-ID: <20200320091414.3941-8-joro@8bytes.org> (raw)
In-Reply-To: <20200320091414.3941-1-joro@8bytes.org>
From: Joerg Roedel <jroedel@suse.de>
Some unrelated changes in the iommu code caused a new warning to
appear in the arm-smmu driver:
CC drivers/iommu/arm-smmu.o
drivers/iommu/arm-smmu.c: In function 'arm_smmu_add_device':
drivers/iommu/arm-smmu.c:1441:2: warning: 'smmu' may be used uninitialized in this function [-Wmaybe-uninitialized]
arm_smmu_rpm_put(smmu);
^~~~~~~~~~~~~~~~~~~~~~
The warning is a false positive, but initialize the variable to NULL
to get rid of it.
Tested-by: Will Deacon <will@kernel.org> # arm-smmu
Reviewed-by: Jean-Philippe Brucker <jean-philippe@linaro.org>
Signed-off-by: Joerg Roedel <jroedel@suse.de>
---
drivers/iommu/arm-smmu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c
index 16c4b87af42b..980aae73b45b 100644
--- a/drivers/iommu/arm-smmu.c
+++ b/drivers/iommu/arm-smmu.c
@@ -1383,7 +1383,7 @@ struct arm_smmu_device *arm_smmu_get_by_fwnode(struct fwnode_handle *fwnode)
static int arm_smmu_add_device(struct device *dev)
{
- struct arm_smmu_device *smmu;
+ struct arm_smmu_device *smmu = NULL;
struct arm_smmu_master_cfg *cfg;
struct iommu_fwspec *fwspec = dev_iommu_fwspec_get(dev);
int i, ret;
--
2.17.1
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2020-03-20 9:15 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-20 9:13 [PATCH v3 00/15] iommu: Move iommu_fwspec out of 'struct device' Joerg Roedel
2020-03-20 9:13 ` Joerg Roedel
2020-03-20 9:13 ` Joerg Roedel
2020-03-20 9:14 ` [PATCH v3 01/15] iommu: Define dev_iommu_fwspec_get() for !CONFIG_IOMMU_API Joerg Roedel
2020-03-20 9:14 ` Joerg Roedel
2020-03-20 9:14 ` Joerg Roedel
2020-03-20 9:14 ` [PATCH v3 02/15] ACPI/IORT: Remove direct access of dev->iommu_fwspec Joerg Roedel
2020-03-20 9:14 ` Joerg Roedel
2020-03-20 9:14 ` Joerg Roedel
2020-03-20 9:14 ` [PATCH v3 03/15] drm/msm/mdp5: " Joerg Roedel
2020-03-20 9:14 ` Joerg Roedel
2020-03-20 9:14 ` Joerg Roedel
2020-03-20 9:14 ` [PATCH v3 04/15] iommu/tegra-gart: " Joerg Roedel
2020-03-20 9:14 ` Joerg Roedel
2020-03-20 9:14 ` Joerg Roedel
2020-03-20 9:14 ` [PATCH v3 05/15] iommu: Rename struct iommu_param to dev_iommu Joerg Roedel
2020-03-20 9:14 ` Joerg Roedel
2020-03-20 9:14 ` Joerg Roedel
2020-03-20 9:14 ` [PATCH v3 06/15] iommu: Move iommu_fwspec to struct dev_iommu Joerg Roedel
2020-03-20 9:14 ` Joerg Roedel
2020-03-20 9:14 ` Joerg Roedel
2020-03-20 9:14 ` Joerg Roedel [this message]
2020-03-20 9:14 ` [PATCH v3 07/15] iommu/arm-smmu: Fix uninitilized variable warning Joerg Roedel
2020-03-20 9:14 ` Joerg Roedel
2020-03-20 9:14 ` [PATCH v3 08/15] iommu: Introduce accessors for iommu private data Joerg Roedel
2020-03-20 9:14 ` Joerg Roedel
2020-03-20 9:14 ` Joerg Roedel
2020-03-20 9:14 ` [PATCH v3 09/15] iommu/arm-smmu-v3: Use accessor functions " Joerg Roedel
2020-03-20 9:14 ` Joerg Roedel
2020-03-20 9:14 ` Joerg Roedel
2020-03-20 9:14 ` [PATCH v3 10/15] iommu/arm-smmu: " Joerg Roedel
2020-03-20 9:14 ` Joerg Roedel
2020-03-20 9:14 ` Joerg Roedel
2020-03-23 16:02 ` Robin Murphy
2020-03-23 16:02 ` Robin Murphy
2020-03-23 16:02 ` Robin Murphy
2020-03-24 10:08 ` Joerg Roedel
2020-03-24 10:08 ` Joerg Roedel
2020-03-24 10:08 ` Joerg Roedel
2020-03-25 12:31 ` Robin Murphy
2020-03-25 12:31 ` Robin Murphy
2020-03-25 12:31 ` Robin Murphy
2020-03-26 15:08 ` Joerg Roedel
2020-03-26 15:08 ` Joerg Roedel
2020-03-26 15:08 ` Joerg Roedel
2020-03-20 9:14 ` [PATCH v3 11/15] iommu/renesas: " Joerg Roedel
2020-03-20 9:14 ` Joerg Roedel
2020-03-20 9:14 ` Joerg Roedel
2020-03-20 9:14 ` [PATCH v3 12/15] iommu/mediatek: " Joerg Roedel
2020-03-20 9:14 ` Joerg Roedel
2020-03-20 9:14 ` Joerg Roedel
2020-03-20 9:14 ` [PATCH v3 13/15] iommu/qcom: " Joerg Roedel
2020-03-20 9:14 ` Joerg Roedel
2020-03-20 9:14 ` Joerg Roedel
2020-03-20 9:14 ` [PATCH v3 14/15] iommu/virtio: " Joerg Roedel
2020-03-20 9:14 ` Joerg Roedel
2020-03-20 9:14 ` Joerg Roedel
2020-03-20 9:14 ` [PATCH v3 15/15] iommu: Move fwspec->iommu_priv to struct dev_iommu Joerg Roedel
2020-03-20 9:14 ` Joerg Roedel
2020-03-20 9:14 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200320091414.3941-8-joro@8bytes.org \
--to=joro@8bytes.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=guohanjun@huawei.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jean-philippe@linaro.org \
--cc=jroedel@suse.de \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robdclark@gmail.com \
--cc=robin.murphy@arm.com \
--cc=sean@poorly.run \
--cc=sudeep.holla@arm.com \
--cc=thierry.reding@gmail.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.