From: Joerg Roedel <joro@8bytes.org>
To: Robin Murphy <robin.murphy@arm.com>
Cc: "iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"guohanjun@huawei.com" <guohanjun@huawei.com>,
Sudeep Holla <Sudeep.Holla@arm.com>,
Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>,
Will Deacon <will@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Thierry Reding <thierry.reding@gmail.com>,
Jean-Philippe Brucker <jean-philippe@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Joerg Roedel <jroedel@suse.de>
Subject: Re: [PATCH v3 10/15] iommu/arm-smmu: Use accessor functions for iommu private data
Date: Tue, 24 Mar 2020 11:08:19 +0100 [thread overview]
Message-ID: <20200324100819.GA4038@8bytes.org> (raw)
In-Reply-To: <09ed4676-449e-c6eb-8c51-c15b326c206c@arm.com>
Hey Robin,
On Mon, Mar 23, 2020 at 04:02:33PM +0000, Robin Murphy wrote:
> Yikes, this ends up pretty ugly, and I'd prefer not have this much
> complexity hidden in macros that were intended just to be convenient
> shorthand. Would you mind pulling in the patch below as a precursor?
Sure thing, but your mail-client seemed to have fiddled with the patch
so that is is unusable to me. I tried to fix it up, but it still doesn't
apply. Can you please re-send it to me either via git-send-email or just
as a mime-attachement?
> Other than that, the rest of the series looks OK at a glance. We should also
> move fwspec->ops to dev_iommu, as those are "IOMMU API" data rather than
> "firmware" data, but let's consider that separately as this series is
> already long enough.
Yes, moving ops out of fwspec is next on the list, and moving the
iommu_group pointer into dev_iommu.
Regards,
Joerg
WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Robin Murphy <robin.murphy@arm.com>
Cc: Joerg Roedel <jroedel@suse.de>, Will Deacon <will@kernel.org>,
Jean-Philippe Brucker <jean-philippe@linaro.org>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
"guohanjun@huawei.com" <guohanjun@huawei.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
"iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
Thierry Reding <thierry.reding@gmail.com>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
Andy Gross <agross@kernel.org>,
Sudeep Holla <Sudeep.Holla@arm.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Sean Paul <sean@poorly.run>
Subject: Re: [PATCH v3 10/15] iommu/arm-smmu: Use accessor functions for iommu private data
Date: Tue, 24 Mar 2020 11:08:19 +0100 [thread overview]
Message-ID: <20200324100819.GA4038@8bytes.org> (raw)
In-Reply-To: <09ed4676-449e-c6eb-8c51-c15b326c206c@arm.com>
Hey Robin,
On Mon, Mar 23, 2020 at 04:02:33PM +0000, Robin Murphy wrote:
> Yikes, this ends up pretty ugly, and I'd prefer not have this much
> complexity hidden in macros that were intended just to be convenient
> shorthand. Would you mind pulling in the patch below as a precursor?
Sure thing, but your mail-client seemed to have fiddled with the patch
so that is is unusable to me. I tried to fix it up, but it still doesn't
apply. Can you please re-send it to me either via git-send-email or just
as a mime-attachement?
> Other than that, the rest of the series looks OK at a glance. We should also
> move fwspec->ops to dev_iommu, as those are "IOMMU API" data rather than
> "firmware" data, but let's consider that separately as this series is
> already long enough.
Yes, moving ops out of fwspec is next on the list, and moving the
iommu_group pointer into dev_iommu.
Regards,
Joerg
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Robin Murphy <robin.murphy@arm.com>
Cc: Rob Clark <robdclark@gmail.com>, Joerg Roedel <jroedel@suse.de>,
Will Deacon <will@kernel.org>,
Jean-Philippe Brucker <jean-philippe@linaro.org>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
"guohanjun@huawei.com" <guohanjun@huawei.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
"iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
Thierry Reding <thierry.reding@gmail.com>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
Andy Gross <agross@kernel.org>,
Sudeep Holla <Sudeep.Holla@arm.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Sean Paul <sean@poorly.run>
Subject: Re: [PATCH v3 10/15] iommu/arm-smmu: Use accessor functions for iommu private data
Date: Tue, 24 Mar 2020 11:08:19 +0100 [thread overview]
Message-ID: <20200324100819.GA4038@8bytes.org> (raw)
In-Reply-To: <09ed4676-449e-c6eb-8c51-c15b326c206c@arm.com>
Hey Robin,
On Mon, Mar 23, 2020 at 04:02:33PM +0000, Robin Murphy wrote:
> Yikes, this ends up pretty ugly, and I'd prefer not have this much
> complexity hidden in macros that were intended just to be convenient
> shorthand. Would you mind pulling in the patch below as a precursor?
Sure thing, but your mail-client seemed to have fiddled with the patch
so that is is unusable to me. I tried to fix it up, but it still doesn't
apply. Can you please re-send it to me either via git-send-email or just
as a mime-attachement?
> Other than that, the rest of the series looks OK at a glance. We should also
> move fwspec->ops to dev_iommu, as those are "IOMMU API" data rather than
> "firmware" data, but let's consider that separately as this series is
> already long enough.
Yes, moving ops out of fwspec is next on the list, and moving the
iommu_group pointer into dev_iommu.
Regards,
Joerg
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2020-03-24 10:08 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-20 9:13 [PATCH v3 00/15] iommu: Move iommu_fwspec out of 'struct device' Joerg Roedel
2020-03-20 9:13 ` Joerg Roedel
2020-03-20 9:13 ` Joerg Roedel
2020-03-20 9:14 ` [PATCH v3 01/15] iommu: Define dev_iommu_fwspec_get() for !CONFIG_IOMMU_API Joerg Roedel
2020-03-20 9:14 ` Joerg Roedel
2020-03-20 9:14 ` Joerg Roedel
2020-03-20 9:14 ` [PATCH v3 02/15] ACPI/IORT: Remove direct access of dev->iommu_fwspec Joerg Roedel
2020-03-20 9:14 ` Joerg Roedel
2020-03-20 9:14 ` Joerg Roedel
2020-03-20 9:14 ` [PATCH v3 03/15] drm/msm/mdp5: " Joerg Roedel
2020-03-20 9:14 ` Joerg Roedel
2020-03-20 9:14 ` Joerg Roedel
2020-03-20 9:14 ` [PATCH v3 04/15] iommu/tegra-gart: " Joerg Roedel
2020-03-20 9:14 ` Joerg Roedel
2020-03-20 9:14 ` Joerg Roedel
2020-03-20 9:14 ` [PATCH v3 05/15] iommu: Rename struct iommu_param to dev_iommu Joerg Roedel
2020-03-20 9:14 ` Joerg Roedel
2020-03-20 9:14 ` Joerg Roedel
2020-03-20 9:14 ` [PATCH v3 06/15] iommu: Move iommu_fwspec to struct dev_iommu Joerg Roedel
2020-03-20 9:14 ` Joerg Roedel
2020-03-20 9:14 ` Joerg Roedel
2020-03-20 9:14 ` [PATCH v3 07/15] iommu/arm-smmu: Fix uninitilized variable warning Joerg Roedel
2020-03-20 9:14 ` Joerg Roedel
2020-03-20 9:14 ` Joerg Roedel
2020-03-20 9:14 ` [PATCH v3 08/15] iommu: Introduce accessors for iommu private data Joerg Roedel
2020-03-20 9:14 ` Joerg Roedel
2020-03-20 9:14 ` Joerg Roedel
2020-03-20 9:14 ` [PATCH v3 09/15] iommu/arm-smmu-v3: Use accessor functions " Joerg Roedel
2020-03-20 9:14 ` Joerg Roedel
2020-03-20 9:14 ` Joerg Roedel
2020-03-20 9:14 ` [PATCH v3 10/15] iommu/arm-smmu: " Joerg Roedel
2020-03-20 9:14 ` Joerg Roedel
2020-03-20 9:14 ` Joerg Roedel
2020-03-23 16:02 ` Robin Murphy
2020-03-23 16:02 ` Robin Murphy
2020-03-23 16:02 ` Robin Murphy
2020-03-24 10:08 ` Joerg Roedel [this message]
2020-03-24 10:08 ` Joerg Roedel
2020-03-24 10:08 ` Joerg Roedel
2020-03-25 12:31 ` Robin Murphy
2020-03-25 12:31 ` Robin Murphy
2020-03-25 12:31 ` Robin Murphy
2020-03-26 15:08 ` Joerg Roedel
2020-03-26 15:08 ` Joerg Roedel
2020-03-26 15:08 ` Joerg Roedel
2020-03-20 9:14 ` [PATCH v3 11/15] iommu/renesas: " Joerg Roedel
2020-03-20 9:14 ` Joerg Roedel
2020-03-20 9:14 ` Joerg Roedel
2020-03-20 9:14 ` [PATCH v3 12/15] iommu/mediatek: " Joerg Roedel
2020-03-20 9:14 ` Joerg Roedel
2020-03-20 9:14 ` Joerg Roedel
2020-03-20 9:14 ` [PATCH v3 13/15] iommu/qcom: " Joerg Roedel
2020-03-20 9:14 ` Joerg Roedel
2020-03-20 9:14 ` Joerg Roedel
2020-03-20 9:14 ` [PATCH v3 14/15] iommu/virtio: " Joerg Roedel
2020-03-20 9:14 ` Joerg Roedel
2020-03-20 9:14 ` Joerg Roedel
2020-03-20 9:14 ` [PATCH v3 15/15] iommu: Move fwspec->iommu_priv to struct dev_iommu Joerg Roedel
2020-03-20 9:14 ` Joerg Roedel
2020-03-20 9:14 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200324100819.GA4038@8bytes.org \
--to=joro@8bytes.org \
--cc=Sudeep.Holla@arm.com \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=guohanjun@huawei.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jean-philippe@linaro.org \
--cc=jroedel@suse.de \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robdclark@gmail.com \
--cc=robin.murphy@arm.com \
--cc=sean@poorly.run \
--cc=thierry.reding@gmail.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.