* [PATCH] staging: ks7010: rearrange line exceeding 80 characters
@ 2020-03-21 0:22 Gokce Kuler
2020-03-21 9:32 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Gokce Kuler @ 2020-03-21 0:22 UTC (permalink / raw)
To: outreachy-kernel; +Cc: gregkh
Moved to the bottom line after == operator for it exceeds 80 character
Signed-off-by: Gokce Kuler <gokcekuler@gmail.com>
---
drivers/staging/ks7010/ks_hostif.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c
index 2666f9e..7ed8300 100644
--- a/drivers/staging/ks7010/ks_hostif.c
+++ b/drivers/staging/ks7010/ks_hostif.c
@@ -1953,8 +1953,10 @@ static void hostif_sme_power_mgmt_set(struct ks_wlan_private *priv)
mode = (priv->reg.operation_mode == MODE_INFRASTRUCTURE) ?
POWER_SAVE : POWER_ACTIVE;
wake_up = 0;
- receive_dtims = (priv->reg.operation_mode == MODE_INFRASTRUCTURE &&
- priv->reg.power_mgmt == POWER_MGMT_SAVE2);
+ receive_dtims = (priv->reg.operation_mode ==
+ MODE_INFRASTRUCTURE &&
+ priv->reg.power_mgmt ==
+ POWER_MGMT_SAVE2);
}
hostif_power_mgmt_request(priv, mode, wake_up, receive_dtims);
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: ks7010: rearrange line exceeding 80 characters
2020-03-21 0:22 [PATCH] staging: ks7010: rearrange line exceeding 80 characters Gokce Kuler
@ 2020-03-21 9:32 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2020-03-21 9:32 UTC (permalink / raw)
To: Gokce Kuler; +Cc: outreachy-kernel
On Sat, Mar 21, 2020 at 03:22:59AM +0300, Gokce Kuler wrote:
> Moved to the bottom line after == operator for it exceeds 80 character
>
> Signed-off-by: Gokce Kuler <gokcekuler@gmail.com>
> ---
> drivers/staging/ks7010/ks_hostif.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c
> index 2666f9e..7ed8300 100644
> --- a/drivers/staging/ks7010/ks_hostif.c
> +++ b/drivers/staging/ks7010/ks_hostif.c
> @@ -1953,8 +1953,10 @@ static void hostif_sme_power_mgmt_set(struct ks_wlan_private *priv)
> mode = (priv->reg.operation_mode == MODE_INFRASTRUCTURE) ?
> POWER_SAVE : POWER_ACTIVE;
> wake_up = 0;
> - receive_dtims = (priv->reg.operation_mode == MODE_INFRASTRUCTURE &&
> - priv->reg.power_mgmt == POWER_MGMT_SAVE2);
> + receive_dtims = (priv->reg.operation_mode ==
> + MODE_INFRASTRUCTURE &&
> + priv->reg.power_mgmt ==
> + POWER_MGMT_SAVE2);
This is now much harder to read and understand, so I woudl just leave
the original as-is.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-21 9:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-21 0:22 [PATCH] staging: ks7010: rearrange line exceeding 80 characters Gokce Kuler
2020-03-21 9:32 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.