[PATCH] stagin: hp100: space prohibited between function name and open parenthesis '('

[PATCH] stagin: hp100: space prohibited between function name and open parenthesis '('

[Gokce Kuler]

Delete space between funtion name and open parenthesis

Signed-off-by: Gokce Kuler <gokcekuler@gmail.com>
---
 drivers/staging/hp/hp100.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/hp/hp100.c b/drivers/staging/hp/hp100.c
index b89c4dc..551cd52 100644
--- a/drivers/staging/hp/hp100.c
+++ b/drivers/staging/hp/hp100.c
@@ -3020,7 +3020,7 @@ static int __init hp100_module_init(void)
 static void __exit hp100_module_exit(void)
 {
 	hp100_isa_cleanup();
-	eisa_driver_unregister (&hp100_eisa_driver);
+	eisa_driver_unregister(&hp100_eisa_driver);
 	pci_unregister_driver (&hp100_pci_driver);
 }
 
-- 
2.7.4

Re: [PATCH] stagin: hp100: space prohibited between function name and open parenthesis '('

[Greg KH]

On Sat, Mar 21, 2020 at 04:41:23AM +0300, Gokce Kuler wrote:
> Delete space between funtion name and open parenthesis
> 
> Signed-off-by: Gokce Kuler <gokcekuler@gmail.com>
> ---
>  drivers/staging/hp/hp100.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/hp/hp100.c b/drivers/staging/hp/hp100.c
> index b89c4dc..551cd52 100644
> --- a/drivers/staging/hp/hp100.c
> +++ b/drivers/staging/hp/hp100.c
> @@ -3020,7 +3020,7 @@ static int __init hp100_module_init(void)
>  static void __exit hp100_module_exit(void)
>  {
>  	hp100_isa_cleanup();
> -	eisa_driver_unregister (&hp100_eisa_driver);
> +	eisa_driver_unregister(&hp100_eisa_driver);
>  	pci_unregister_driver (&hp100_pci_driver);

Why did you just do this to only 1 line and not both in this function?
How about this whole file?

thanks,

greg k-h

Re: [Outreachy kernel] [PATCH] stagin: hp100: space prohibited between function name and open parenthesis '('

[Julia Lawall]

On Sat, 21 Mar 2020, Gokce Kuler wrote:

> Delete space between funtion name and open parenthesis

Greg made another comment on this, but you also have a typo in the log
message: funtion -> function

julia

>
> Signed-off-by: Gokce Kuler <gokcekuler@gmail.com>
> ---
>  drivers/staging/hp/hp100.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/hp/hp100.c b/drivers/staging/hp/hp100.c
> index b89c4dc..551cd52 100644
> --- a/drivers/staging/hp/hp100.c
> +++ b/drivers/staging/hp/hp100.c
> @@ -3020,7 +3020,7 @@ static int __init hp100_module_init(void)
>  static void __exit hp100_module_exit(void)
>  {
>  	hp100_isa_cleanup();
> -	eisa_driver_unregister (&hp100_eisa_driver);
> +	eisa_driver_unregister(&hp100_eisa_driver);
>  	pci_unregister_driver (&hp100_pci_driver);
>  }
>
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200321014123.GA17832%40siyah2.
>