* [PATCH] stagin: hp100: space prohibited between function name and open parenthesis '('
@ 2020-03-21 1:41 Gokce Kuler
2020-03-21 6:54 ` Greg KH
2020-03-21 7:36 ` [Outreachy kernel] " Julia Lawall
0 siblings, 2 replies; 3+ messages in thread
From: Gokce Kuler @ 2020-03-21 1:41 UTC (permalink / raw)
To: outreachy-kernel; +Cc: gregkh
Delete space between funtion name and open parenthesis
Signed-off-by: Gokce Kuler <gokcekuler@gmail.com>
---
drivers/staging/hp/hp100.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/hp/hp100.c b/drivers/staging/hp/hp100.c
index b89c4dc..551cd52 100644
--- a/drivers/staging/hp/hp100.c
+++ b/drivers/staging/hp/hp100.c
@@ -3020,7 +3020,7 @@ static int __init hp100_module_init(void)
static void __exit hp100_module_exit(void)
{
hp100_isa_cleanup();
- eisa_driver_unregister (&hp100_eisa_driver);
+ eisa_driver_unregister(&hp100_eisa_driver);
pci_unregister_driver (&hp100_pci_driver);
}
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] stagin: hp100: space prohibited between function name and open parenthesis '('
2020-03-21 1:41 [PATCH] stagin: hp100: space prohibited between function name and open parenthesis '(' Gokce Kuler
@ 2020-03-21 6:54 ` Greg KH
2020-03-21 7:36 ` [Outreachy kernel] " Julia Lawall
1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2020-03-21 6:54 UTC (permalink / raw)
To: Gokce Kuler; +Cc: outreachy-kernel
On Sat, Mar 21, 2020 at 04:41:23AM +0300, Gokce Kuler wrote:
> Delete space between funtion name and open parenthesis
>
> Signed-off-by: Gokce Kuler <gokcekuler@gmail.com>
> ---
> drivers/staging/hp/hp100.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/hp/hp100.c b/drivers/staging/hp/hp100.c
> index b89c4dc..551cd52 100644
> --- a/drivers/staging/hp/hp100.c
> +++ b/drivers/staging/hp/hp100.c
> @@ -3020,7 +3020,7 @@ static int __init hp100_module_init(void)
> static void __exit hp100_module_exit(void)
> {
> hp100_isa_cleanup();
> - eisa_driver_unregister (&hp100_eisa_driver);
> + eisa_driver_unregister(&hp100_eisa_driver);
> pci_unregister_driver (&hp100_pci_driver);
Why did you just do this to only 1 line and not both in this function?
How about this whole file?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Outreachy kernel] [PATCH] stagin: hp100: space prohibited between function name and open parenthesis '('
2020-03-21 1:41 [PATCH] stagin: hp100: space prohibited between function name and open parenthesis '(' Gokce Kuler
2020-03-21 6:54 ` Greg KH
@ 2020-03-21 7:36 ` Julia Lawall
1 sibling, 0 replies; 3+ messages in thread
From: Julia Lawall @ 2020-03-21 7:36 UTC (permalink / raw)
To: Gokce Kuler; +Cc: outreachy-kernel, gregkh
On Sat, 21 Mar 2020, Gokce Kuler wrote:
> Delete space between funtion name and open parenthesis
Greg made another comment on this, but you also have a typo in the log
message: funtion -> function
julia
>
> Signed-off-by: Gokce Kuler <gokcekuler@gmail.com>
> ---
> drivers/staging/hp/hp100.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/hp/hp100.c b/drivers/staging/hp/hp100.c
> index b89c4dc..551cd52 100644
> --- a/drivers/staging/hp/hp100.c
> +++ b/drivers/staging/hp/hp100.c
> @@ -3020,7 +3020,7 @@ static int __init hp100_module_init(void)
> static void __exit hp100_module_exit(void)
> {
> hp100_isa_cleanup();
> - eisa_driver_unregister (&hp100_eisa_driver);
> + eisa_driver_unregister(&hp100_eisa_driver);
> pci_unregister_driver (&hp100_pci_driver);
> }
>
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200321014123.GA17832%40siyah2.
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-21 7:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-21 1:41 [PATCH] stagin: hp100: space prohibited between function name and open parenthesis '(' Gokce Kuler
2020-03-21 6:54 ` Greg KH
2020-03-21 7:36 ` [Outreachy kernel] " Julia Lawall
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.