* [PATCH] monitor/hmp-cmds: remove redundant check for tls_authz in hmp_info_migrate_parameters
@ 2020-03-21 15:10 Mao Zhongyi
2020-03-24 10:27 ` Dr. David Alan Gilbert
0 siblings, 1 reply; 2+ messages in thread
From: Mao Zhongyi @ 2020-03-21 15:10 UTC (permalink / raw)
To: qemu-devel; +Cc: dgilbert, Mao Zhongyi, armbru
'params->has_tls_authz = true' has been hardcoded as true in
qmp_query_migrate_parameters, so remove the redundant check.
Signed-off-by: Mao Zhongyi <maozhongyi@cmss.chinamobile.com>
---
monitor/hmp-cmds.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c
index f8be6bbb16..d18826309b 100644
--- a/monitor/hmp-cmds.c
+++ b/monitor/hmp-cmds.c
@@ -461,7 +461,7 @@ void hmp_info_migrate_parameters(Monitor *mon, const QDict *qdict)
params->max_postcopy_bandwidth);
monitor_printf(mon, "%s: '%s'\n",
MigrationParameter_str(MIGRATION_PARAMETER_TLS_AUTHZ),
- params->has_tls_authz ? params->tls_authz : "");
+ params->tls_authz);
}
qapi_free_MigrationParameters(params);
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] monitor/hmp-cmds: remove redundant check for tls_authz in hmp_info_migrate_parameters
2020-03-21 15:10 [PATCH] monitor/hmp-cmds: remove redundant check for tls_authz in hmp_info_migrate_parameters Mao Zhongyi
@ 2020-03-24 10:27 ` Dr. David Alan Gilbert
0 siblings, 0 replies; 2+ messages in thread
From: Dr. David Alan Gilbert @ 2020-03-24 10:27 UTC (permalink / raw)
To: Mao Zhongyi; +Cc: qemu-devel, armbru
* Mao Zhongyi (maozhongyi@cmss.chinamobile.com) wrote:
> 'params->has_tls_authz = true' has been hardcoded as true in
> qmp_query_migrate_parameters, so remove the redundant check.
>
> Signed-off-by: Mao Zhongyi <maozhongyi@cmss.chinamobile.com>
> ---
> monitor/hmp-cmds.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c
> index f8be6bbb16..d18826309b 100644
> --- a/monitor/hmp-cmds.c
> +++ b/monitor/hmp-cmds.c
> @@ -461,7 +461,7 @@ void hmp_info_migrate_parameters(Monitor *mon, const QDict *qdict)
> params->max_postcopy_bandwidth);
> monitor_printf(mon, "%s: '%s'\n",
> MigrationParameter_str(MIGRATION_PARAMETER_TLS_AUTHZ),
> - params->has_tls_authz ? params->tls_authz : "");
> + params->tls_authz);
> }
>
> qapi_free_MigrationParameters(params);
That's OK, but we may as well combine it with the previous one.
Dave
> --
> 2.17.1
>
>
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-24 10:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-21 15:10 [PATCH] monitor/hmp-cmds: remove redundant check for tls_authz in hmp_info_migrate_parameters Mao Zhongyi
2020-03-24 10:27 ` Dr. David Alan Gilbert
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.