All of lore.kernel.org
 help / color / mirror / Atom feed
From: Catalin Marinas <catalin.marinas@arm.com>
To: Mark Rutland <mark.rutland@arm.com>
Cc: james.morse@arm.com, will@kernel.org,
	linux-arm-kernel@lists.infradead.org,
	"Rémi Denis-Courmont" <remi@remlab.net>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] arm64: clean up trampoline vector loads
Date: Tue, 24 Mar 2020 11:23:17 +0000	[thread overview]
Message-ID: <20200324112316.GG4892@mbp> (raw)
In-Reply-To: <20200324105217.GA20256@C02TD0UTHF1T.local>

On Tue, Mar 24, 2020 at 10:52:17AM +0000, Mark Rutland wrote:
> On Mon, Mar 23, 2020 at 10:42:30PM +0200, Rémi Denis-Courmont wrote:
> > Le maanantaina 23. maaliskuuta 2020, 21.04.09 EET Catalin Marinas a écrit :
> > > Should we just use adrp on __entry_tramp_data_start? Anyway, the diff
> > > below doesn't solve the issue I'm seeing (only reverting patch 3).
> > 
> > AFAIU, the preexisting code uses the manual PAGE_SIZE offset because the offset 
> > in the main vmlinux does not match the architected offset inside the fixmap. If 
> > so, then using the symbol directly will not work at all.
> 
> Indeed. I can't see a neat way of avoiding this right now, so should we
> drop these patches and leave the code as-is (but with comments as to the
> special requirements that it has)?

I'm going to drop these three patches from -next for now but I can take
any updated comments (they are pretty much missing from this code).

Thanks.

-- 
Catalin

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Catalin Marinas <catalin.marinas@arm.com>
To: Mark Rutland <mark.rutland@arm.com>
Cc: "Rémi Denis-Courmont" <remi@remlab.net>,
	will@kernel.org, james.morse@arm.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] arm64: clean up trampoline vector loads
Date: Tue, 24 Mar 2020 11:23:17 +0000	[thread overview]
Message-ID: <20200324112316.GG4892@mbp> (raw)
In-Reply-To: <20200324105217.GA20256@C02TD0UTHF1T.local>

On Tue, Mar 24, 2020 at 10:52:17AM +0000, Mark Rutland wrote:
> On Mon, Mar 23, 2020 at 10:42:30PM +0200, Rémi Denis-Courmont wrote:
> > Le maanantaina 23. maaliskuuta 2020, 21.04.09 EET Catalin Marinas a écrit :
> > > Should we just use adrp on __entry_tramp_data_start? Anyway, the diff
> > > below doesn't solve the issue I'm seeing (only reverting patch 3).
> > 
> > AFAIU, the preexisting code uses the manual PAGE_SIZE offset because the offset 
> > in the main vmlinux does not match the architected offset inside the fixmap. If 
> > so, then using the symbol directly will not work at all.
> 
> Indeed. I can't see a neat way of avoiding this right now, so should we
> drop these patches and leave the code as-is (but with comments as to the
> special requirements that it has)?

I'm going to drop these three patches from -next for now but I can take
any updated comments (they are pretty much missing from this code).

Thanks.

-- 
Catalin

  reply	other threads:[~2020-03-24 11:23 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-19  9:12 [PATCHv3 0/3] clean up KPTI / SDEI trampoline data alignment Rémi Denis-Courmont
2020-03-19  9:12 ` Rémi Denis-Courmont
2020-03-19  9:14 ` [PATCH 1/3] arm64: clean up trampoline vector loads Rémi Denis-Courmont
2020-03-19  9:14   ` Rémi Denis-Courmont
2020-03-23 12:07   ` Mark Rutland
2020-03-23 12:07     ` Mark Rutland
2020-03-23 12:08     ` Rémi Denis-Courmont
2020-03-23 12:08       ` Rémi Denis-Courmont
2020-03-23 12:14       ` Mark Rutland
2020-03-23 12:14         ` Mark Rutland
2020-03-23 19:04         ` Catalin Marinas
2020-03-23 19:04           ` Catalin Marinas
2020-03-23 20:42           ` Rémi Denis-Courmont
2020-03-23 20:42             ` Rémi Denis-Courmont
2020-03-24 10:37             ` Catalin Marinas
2020-03-24 10:37               ` Catalin Marinas
2020-03-24 10:52             ` Mark Rutland
2020-03-24 10:52               ` Mark Rutland
2020-03-24 11:23               ` Catalin Marinas [this message]
2020-03-24 11:23                 ` Catalin Marinas
2020-03-19  9:14 ` [PATCH 2/3] arm64/sdei: gather trampolines' .rodata Rémi Denis-Courmont
2020-03-19  9:14   ` Rémi Denis-Courmont
2020-03-19  9:14 ` [PATCH 3/3] arm64: reduce trampoline data alignment Rémi Denis-Courmont
2020-03-19  9:14   ` Rémi Denis-Courmont
2020-03-21 13:40   ` Catalin Marinas
2020-03-21 13:41     ` Catalin Marinas
2020-03-23 11:58     ` Mark Rutland
2020-03-23 11:58       ` Mark Rutland
2020-03-19 18:37 ` [PATCHv3 0/3] clean up KPTI / SDEI " Will Deacon
2020-03-19 18:37   ` Will Deacon
2020-03-20 16:54 ` Catalin Marinas
2020-03-20 16:54   ` Catalin Marinas
  -- strict thread matches above, loose matches on Subject: below --
2020-03-16 12:40 [PATCH 1/3] arm64: clean up trampoline vector loads Rémi Denis-Courmont
2020-03-16 12:40 ` Rémi Denis-Courmont
2020-03-17 22:30 ` Will Deacon
2020-03-17 22:30   ` Will Deacon
2020-03-18 17:57 ` Catalin Marinas
2020-03-18 17:57   ` Catalin Marinas
2020-03-18 18:06   ` Catalin Marinas
2020-03-18 18:06     ` Catalin Marinas
2020-03-18 18:29     ` Rémi Denis-Courmont
2020-03-18 18:29       ` Rémi Denis-Courmont
2020-03-18 19:48       ` Remi Denis-Courmont
2020-03-18 19:48         ` Remi Denis-Courmont

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200324112316.GG4892@mbp \
    --to=catalin.marinas@arm.com \
    --cc=james.morse@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=remi@remlab.net \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.