[PATCH v2] staging: octeon-usb: line over 80 characters

[PATCH v2] staging: octeon-usb: line over 80 characters

[Gokce Kuler]

Code readability increased for 80 character limit.

Signed-off-by: Gokce Kuler <gokcekuler@gmail.com>
---
 drivers/staging/octeon-usb/octeon-hcd.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb/octeon-hcd.c
index dbafd46..de3b082 100644
--- a/drivers/staging/octeon-usb/octeon-hcd.c
+++ b/drivers/staging/octeon-usb/octeon-hcd.c
@@ -2641,9 +2641,9 @@ static int cvmx_usb_poll_channel(struct octeon_hcd *usb, int channel)
 						     hcintmsk.u32);
 				usbc_hcchar.s.chdis = 1;
 				cvmx_usb_write_csr32(usb,
-						     CVMX_USBCX_HCCHARX(
-						     channel, usb->index),
-						     usbc_hcchar.u32);
+						CVMX_USBCX_HCCHARX(channel,
+						       	usb->index),
+						usbc_hcchar.u32);
 				return 0;
 			} else if (usbc_hcint.s.xfercompl) {
 				/*
-- 
2.7.4

Re: [Outreachy kernel] [PATCH v2] staging: octeon-usb: line over 80 characters

[Lakshmi Ramasubramanian]

On 3/25/20 3:31 PM, Gokce Kuler wrote:

> @@ -2641,9 +2641,9 @@ static int cvmx_usb_poll_channel(struct octeon_hcd *usb, int channel)
>   						     hcintmsk.u32);
>   				usbc_hcchar.s.chdis = 1;
>   				cvmx_usb_write_csr32(usb,
> -						     CVMX_USBCX_HCCHARX(
> -						     channel, usb->index),
> -						     usbc_hcchar.u32);
> +						CVMX_USBCX_HCCHARX(channel,
> +						       	usb->index),
> +						usbc_hcchar.u32);

This v2 patch is a diff from the v1. Right?
You should fix the v1 commit and generate the patch so that the diff is 
from the original code (I mean, the one prior to v1 change).

Could you please check?

Also, am not able to tell from the diff - please make sure the 
parameters are aligned with the previous line.

     cvmx_usb_write_csr32(usb,
                          CVMX_USBCX_HCCHARX(channel,
                                             usb->index),
                          usbc_hcchar.u32);

If I am not mistaken, that's the coding style followed now.

thanks,
  -lakshmi

Re: [PATCH v2] staging: octeon-usb: line over 80 characters

[Greg KH]

On Thu, Mar 26, 2020 at 01:31:55AM +0300, Gokce Kuler wrote:
> Code readability increased for 80 character limit.
> 
> Signed-off-by: Gokce Kuler <gokcekuler@gmail.com>
> ---
>  drivers/staging/octeon-usb/octeon-hcd.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

What changed from v1?  Always put that below the --- line

> 
> diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb/octeon-hcd.c
> index dbafd46..de3b082 100644
> --- a/drivers/staging/octeon-usb/octeon-hcd.c
> +++ b/drivers/staging/octeon-usb/octeon-hcd.c
> @@ -2641,9 +2641,9 @@ static int cvmx_usb_poll_channel(struct octeon_hcd *usb, int channel)
>  						     hcintmsk.u32);
>  				usbc_hcchar.s.chdis = 1;
>  				cvmx_usb_write_csr32(usb,
> -						     CVMX_USBCX_HCCHARX(
> -						     channel, usb->index),
> -						     usbc_hcchar.u32);
> +						CVMX_USBCX_HCCHARX(channel,
> +						       	usb->index),
> +						usbc_hcchar.u32);

No, that is harder to read now, you can try to get closer, but I would
just leave this alone for now as many people keep messing with it :)

thanks,

greg k-h