From: Al Viro <viro@zeniv.linux.org.uk>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: Sachin Sant <sachinp@linux.vnet.ibm.com>,
linuxppc-dev@lists.ozlabs.org, linux-fsdevel@vger.kernel.org,
Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: [powerpc] Intermittent crashes ( link_path_walk) with linux-next
Date: Thu, 26 Mar 2020 13:49:25 +0000 [thread overview]
Message-ID: <20200326134925.GP23230@ZenIV.linux.org.uk> (raw)
In-Reply-To: <87h7ybwdih.fsf@mpe.ellerman.id.au>
On Thu, Mar 26, 2020 at 10:40:06PM +1100, Michael Ellerman wrote:
> > The code in question (link_path_walk() in fs/namei.c ) was recently changed by
> > following commit:
> >
> > commit 881386f7e46a:
> > link_path_walk(): sample parent's i_uid and i_mode for the last component
>
> That and about 10 other commits.
>
> Unless Al can give us a clue we'll need to bisect.
Already fixed yesterday. It's not link_path_walk(), it's handle_dots()
ignoring an error returned by step_into().
commit 5e3c3570ec97 is the broken one; commit 20971012f63e is its variant with the
fix folded in. So next-20200325 has the bug and next-20200326 should have it
fixed. Could you check the current -next and see if you still observe that crap?
WARNING: multiple messages have this Message-ID (diff)
From: Al Viro <viro@zeniv.linux.org.uk>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: Sachin Sant <sachinp@linux.vnet.ibm.com>,
linux-fsdevel@vger.kernel.org,
Linux Next Mailing List <linux-next@vger.kernel.org>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [powerpc] Intermittent crashes ( link_path_walk) with linux-next
Date: Thu, 26 Mar 2020 13:49:25 +0000 [thread overview]
Message-ID: <20200326134925.GP23230@ZenIV.linux.org.uk> (raw)
In-Reply-To: <87h7ybwdih.fsf@mpe.ellerman.id.au>
On Thu, Mar 26, 2020 at 10:40:06PM +1100, Michael Ellerman wrote:
> > The code in question (link_path_walk() in fs/namei.c ) was recently changed by
> > following commit:
> >
> > commit 881386f7e46a:
> > link_path_walk(): sample parent's i_uid and i_mode for the last component
>
> That and about 10 other commits.
>
> Unless Al can give us a clue we'll need to bisect.
Already fixed yesterday. It's not link_path_walk(), it's handle_dots()
ignoring an error returned by step_into().
commit 5e3c3570ec97 is the broken one; commit 20971012f63e is its variant with the
fix folded in. So next-20200325 has the bug and next-20200326 should have it
fixed. Could you check the current -next and see if you still observe that crap?
next prev parent reply other threads:[~2020-03-26 13:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-26 8:27 [powerpc] Intermittent crashes ( link_path_walk) with linux-next Sachin Sant
2020-03-26 11:40 ` Michael Ellerman
2020-03-26 13:49 ` Al Viro [this message]
2020-03-26 13:49 ` Al Viro
2020-03-26 16:24 ` Sachin Sant
2020-03-26 16:24 ` Sachin Sant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200326134925.GP23230@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=sachinp@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.