* [PATCH] staging: ralink-gdma: add blank line
@ 2020-03-26 22:13 Gokce Kuler
2020-03-27 6:37 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Gokce Kuler @ 2020-03-26 22:13 UTC (permalink / raw)
To: outreachy-kernel; +Cc: gregkh
Add missing blank line after declarations to follow
the Linux kernel coding conventions.
Signed-off-by: Gokce Kuler <gokcekuler@gmail.com>
---
drivers/staging/ralink-gdma/ralink-gdma.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/ralink-gdma/ralink-gdma.c b/drivers/staging/ralink-gdma/ralink-gdma.c
index eabf109..b43f37f2 100644
--- a/drivers/staging/ralink-gdma/ralink-gdma.c
+++ b/drivers/staging/ralink-gdma/ralink-gdma.c
@@ -123,6 +123,7 @@ struct gdma_dma_dev {
void __iomem *base;
struct tasklet_struct task;
volatile unsigned long chan_issued;
+
atomic_t cnt;
struct gdma_dmaengine_chan chan[];
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] staging: ralink-gdma: add blank line
2020-03-26 22:13 [PATCH] staging: ralink-gdma: add blank line Gokce Kuler
@ 2020-03-27 6:37 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2020-03-27 6:37 UTC (permalink / raw)
To: Gokce Kuler; +Cc: outreachy-kernel
On Fri, Mar 27, 2020 at 01:13:35AM +0300, Gokce Kuler wrote:
> Add missing blank line after declarations to follow
> the Linux kernel coding conventions.
>
> Signed-off-by: Gokce Kuler <gokcekuler@gmail.com>
> ---
> drivers/staging/ralink-gdma/ralink-gdma.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/ralink-gdma/ralink-gdma.c b/drivers/staging/ralink-gdma/ralink-gdma.c
> index eabf109..b43f37f2 100644
> --- a/drivers/staging/ralink-gdma/ralink-gdma.c
> +++ b/drivers/staging/ralink-gdma/ralink-gdma.c
> @@ -123,6 +123,7 @@ struct gdma_dma_dev {
> void __iomem *base;
> struct tasklet_struct task;
> volatile unsigned long chan_issued;
> +
> atomic_t cnt;
>
> struct gdma_dmaengine_chan chan[];
No, you need to remove a blank line here to get this right, not add one.
Look at the list of variables...
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-27 6:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-26 22:13 [PATCH] staging: ralink-gdma: add blank line Gokce Kuler
2020-03-27 6:37 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.