* [PATCH v4] staging: qlge: Adjust end of block comment
@ 2020-03-27 13:49 Gokce Kuler
2020-03-27 13:52 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Gokce Kuler @ 2020-03-27 13:49 UTC (permalink / raw)
To: outreachy-kernel; +Cc: gregkh
Drop an unnecessary * on the last line of a block comment to follow the Linux kernel coding conventions.
Signed-off-by: Gokce Kuler <gokcekuler@gmail.com>
---
Changes in v4:
-Odd line-wrapping to message.
Changes in v3:
-Add v2 and v1 changes in e-mail.
Changes in v2:
-Edited the subject line and the log message.
Changes in v1:
-Drop an unnecessary * on the last line of a block comment.
---
drivers/staging/qlge/qlge_mpi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/qlge/qlge_mpi.c b/drivers/staging/qlge/qlge_mpi.c
index 60c08d9..31322ec 100644
--- a/drivers/staging/qlge/qlge_mpi.c
+++ b/drivers/staging/qlge/qlge_mpi.c
@@ -1178,7 +1178,7 @@ void ql_mpi_idc_work(struct work_struct *work)
/* Signal the resulting link up AEN
* that the frame routing and mac addr
* needs to be set.
- * */
+ */
set_bit(QL_CAM_RT_SET, &qdev->flags);
/* Do ACK if required */
if (timeout) {
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v4] staging: qlge: Adjust end of block comment
2020-03-27 13:49 [PATCH v4] staging: qlge: Adjust end of block comment Gokce Kuler
@ 2020-03-27 13:52 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2020-03-27 13:52 UTC (permalink / raw)
To: Gokce Kuler; +Cc: outreachy-kernel
On Fri, Mar 27, 2020 at 04:49:06PM +0300, Gokce Kuler wrote:
> Drop an unnecessary * on the last line of a block comment to follow the Linux kernel coding conventions.
> Signed-off-by: Gokce Kuler <gokcekuler@gmail.com>
Take some time, and review what you did here and see that there is no
rush. Go make a cup of tea/coffee/beer/whatever and take a pause.
Then, fix the line-wrap, add a new line before the signed-off-by: line,
and run the result through checkpatch.pl to ensure that all looks good
before sending it out again.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-27 13:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-27 13:49 [PATCH v4] staging: qlge: Adjust end of block comment Gokce Kuler
2020-03-27 13:52 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.