[PATCH v5] staging: qlge: Adjust end of block comment

[PATCH v5] staging: qlge: Adjust end of block comment

[Gokce Kuler]

Drop an unnecessary * on the last line of a block comment to follow the Linux kernel coding conventions.

Signed-off-by: Gokce Kuler <gokcekuler@gmail.com>
---
Changes in v5:
-Add a line before Signed-off-by: line
Changes in v4:
-Odd line-wrapping to message.
Changes in v3:
-Add v2 and v1 changes in e-mail.
Changes in v2:
-Edited the subject line and the log message.
Changes in v1:
-Drop an unnecessary * on the last line of a block comment.
---
 drivers/staging/qlge/qlge_mpi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/qlge/qlge_mpi.c b/drivers/staging/qlge/qlge_mpi.c
index 60c08d9..31322ec 100644
--- a/drivers/staging/qlge/qlge_mpi.c
+++ b/drivers/staging/qlge/qlge_mpi.c
@@ -1178,7 +1178,7 @@ void ql_mpi_idc_work(struct work_struct *work)
 		/* Signal the resulting link up AEN
 		 * that the frame routing and mac addr
 		 * needs to be set.
-		 * */
+		 */
 		set_bit(QL_CAM_RT_SET, &qdev->flags);
 		/* Do ACK if required */
 		if (timeout) {
-- 
2.7.4

Re: [Outreachy kernel] [PATCH v5] staging: qlge: Adjust end of block comment

[Stefano Brivio]

Hi Gökçe,

On Fri, 27 Mar 2020 20:44:01 +0300
Gokce Kuler <gokcekuler@gmail.com> wrote:

> Drop an unnecessary * on the last line of a block comment to follow the Linux kernel coding conventions.

Thanks for sticking with this, I understand this might be frustrating
but it's important that you get familiar with it.

So... Greg suggested that you should fix the strange line wrapping in
the commit message -- not that you avoid it altogether. Messages should
still be wrapped (to 70, 72, or 76 columns, you choose) characters.

A message like the one above, 104 columns, won't really be practical
for usage with git.

-- 
Stefano