Re: [Outreachy kernel] [Outreachy Kernel][PATCH 1/2] staging: wlang-ng: Properly align the lines of function call

[Stefano Brivio <sbrivio@redhat.com>]

On Fri, 27 Mar 2020 20:12:28 +0530
Soumyajit Deb <debsoumyajit100@gmail.com> wrote:

> Align the lines of function call to improve code readability and to
> adhere to the uniform Linux Kernel coding style.
> Reported by checkpatch.pl
> 
> Signed-off-by: Soumyajit Deb <debsoumyajit100@gmail.com>
> ---
>  drivers/staging/wlan-ng/cfg80211.c | 27 +++++++++++++--------------
>  1 file changed, 13 insertions(+), 14 deletions(-)
> 
> diff --git a/drivers/staging/wlan-ng/cfg80211.c b/drivers/staging/wlan-ng/cfg80211.c
> index fac38c842ac5..3d17037f954e 100644
> --- a/drivers/staging/wlan-ng/cfg80211.c
> +++ b/drivers/staging/wlan-ng/cfg80211.c
> @@ -359,16 +359,15 @@ static int prism2_scan(struct wiphy *wiphy,
>  		freq = ieee80211_channel_to_frequency(msg2.dschannel.data,
>  						      NL80211_BAND_2GHZ);
>  		bss = cfg80211_inform_bss(wiphy,
> -			ieee80211_get_channel(wiphy, freq),
> -			CFG80211_BSS_FTYPE_UNKNOWN,
> -			(const u8 *)&msg2.bssid.data.data,
> -			msg2.timestamp.data, msg2.capinfo.data,
> -			msg2.beaconperiod.data,
> -			ie_buf,
> -			ie_len,
> -			(msg2.signal.data - 65536) * 100, /* Conversion to signed type */
> -			GFP_KERNEL
> -		);
> +					  ieee80211_get_channel(wiphy, freq),
> +					  CFG80211_BSS_FTYPE_UNKNOWN,
> +					  (const u8 *)&msg2.bssid.data.data,
> +					  msg2.timestamp.data, msg2.capinfo.data,
> +					  msg2.beaconperiod.data,
> +					  ie_buf,
> +					  ie_len,
> +					  (msg2.signal.data - 65536) * 100, /* Conversion to signed type */

So... wait a moment:

- March 21, 17:30 UTC: you ask me on IRC how to fix the checkpatch
  warning you're introducing now. You propose to move the comment on a
  line by itself. I suggest that you write a test program and find out
  if this conversion can be done in another way. You say you will do
  that

- March 27, 10:58 UTC: you ask me on IRC if you can use a cast to "i32".
  I have a déjà vu, can't really remember who asked me this, and
  suggest that you write a test program. You say you will do that

- March 27, 12:12 UTC: you send the same question to this list

- March 27, 14:45 UTC: you send this patch

...why, exactly?

-- 
Stefano