From: Stefano Brivio <sbrivio@redhat.com>
To: Soumyajit Deb <debsoumyajit100@gmail.com>
Cc: outreachy-kernel@googlegroups.com, Greg KH <gregkh@linuxfoundation.org>
Subject: Re: [Outreachy kernel] [Outreachy Kernel][PATCH 1/2] staging: wlang-ng: Properly align the lines of function call
Date: Mon, 30 Mar 2020 14:50:48 +0200 [thread overview]
Message-ID: <20200330145048.535b89d6@elisabeth> (raw)
In-Reply-To: <CAMS7mKA1nxc4S7_y73QTvNXohZ25rbV+NkDiP-p0onzvdnUP7w@mail.gmail.com>
On Mon, 30 Mar 2020 15:44:43 +0530
Soumyajit Deb <debsoumyajit100@gmail.com> wrote:
> Is there any issue with this patch?
Yes, it makes the code even less readable because it reaches 115
columns.
--
Stefano
next prev parent reply other threads:[~2020-03-30 12:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-27 14:42 [Outreachy Kernel][PATCH 0/2] staging: wlan-ng: Resolve various warnings reported by checkpatch.pl Soumyajit Deb
2020-03-27 14:42 ` [Outreachy Kernel][PATCH 1/2] staging: wlang-ng: Properly align the lines of function call Soumyajit Deb
2020-03-30 9:12 ` [Outreachy kernel] " Stefano Brivio
2020-03-30 9:55 ` Soumyajit Deb
2020-03-30 10:14 ` Soumyajit Deb
2020-03-30 12:50 ` Stefano Brivio [this message]
2020-03-30 12:49 ` Stefano Brivio
2020-03-27 14:42 ` [Outreachy Kernel][PATCH 2/2] staging: wlan-ng: Line over 80 characters Soumyajit Deb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200330145048.535b89d6@elisabeth \
--to=sbrivio@redhat.com \
--cc=debsoumyajit100@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.