From: Stefano Brivio <sbrivio@redhat.com>
To: Soumyajit Deb <debsoumyajit100@gmail.com>
Cc: outreachy-kernel@googlegroups.com, Greg KH <gregkh@linuxfoundation.org>
Subject: Re: [Outreachy kernel] [Outreachy Kernel][PATCH 1/2] staging: wlang-ng: Properly align the lines of function call
Date: Mon, 30 Mar 2020 14:49:25 +0200 [thread overview]
Message-ID: <20200330144925.4e7d4deb@elisabeth> (raw)
In-Reply-To: <CAMS7mKA7g8Ea2RpkZOZ0R5mkJM+zwawB86CtBiY=D-VZhW6q0A@mail.gmail.com>
Soumyajit,
On Mon, 30 Mar 2020 15:25:03 +0530
Soumyajit Deb <debsoumyajit100@gmail.com> wrote:
> Sorry for the inconvenience.
> Now I am also confused a bit too
> But as much as I understand,
> this patch is somewhat different from the change I wanted by casting to i32.
Can you please stop top-quoting first? This:
https://en.wikipedia.org/wiki/Posting_style#Bottom-posting
is the preferred way to comment on code and intervene in discussions on
the communities we'll be working with.
> This patch just addresses the warning of properly aligning the lines as
> reported by checkpatch.pl.
...but it makes the problem worse, because instead of just 89 columns
you reach 115 columns and you also exceed 80 columns with code, not
just with comments. That's how the two things are (obviously) related.
> While, the change of casting to i32 was for line over 80 characters
> warning, which is a different warning altogether, so that change must be
> addressed in some other patch.
> I wanted to cast to i32 so that I can shorten the line and resolve the
> warning of line over 80 character as reported by checkpatch.pl
>
> Sorry, for any misunderstanding. I am very new to kernel development and
> was confused a bit about the process then.
> Sorry for any mistake on my part.
No, sorry, but if you ask about something three times, and three times I
give you the same answer, well, the confusion will start happening on my
side.
I understand you might be tempted to find the easiest possible patches
to have a number of formal submissions, instead of losing your time
writing a simple test program (which would tell you that 'i32' doesn't
exist, by the way). I don't think it's a reasonable approach, though.
--
Stefano
next prev parent reply other threads:[~2020-03-30 12:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-27 14:42 [Outreachy Kernel][PATCH 0/2] staging: wlan-ng: Resolve various warnings reported by checkpatch.pl Soumyajit Deb
2020-03-27 14:42 ` [Outreachy Kernel][PATCH 1/2] staging: wlang-ng: Properly align the lines of function call Soumyajit Deb
2020-03-30 9:12 ` [Outreachy kernel] " Stefano Brivio
2020-03-30 9:55 ` Soumyajit Deb
2020-03-30 10:14 ` Soumyajit Deb
2020-03-30 12:50 ` Stefano Brivio
2020-03-30 12:49 ` Stefano Brivio [this message]
2020-03-27 14:42 ` [Outreachy Kernel][PATCH 2/2] staging: wlan-ng: Line over 80 characters Soumyajit Deb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200330144925.4e7d4deb@elisabeth \
--to=sbrivio@redhat.com \
--cc=debsoumyajit100@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.