Re: [Outreachy kernel] [Patch v3 0/3] Staging: vt6655: Remove dead functions.

[Stefano Brivio <sbrivio@redhat.com>]

About the subject, my personal preference would be "unused functions".

"Dead" is *probably* universally understood, but mind that it's only in
a few languages where the equivalent of "dead" can be a synonym for
obsolete, unused, superfluous, etc. In any case, that's also fine by me.

On Tue, 31 Mar 2020 19:22:31 -0700
Briana Oursler <briana.oursler@gmail.com> wrote:

> This patchset removes functions that are not called in the driver but
> are prototyped in card.h. Each commit limits its scope to one function
> definition and related documentation in code.
> 
> Functions were checked for calls using the Elixir Cross Referencer and
> git grep.
> 
> Per Stefano Brivio's recommendation, output of bloatometer script after
> changes:
> 
> add/remove: 0/3 grow/shrink: 0/0 up/down: 0/-532 (-532)
> Function                                     old     new   delta
> CARDbSoftwareReset                            10       -     -10
> CARDvSetLoopbackMode                          14       -     -14
> CARDbRadioPowerOn                            508       -    -508
> Total: Before=36131, After=35599, chg -1.47%
> 
> Briana Oursler (3):
>   Staging: vt6655: Remove CARDbSoftwareReset definition.
>   Staging: vt6655: Remove CARDvSetLoopbackMode definition.
>   Staging: vt6655: Remove CARDbRadioPowerOn definition.
> 
> Changes in v3:
> 	- Update language in patch series name at suggestions from
> 	  Stefano Brivio and Julia Lawall. 
> 	- Remove references to the changelog in the cover letter. It is
> 	  unrelated to this series.

Changes can be listed like you did in the cover letter, and that's
fine. What I tend to do, and I think it's helpful, is to only present a
small summary of the changes in the cover letter, and then add detailed
information in each patch, so that one has them at hand while reviewing
the single patches.

This is almost irrelevant here, because changelogs for single patches
are discarded (don't hit git history) just in the way the cover letter
is.

However, for some subsystems (net), where the changelog for single
patches is maintained, that makes a substantial difference.

In any case, for the series,

Reviewed-by: Stefano Brivio <sbrivio@redhat.com>

-- 
Stefano