All of lore.kernel.org
 help / color / mirror / Atom feed
From: Briana Oursler <briana.oursler@gmail.com>
To: sbrivio@redhat.com, gregkh@linuxfoundation.org,
	julia.lawall@inria.fr, forest@alittletooquiet.net,
	outreachy-kernel@googlegroups.com
Cc: Briana Oursler <briana.oursler@gmail.com>
Subject: [Patch v3 0/3] Staging: vt6655: Remove dead functions.
Date: Tue, 31 Mar 2020 19:22:31 -0700	[thread overview]
Message-ID: <cover.1585707212.git.briana.oursler@gmail.com> (raw)

This patchset removes functions that are not called in the driver but
are prototyped in card.h. Each commit limits its scope to one function
definition and related documentation in code.

Functions were checked for calls using the Elixir Cross Referencer and
git grep.

Per Stefano Brivio's recommendation, output of bloatometer script after
changes:

add/remove: 0/3 grow/shrink: 0/0 up/down: 0/-532 (-532)
Function                                     old     new   delta
CARDbSoftwareReset                            10       -     -10
CARDvSetLoopbackMode                          14       -     -14
CARDbRadioPowerOn                            508       -    -508
Total: Before=36131, After=35599, chg -1.47%

Briana Oursler (3):
  Staging: vt6655: Remove CARDbSoftwareReset definition.
  Staging: vt6655: Remove CARDvSetLoopbackMode definition.
  Staging: vt6655: Remove CARDbRadioPowerOn definition.

Changes in v3:
	- Update language in patch series name at suggestions from
	  Stefano Brivio and Julia Lawall. 
	- Remove references to the changelog in the cover letter. It is
	  unrelated to this series.

Changes in v2:
	- Add output of bloatometer.
	- Change language from "uncalled function" to "function...that
	  is never called" in each patch in the series. 

 drivers/staging/vt6655/card.c | 105 ----------------------------------
 drivers/staging/vt6655/card.h |   4 --
 2 files changed, 109 deletions(-)

-- 
2.24.1



             reply	other threads:[~2020-04-01  2:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-01  2:22 Briana Oursler [this message]
2020-04-01  2:22 ` [Patch v3 1/3] Staging: vt6655: Remove CARDbSoftwareReset definition Briana Oursler
2020-04-01  2:22 ` [Patch v3 2/3] Staging: vt6655: Remove CARDvSetLoopbackMode definition Briana Oursler
2020-04-01  2:22 ` [Patch v3 3/3] Staging: vt6655: Remove CARDbRadioPowerOn definition Briana Oursler
2020-04-01 12:07   ` Julia Lawall
2020-04-01 17:03     ` Briana Oursler
2020-04-01 17:09       ` Julia Lawall
2020-04-01  3:16 ` [Outreachy kernel] [Patch v3 0/3] Staging: vt6655: Remove dead functions Stefano Brivio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1585707212.git.briana.oursler@gmail.com \
    --to=briana.oursler@gmail.com \
    --cc=forest@alittletooquiet.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=julia.lawall@inria.fr \
    --cc=outreachy-kernel@googlegroups.com \
    --cc=sbrivio@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.