Re: [Patch v3 3/3] Staging: vt6655: Remove CARDbRadioPowerOn definition.

[Julia Lawall <julia.lawall@inria.fr>]

On Wed, 1 Apr 2020, Briana Oursler wrote:

> On Wed, 2020-04-01 at 14:07 +0200, Julia Lawall wrote:
> >
> > On Tue, 31 Mar 2020, Briana Oursler wrote:
> >
> > > Remove function CARDbRadioPowerOn that is never called, along with
> > > comments related to it.
> >
> > Did you check whether any of the functions that it calls are only
> > called
> > from here?
>
> Hi Julia,
>
> It looks like there are. Should I remove them in additional commits and
> add them to the patch series?

Yes.

julia

>
> Thanks,
>
> Briana
>
> >
> > julia
> >
> > > Signed-off-by: Briana Oursler <briana.oursler@gmail.com>
> > > ---
> > >  drivers/staging/vt6655/card.c | 55 -----------------------------
> > > ------
> > >  drivers/staging/vt6655/card.h |  1 -
> > >  2 files changed, 56 deletions(-)
> > >
> > > diff --git a/drivers/staging/vt6655/card.c
> > > b/drivers/staging/vt6655/card.c
> > > index 222b6ef61d9c..67b23ab0b0d1 100644
> > > --- a/drivers/staging/vt6655/card.c
> > > +++ b/drivers/staging/vt6655/card.c
> > > @@ -17,7 +17,6 @@
> > >   *      CARDvSetFirstNextTBTT - Set NIC Beacon time
> > >   *      CARDvUpdateNextTBTT - Sync. NIC Beacon time
> > >   *      CARDbRadioPowerOff - Turn Off NIC Radio Power
> > > - *      CARDbRadioPowerOn - Turn On NIC Radio Power
> > >   *
> > >   * Revision History:
> > >   *      06-10-2003 Bryan YC Fan:  Re-write codes to support VT3253
> > > spec.
> > > @@ -437,60 +436,6 @@ void CARDbRadioPowerOff(struct vnt_private
> > > *priv)
> > >  		      LED_ACTSET);  /* LED issue */
> > >  }
> > >
> > > -/*
> > > - * Description: Turn on Radio power
> > > - *
> > > - * Parameters:
> > > - *  In:
> > > - *      priv         - The adapter to be turned on
> > > - *  Out:
> > > - *      none
> > > - *
> > > - * Return Value: true if success; otherwise false
> > > - */
> > > -bool CARDbRadioPowerOn(struct vnt_private *priv)
> > > -{
> > > -	bool bResult = true;
> > > -
> > > -	pr_debug("chester power on\n");
> > > -	if (priv->bRadioControlOff) {
> > > -		if (priv->bHWRadioOff)
> > > -			pr_debug("chester bHWRadioOff\n");
> > > -		if (priv->bRadioControlOff)
> > > -			pr_debug("chester bRadioControlOff\n");
> > > -		return false; }
> > > -
> > > -	if (!priv->bRadioOff) {
> > > -		pr_debug("chester pbRadioOff\n");
> > > -		return true; }
> > > -
> > > -	BBvExitDeepSleep(priv, priv->byLocalID);
> > > -
> > > -	MACvRegBitsOn(priv->PortOffset, MAC_REG_HOSTCR, HOSTCR_RXON);
> > > -
> > > -	switch (priv->byRFType) {
> > > -	case RF_RFMD2959:
> > > -		MACvWordRegBitsOn(priv->PortOffset, MAC_REG_SOFTPWRCTL,
> > > -				  SOFTPWRCTL_TXPEINV);
> > > -		MACvWordRegBitsOff(priv->PortOffset,
> > > MAC_REG_SOFTPWRCTL,
> > > -				   SOFTPWRCTL_SWPE1);
> > > -		break;
> > > -
> > > -	case RF_AIROHA:
> > > -	case RF_AL2230S:
> > > -	case RF_AIROHA7230:
> > > -		MACvWordRegBitsOn(priv->PortOffset, MAC_REG_SOFTPWRCTL,
> > > -				  (SOFTPWRCTL_SWPE2 |
> > > SOFTPWRCTL_SWPE3));
> > > -		break;
> > > -	}
> > > -
> > > -	priv->bRadioOff = false;
> > > -	pr_debug("chester power on\n");
> > > -	MACvRegBitsOff(priv->PortOffset, MAC_REG_GPIOCTL0,
> > > -		       LED_ACTSET); /* LED issue */
> > > -	return bResult;
> > > -}
> > > -
> > >  void CARDvSafeResetTx(struct vnt_private *priv)
> > >  {
> > >  	unsigned int uu;
> > > diff --git a/drivers/staging/vt6655/card.h
> > > b/drivers/staging/vt6655/card.h
> > > index 32405027e269..568a2ddd6588 100644
> > > --- a/drivers/staging/vt6655/card.h
> > > +++ b/drivers/staging/vt6655/card.h
> > > @@ -55,7 +55,6 @@ unsigned char CARDbyGetPktType(struct vnt_private
> > > *priv);
> > >  void CARDvSafeResetTx(struct vnt_private *priv);
> > >  void CARDvSafeResetRx(struct vnt_private *priv);
> > >  void CARDbRadioPowerOff(struct vnt_private *priv);
> > > -bool CARDbRadioPowerOn(struct vnt_private *priv);
> > >  bool CARDbSetPhyParameter(struct vnt_private *priv, u8 bb_type);
> > >  bool CARDbUpdateTSF(struct vnt_private *priv, unsigned char
> > > byRxRate,
> > >  		    u64 qwBSSTimestamp);
> > > --
> > > 2.24.1
> > >
> > >
>
>