From: Dan Carpenter <dan.carpenter@oracle.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: kbuild@lists.01.org, Shiju Jose <shiju.jose@huawei.com>,
linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, rjw@rjwysocki.net, lenb@kernel.org,
bp@alien8.de, james.morse@arm.com, tony.luck@intel.com,
gregkh@linuxfoundation.org, zhangliguang@linux.alibaba.com,
tglx@linutronix.de, linuxarm@huawei.com,
jonathan.cameron@huawei.com, tanxiaofei@huawei.com,
yangyicong@hisilicon.com
Subject: Re: [PATCH v5 2/2] PCI: HIP: Add handling of HiSilicon HIP PCIe controller errors
Date: Fri, 3 Apr 2020 17:41:29 +0300 [thread overview]
Message-ID: <20200403144129.GH2066@kadam> (raw)
In-Reply-To: <20200403133303.GA213756@google.com>
On Fri, Apr 03, 2020 at 08:33:03AM -0500, Bjorn Helgaas wrote:
>
> Adding tags for every reviewer or bot comment seems like overkill.
I think style comments are their own reward but people should get credit
for bug fixes.
I also think Reviewed-by is pretty useless. We could get rid of it, and
only count reviews which fix bugs. ;)
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@lists.01.org
Subject: Re: [PATCH v5 2/2] PCI: HIP: Add handling of HiSilicon HIP PCIe controller errors
Date: Fri, 03 Apr 2020 17:41:29 +0300 [thread overview]
Message-ID: <20200403144129.GH2066@kadam> (raw)
In-Reply-To: <20200403133303.GA213756@google.com>
[-- Attachment #1: Type: text/plain, Size: 372 bytes --]
On Fri, Apr 03, 2020 at 08:33:03AM -0500, Bjorn Helgaas wrote:
>
> Adding tags for every reviewer or bot comment seems like overkill.
I think style comments are their own reward but people should get credit
for bug fixes.
I also think Reviewed-by is pretty useless. We could get rid of it, and
only count reviews which fix bugs. ;)
regards,
dan carpenter
next prev parent reply other threads:[~2020-04-03 14:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-25 13:55 [PATCH v5 2/2] PCI: HIP: Add handling of HiSilicon HIP PCIe controller errors Shiju Jose
2020-03-25 17:36 ` Bjorn Helgaas
2020-03-26 9:47 ` Shiju Jose
2020-04-03 10:23 ` Dan Carpenter
2020-04-03 10:23 ` Dan Carpenter
2020-04-03 13:33 ` Bjorn Helgaas
2020-04-03 14:41 ` Dan Carpenter [this message]
2020-04-03 14:41 ` Dan Carpenter
-- strict thread matches above, loose matches on Subject: below --
2020-03-25 14:11 Shiju Jose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200403144129.GH2066@kadam \
--to=dan.carpenter@oracle.com \
--cc=bp@alien8.de \
--cc=gregkh@linuxfoundation.org \
--cc=helgaas@kernel.org \
--cc=james.morse@arm.com \
--cc=jonathan.cameron@huawei.com \
--cc=kbuild@lists.01.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=rjw@rjwysocki.net \
--cc=shiju.jose@huawei.com \
--cc=tanxiaofei@huawei.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=yangyicong@hisilicon.com \
--cc=zhangliguang@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.