Re: [PATCH 1/3] ARM: at91: add atmel tcb capabilities

From: William Breathitt Gray <vilhelm.gray@gmail.com>
To: Kamel Bouhara <kamel.bouhara@bootlin.com>
Cc: Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Nicolas Ferre <nicolas.ferre@microchip.com>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Ludovic Desroches <ludovic.desroches@microchip.com>,
	linux-arm-kernel@lists.infradead.org,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	linux-input@vger.kernel.org, devicetree@vger.kernel.org,
	linux-iio@vger.kernel.org
Subject: Re: [PATCH 1/3] ARM: at91: add atmel tcb capabilities
Date: Tue, 7 Apr 2020 12:53:35 -0400	[thread overview]
Message-ID: <20200407165335.GF5578@icarus> (raw)
In-Reply-To: <20200406155320.1291701-2-kamel.bouhara@bootlin.com>

[-- Attachment #1: Type: text/plain, Size: 1077 bytes --]

On Mon, Apr 06, 2020 at 05:53:18PM +0200, Kamel Bouhara wrote:
> Some atmel socs have extra tcb capabilities that allow using a generic
> clock source or enabling a quadrature decoder.
> 
> Signed-off-by: Kamel Bouhara <kamel.bouhara@bootlin.com>
> ---
>  include/soc/at91/atmel_tcb.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/include/soc/at91/atmel_tcb.h b/include/soc/at91/atmel_tcb.h
> index fbf5474f4484..6b9c9bec982e 100644
> --- a/include/soc/at91/atmel_tcb.h
> +++ b/include/soc/at91/atmel_tcb.h
> @@ -39,7 +39,8 @@ struct clk;
>   */
>  struct atmel_tcb_config {
>  	size_t	counter_width;
> -	unsigned int has_gclk:1;

Hi Kamel,

I'm having trouble applying this patch, so I think we have different
bases. Specifically, I'm not sure where this has_gclk member was
introduced. It doesn't look like it's in the testing branch of the IIO
tree yet.

What branch did you base your patches on?

Thanks,

William Breathitt Gray

> +	bool	has_gclk;
> +	bool	has_qdec;
>  };
>  
>  /**
> -- 
> 2.25.0
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]