All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jonathan Bakker <xc-racer2@live.ca>
Cc: tomasz.figa@gmail.com, s.nawrocki@samsung.com,
	linus.walleij@linaro.org, kgene@kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pinctrl: samsung: Correct setting of eint wakeup mask on s5pv210
Date: Mon, 13 Apr 2020 12:11:27 +0200	[thread overview]
Message-ID: <20200413101127.GA10535@kozik-lap> (raw)
In-Reply-To: <BYAPR10MB3479E878C547053C6B952E01A3C40@BYAPR10MB3479.namprd10.prod.outlook.com>

On Sat, Apr 04, 2020 at 10:08:49AM -0700, Jonathan Bakker wrote:
> Commit a8be2af0218c ("pinctrl: samsung: Write external wakeup interrupt
> mask") started writing the eint wakeup mask from the pinctrl driver.
> Unfortunately, it made the assumption that the private retention data
> was always a regmap while in the case of s5pv210 it is a raw pointer
> to the clock base (as the eint wakeup mask not in the PMU as with newer
> Exynos platforms).
> 
> Fixes: a8be2af0218c ("pinctrl: samsung: Write external wakeup interrupt mask")
> Signed-off-by: Jonathan Bakker <xc-racer2@live.ca>
> ---
>  drivers/pinctrl/samsung/pinctrl-exynos.c | 73 ++++++++++++++++--------

Thanks, applied (with Cc-stable tag).

Best regards,
Krzysztof


WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jonathan Bakker <xc-racer2@live.ca>
Cc: linux-samsung-soc@vger.kernel.org, linus.walleij@linaro.org,
	tomasz.figa@gmail.com, linux-kernel@vger.kernel.org,
	linux-gpio@vger.kernel.org, kgene@kernel.org,
	s.nawrocki@samsung.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] pinctrl: samsung: Correct setting of eint wakeup mask on s5pv210
Date: Mon, 13 Apr 2020 12:11:27 +0200	[thread overview]
Message-ID: <20200413101127.GA10535@kozik-lap> (raw)
In-Reply-To: <BYAPR10MB3479E878C547053C6B952E01A3C40@BYAPR10MB3479.namprd10.prod.outlook.com>

On Sat, Apr 04, 2020 at 10:08:49AM -0700, Jonathan Bakker wrote:
> Commit a8be2af0218c ("pinctrl: samsung: Write external wakeup interrupt
> mask") started writing the eint wakeup mask from the pinctrl driver.
> Unfortunately, it made the assumption that the private retention data
> was always a regmap while in the case of s5pv210 it is a raw pointer
> to the clock base (as the eint wakeup mask not in the PMU as with newer
> Exynos platforms).
> 
> Fixes: a8be2af0218c ("pinctrl: samsung: Write external wakeup interrupt mask")
> Signed-off-by: Jonathan Bakker <xc-racer2@live.ca>
> ---
>  drivers/pinctrl/samsung/pinctrl-exynos.c | 73 ++++++++++++++++--------

Thanks, applied (with Cc-stable tag).

Best regards,
Krzysztof


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-04-13 10:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-04 17:08 [PATCH] pinctrl: samsung: Correct setting of eint wakeup mask on s5pv210 Jonathan Bakker
2020-04-04 17:08 ` Jonathan Bakker
2020-04-13 10:11 ` Krzysztof Kozlowski [this message]
2020-04-13 10:11   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200413101127.GA10535@kozik-lap \
    --to=krzk@kernel.org \
    --cc=kgene@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=s.nawrocki@samsung.com \
    --cc=tomasz.figa@gmail.com \
    --cc=xc-racer2@live.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.