* [PATCH] staging: vt6656: Use BIT() macro instead of bit shift operator
@ 2020-04-12 9:33 Oscar Carter
2020-04-13 12:58 ` Greg Kroah-Hartman
0 siblings, 1 reply; 2+ messages in thread
From: Oscar Carter @ 2020-04-12 9:33 UTC (permalink / raw)
To: Forest Bond, Greg Kroah-Hartman
Cc: Oscar Carter, Quentin Deslandes, Malcolm Priestley,
Colin Ian King, devel, linux-kernel
Use the BIT() macro instead of the bit left shift operator. So the code
is more clear.
It's safe to remove the casting to u16 type because the value obtained
never exceeds 16 bits. So the casting is unnecessary.
Signed-off-by: Oscar Carter <oscar.carter@gmx.com>
---
drivers/staging/vt6656/card.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/vt6656/card.c b/drivers/staging/vt6656/card.c
index dc3ab10eb630..14e6c71f122c 100644
--- a/drivers/staging/vt6656/card.c
+++ b/drivers/staging/vt6656/card.c
@@ -92,7 +92,7 @@ static u16 vnt_get_cck_rate(struct vnt_private *priv, u16 rate_idx)
u16 ui = rate_idx;
while (ui > RATE_1M) {
- if (priv->basic_rates & (1 << ui))
+ if (priv->basic_rates & BIT(ui))
return ui;
ui--;
}
@@ -129,7 +129,7 @@ static u16 vnt_get_ofdm_rate(struct vnt_private *priv, u16 rate_idx)
}
while (ui > RATE_11M) {
- if (priv->basic_rates & (1 << ui)) {
+ if (priv->basic_rates & BIT(ui)) {
dev_dbg(&priv->usb->dev, "%s rate: %d\n",
__func__, ui);
return ui;
@@ -420,7 +420,7 @@ void vnt_update_top_rates(struct vnt_private *priv)
/*Determines the highest basic rate.*/
for (i = RATE_54M; i >= RATE_6M; i--) {
- if (priv->basic_rates & (u16)(1 << i)) {
+ if (priv->basic_rates & BIT(i)) {
top_ofdm = i;
break;
}
@@ -429,7 +429,7 @@ void vnt_update_top_rates(struct vnt_private *priv)
priv->top_ofdm_basic_rate = top_ofdm;
for (i = RATE_11M;; i--) {
- if (priv->basic_rates & (u16)(1 << i)) {
+ if (priv->basic_rates & BIT(i)) {
top_cck = i;
break;
}
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: vt6656: Use BIT() macro instead of bit shift operator
2020-04-12 9:33 [PATCH] staging: vt6656: Use BIT() macro instead of bit shift operator Oscar Carter
@ 2020-04-13 12:58 ` Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2020-04-13 12:58 UTC (permalink / raw)
To: Oscar Carter
Cc: Forest Bond, devel, Malcolm Priestley, linux-kernel,
Colin Ian King
On Sun, Apr 12, 2020 at 11:33:11AM +0200, Oscar Carter wrote:
> Use the BIT() macro instead of the bit left shift operator. So the code
> is more clear.
>
> It's safe to remove the casting to u16 type because the value obtained
> never exceeds 16 bits. So the casting is unnecessary.
>
> Signed-off-by: Oscar Carter <oscar.carter@gmx.com>
> ---
> drivers/staging/vt6656/card.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
This too did not apply :(
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-13 12:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-12 9:33 [PATCH] staging: vt6656: Use BIT() macro instead of bit shift operator Oscar Carter
2020-04-13 12:58 ` Greg Kroah-Hartman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.