From: Dan Carpenter <dan.carpenter@oracle.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: Thierry Reding <thierry.reding@gmail.com>,
paul@crapouillou.net, Joe Perches <joe@perches.com>,
u.kleine-koenig@pengutronix.de, linux-pwm@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] pwm: Add missing '\n' in log messages
Date: Tue, 14 Apr 2020 18:49:25 +0000 [thread overview]
Message-ID: <20200414184925.GA12862@kadam> (raw)
In-Reply-To: <f13a8754-3866-d3d2-eaff-29cb6d14ff8d@wanadoo.fr>
Huh...
If you look at dev_vprintk_emit(). It looks like if
create_syslog_header() returns a string then vprintk_store() will add
a newline.
I guess that means that dev_printk() can't be used to pr_cont(). And
probably that's deliberate because using pr_cont() after boot is racy
anyway.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: Thierry Reding <thierry.reding@gmail.com>,
paul@crapouillou.net, Joe Perches <joe@perches.com>,
u.kleine-koenig@pengutronix.de, linux-pwm@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] pwm: Add missing '\n' in log messages
Date: Tue, 14 Apr 2020 21:49:25 +0300 [thread overview]
Message-ID: <20200414184925.GA12862@kadam> (raw)
In-Reply-To: <f13a8754-3866-d3d2-eaff-29cb6d14ff8d@wanadoo.fr>
Huh...
If you look at dev_vprintk_emit(). It looks like if
create_syslog_header() returns a string then vprintk_store() will add
a newline.
I guess that means that dev_printk() can't be used to pr_cont(). And
probably that's deliberate because using pr_cont() after boot is racy
anyway.
regards,
dan carpenter
next prev parent reply other threads:[~2020-04-14 18:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-11 15:35 [PATCH] pwm: Add missing '\n' in log messages Christophe JAILLET
2020-04-11 15:35 ` Christophe JAILLET
2020-04-11 16:37 ` Uwe Kleine-König
2020-04-11 16:37 ` Uwe Kleine-König
2020-04-14 13:58 ` Thierry Reding
2020-04-14 13:58 ` Thierry Reding
2020-04-14 18:30 ` Christophe JAILLET
2020-04-14 18:30 ` Christophe JAILLET
2020-04-14 18:49 ` Dan Carpenter [this message]
2020-04-14 18:49 ` Dan Carpenter
2020-04-14 19:09 ` Joe Perches
2020-04-14 19:09 ` Joe Perches
2020-04-14 19:04 ` Joe Perches
2020-04-14 19:04 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200414184925.GA12862@kadam \
--to=dan.carpenter@oracle.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=joe@perches.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=paul@crapouillou.net \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.