From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Stephen Boyd <swboyd@chromium.org>
Cc: Douglas Anderson <dianders@chromium.org>,
a.hajda@samsung.com, airlied@linux.ie, daniel@ffwll.ch,
narmstrong@baylibre.com, robh+dt@kernel.org,
spanda@codeaurora.org, jonas@kwiboo.se,
bjorn.andersson@linaro.org, devicetree@vger.kernel.org,
jeffrey.l.hugo@gmail.com, jernej.skrabec@siol.net,
linux-arm-msm@vger.kernel.org, robdclark@chromium.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] dt-bindings: drm/bridge: ti-sn65dsi86: Add hpd-gpios to the bindings
Date: Wed, 15 Apr 2020 23:32:56 +0300 [thread overview]
Message-ID: <20200415203256.GP4758@pendragon.ideasonboard.com> (raw)
In-Reply-To: <158698038289.105027.2860892334897893887@swboyd.mtv.corp.google.com>
On Wed, Apr 15, 2020 at 12:53:02PM -0700, Stephen Boyd wrote:
> Quoting Douglas Anderson (2020-04-15 08:48:40)
> > Allow people to specify to use a GPIO for hot-plug-detect. Add an
> > example.
> >
> > NOTE: The current patch adding support for hpd-gpios to the Linux
> > driver for hpd-gpios only adds enough support to the driver so that
> > the bridge can use one of its own GPIOs. The bindings, however, are
> > written generically.
> >
> > Signed-off-by: Douglas Anderson <dianders@chromium.org>
> > ---
> >
> > .../bindings/display/bridge/ti,sn65dsi86.yaml | 10 +++++++++-
> > 1 file changed, 9 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.yaml b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.yaml
> > index 8cacc6db33a9..554bfd003000 100644
> > --- a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.yaml
> > +++ b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.yaml
> > @@ -60,6 +60,10 @@ properties:
> > const: 1
> > description: See ../../pwm/pwm.yaml for description of the cell formats.
> >
> > + hpd-gpios:
> > + maxItems: 1
> > + description: If present use the given GPIO for hot-plug-detect.
>
> Shouldn't this go in the panel node? And the panel driver should get the
> gpio and poll it after powering up the panel? Presumably that's why we
> have the no-hpd property in the simple panel binding vs. putting it here
> in the bridge.
Same question really, I think this belongs to the panel (or connector)
node indeed.
--
Regards,
Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Stephen Boyd <swboyd@chromium.org>
Cc: robdclark@chromium.org, devicetree@vger.kernel.org,
jernej.skrabec@siol.net, narmstrong@baylibre.com,
airlied@linux.ie, linux-arm-msm@vger.kernel.org, jonas@kwiboo.se,
jeffrey.l.hugo@gmail.com,
Douglas Anderson <dianders@chromium.org>,
dri-devel@lists.freedesktop.org, spanda@codeaurora.org,
a.hajda@samsung.com, robh+dt@kernel.org,
bjorn.andersson@linaro.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] dt-bindings: drm/bridge: ti-sn65dsi86: Add hpd-gpios to the bindings
Date: Wed, 15 Apr 2020 23:32:56 +0300 [thread overview]
Message-ID: <20200415203256.GP4758@pendragon.ideasonboard.com> (raw)
In-Reply-To: <158698038289.105027.2860892334897893887@swboyd.mtv.corp.google.com>
On Wed, Apr 15, 2020 at 12:53:02PM -0700, Stephen Boyd wrote:
> Quoting Douglas Anderson (2020-04-15 08:48:40)
> > Allow people to specify to use a GPIO for hot-plug-detect. Add an
> > example.
> >
> > NOTE: The current patch adding support for hpd-gpios to the Linux
> > driver for hpd-gpios only adds enough support to the driver so that
> > the bridge can use one of its own GPIOs. The bindings, however, are
> > written generically.
> >
> > Signed-off-by: Douglas Anderson <dianders@chromium.org>
> > ---
> >
> > .../bindings/display/bridge/ti,sn65dsi86.yaml | 10 +++++++++-
> > 1 file changed, 9 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.yaml b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.yaml
> > index 8cacc6db33a9..554bfd003000 100644
> > --- a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.yaml
> > +++ b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.yaml
> > @@ -60,6 +60,10 @@ properties:
> > const: 1
> > description: See ../../pwm/pwm.yaml for description of the cell formats.
> >
> > + hpd-gpios:
> > + maxItems: 1
> > + description: If present use the given GPIO for hot-plug-detect.
>
> Shouldn't this go in the panel node? And the panel driver should get the
> gpio and poll it after powering up the panel? Presumably that's why we
> have the no-hpd property in the simple panel binding vs. putting it here
> in the bridge.
Same question really, I think this belongs to the panel (or connector)
node indeed.
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-04-15 20:33 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-15 15:48 [PATCH 1/3] dt-bindings: drm/bridge: ti-sn65dsi86: Convert to yaml Douglas Anderson
2020-04-15 15:48 ` Douglas Anderson
2020-04-15 15:48 ` [PATCH 2/3] dt-bindings: drm/bridge: ti-sn65dsi86: Add hpd-gpios to the bindings Douglas Anderson
2020-04-15 15:48 ` Douglas Anderson
2020-04-15 19:53 ` Stephen Boyd
2020-04-15 19:53 ` Stephen Boyd
2020-04-15 20:32 ` Laurent Pinchart [this message]
2020-04-15 20:32 ` Laurent Pinchart
2020-04-15 23:49 ` Doug Anderson
2020-04-15 23:49 ` Doug Anderson
2020-04-16 0:54 ` Laurent Pinchart
2020-04-16 0:54 ` Laurent Pinchart
2020-04-16 21:53 ` Doug Anderson
2020-04-16 21:53 ` Doug Anderson
2020-04-17 18:08 ` Laurent Pinchart
2020-04-17 18:08 ` Laurent Pinchart
2020-04-21 5:10 ` Doug Anderson
2020-04-21 5:10 ` Doug Anderson
2020-04-15 15:48 ` [PATCH 3/3] drm/bridge: ti-sn65dsi86: Allow one of the bridge GPIOs to be HPD Douglas Anderson
2020-04-15 15:48 ` Douglas Anderson
2020-04-15 19:50 ` [PATCH 1/3] dt-bindings: drm/bridge: ti-sn65dsi86: Convert to yaml Stephen Boyd
2020-04-15 19:50 ` Stephen Boyd
2020-04-15 20:31 ` Laurent Pinchart
2020-04-15 20:31 ` Laurent Pinchart
2020-04-21 5:07 ` Doug Anderson
2020-04-21 5:07 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200415203256.GP4758@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=bjorn.andersson@linaro.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jeffrey.l.hugo@gmail.com \
--cc=jernej.skrabec@siol.net \
--cc=jonas@kwiboo.se \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
--cc=robdclark@chromium.org \
--cc=robh+dt@kernel.org \
--cc=spanda@codeaurora.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.