From: Christoph Hellwig <hch@lst.de>
To: David Rientjes <rientjes@google.com>
Cc: Tom Lendacky <thomas.lendacky@amd.com>,
x86@kernel.org, Brijesh Singh <brijesh.singh@amd.com>,
Jon Grimm <jon.grimm@amd.com>,
linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Thomas Gleixner <tglx@linutronix.de>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [patch 4/7] dma-direct: atomic allocations must come from atomic coherent pools
Date: Fri, 17 Apr 2020 09:09:58 +0200 [thread overview]
Message-ID: <20200417070958.GB19153@lst.de> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2004141703510.68516@chino.kir.corp.google.com>
The subject should say something like "atomic unencrypted allocations.."
as many other atomic allocations are fine. Which brings up that with
the codebase in this patch we can't really support architectures that
require both an atomic pool for uncached remapping for just some devices
and unencrypted for others. We don't have such an archicture right now,
and I hope we don't grow one, but we probably need a little safeguard
with a BUILD_BUG_ON if both options are set. I can send an incremental
patch for that if that is ok with you.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: David Rientjes <rientjes@google.com>
Cc: Christoph Hellwig <hch@lst.de>,
Tom Lendacky <thomas.lendacky@amd.com>,
Brijesh Singh <brijesh.singh@amd.com>,
Jon Grimm <jon.grimm@amd.com>, Joerg Roedel <joro@8bytes.org>,
linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
x86@kernel.org
Subject: Re: [patch 4/7] dma-direct: atomic allocations must come from atomic coherent pools
Date: Fri, 17 Apr 2020 09:09:58 +0200 [thread overview]
Message-ID: <20200417070958.GB19153@lst.de> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2004141703510.68516@chino.kir.corp.google.com>
The subject should say something like "atomic unencrypted allocations.."
as many other atomic allocations are fine. Which brings up that with
the codebase in this patch we can't really support architectures that
require both an atomic pool for uncached remapping for just some devices
and unencrypted for others. We don't have such an archicture right now,
and I hope we don't grow one, but we probably need a little safeguard
with a BUILD_BUG_ON if both options are set. I can send an incremental
patch for that if that is ok with you.
next prev parent reply other threads:[~2020-04-17 7:10 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-15 0:04 [patch 0/7] unencrypted atomic DMA pools with dynamic expansion David Rientjes via iommu
2020-04-15 0:04 ` David Rientjes
2020-04-15 0:04 ` [patch 1/7] dma-remap: separate DMA atomic pools from direct remap code David Rientjes via iommu
2020-04-15 0:04 ` David Rientjes
2020-04-17 7:06 ` Christoph Hellwig
2020-04-17 7:06 ` Christoph Hellwig
2020-04-15 0:04 ` [patch 2/7] dma-pool: add additional coherent pools to map to gfp mask David Rientjes via iommu
2020-04-15 0:04 ` David Rientjes
2020-04-15 0:04 ` [patch 3/7] dma-pool: dynamically expanding atomic pools David Rientjes via iommu
2020-04-15 0:04 ` David Rientjes
2020-04-15 0:04 ` [patch 4/7] dma-direct: atomic allocations must come from atomic coherent pools David Rientjes via iommu
2020-04-15 0:04 ` David Rientjes
2020-04-17 7:09 ` Christoph Hellwig [this message]
2020-04-17 7:09 ` Christoph Hellwig
2020-04-15 0:04 ` [patch 5/7] dma-pool: add pool sizes to debugfs David Rientjes via iommu
2020-04-15 0:04 ` David Rientjes
2020-04-15 13:45 ` Tom Lendacky
2020-04-15 13:45 ` Tom Lendacky
2020-04-17 7:10 ` Christoph Hellwig
2020-04-17 7:10 ` Christoph Hellwig
2020-04-15 0:05 ` [patch 6/7] x86/mm: unencrypted non-blocking DMA allocations use coherent pools David Rientjes via iommu
2020-04-15 0:05 ` David Rientjes
2020-04-15 0:05 ` [patch 7/7] dma-pool: scale the default DMA coherent pool size with memory capacity David Rientjes via iommu
2020-04-15 0:05 ` David Rientjes
2020-04-17 7:11 ` [patch 0/7] unencrypted atomic DMA pools with dynamic expansion Christoph Hellwig
2020-04-17 7:11 ` Christoph Hellwig
2020-04-17 18:41 ` David Rientjes via iommu
2020-04-17 18:41 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200417070958.GB19153@lst.de \
--to=hch@lst.de \
--cc=bp@alien8.de \
--cc=brijesh.singh@amd.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jon.grimm@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rientjes@google.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.