From: Christoph Hellwig <hch@lst.de>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc: sagi@grimberg.me, open list <linux-kernel@vger.kernel.org>,
"open list:NVM EXPRESS DRIVER" <linux-nvme@lists.infradead.org>,
axboe@fb.com, linux-stable <stable@vger.kernel.org>,
kbusch@kernel.org, hch@lst.de
Subject: Re: [PATCH] nvme/pci: Use Discard instead of Write Zeroes on SK hynix SC300
Date: Fri, 17 Apr 2020 14:59:29 +0200 [thread overview]
Message-ID: <20200417125929.GA5053@lst.de> (raw)
In-Reply-To: <20200417083641.28205-1-kai.heng.feng@canonical.com>
On Fri, Apr 17, 2020 at 04:36:41PM +0800, Kai-Heng Feng wrote:
> After commit 6e02318eaea5 ("nvme: add support for the Write Zeroes
> command"), SK hynix SC300 becomes very slow with the following error
> message:
> [ 224.567695] blk_update_request: operation not supported error, dev nvme1n1, sector 499384320 op 0x9:(WRITE_ZEROES) flags 0x1000000 phys_seg 0 prio class 0]
>
> Use quirk NVME_QUIRK_DEALLOCATE_ZEROES to workaround this issue.
Do you have a written guarantee from SK Hynix that it will always zero
all blocks discarded?
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc: kbusch@kernel.org, axboe@fb.com, hch@lst.de, sagi@grimberg.me,
linux-stable <stable@vger.kernel.org>,
"open list:NVM EXPRESS DRIVER" <linux-nvme@lists.infradead.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] nvme/pci: Use Discard instead of Write Zeroes on SK hynix SC300
Date: Fri, 17 Apr 2020 14:59:29 +0200 [thread overview]
Message-ID: <20200417125929.GA5053@lst.de> (raw)
In-Reply-To: <20200417083641.28205-1-kai.heng.feng@canonical.com>
On Fri, Apr 17, 2020 at 04:36:41PM +0800, Kai-Heng Feng wrote:
> After commit 6e02318eaea5 ("nvme: add support for the Write Zeroes
> command"), SK hynix SC300 becomes very slow with the following error
> message:
> [ 224.567695] blk_update_request: operation not supported error, dev nvme1n1, sector 499384320 op 0x9:(WRITE_ZEROES) flags 0x1000000 phys_seg 0 prio class 0]
>
> Use quirk NVME_QUIRK_DEALLOCATE_ZEROES to workaround this issue.
Do you have a written guarantee from SK Hynix that it will always zero
all blocks discarded?
next prev parent reply other threads:[~2020-04-17 13:03 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-17 8:36 [PATCH] nvme/pci: Use Discard instead of Write Zeroes on SK hynix SC300 Kai-Heng Feng
2020-04-17 8:36 ` Kai-Heng Feng
2020-04-17 12:59 ` Christoph Hellwig [this message]
2020-04-17 12:59 ` Christoph Hellwig
2020-04-21 4:51 ` Kai-Heng Feng
2020-04-21 4:51 ` Kai-Heng Feng
2020-04-17 19:25 ` Chaitanya Kulkarni
2020-04-17 19:25 ` Chaitanya Kulkarni
2020-04-21 4:51 ` Kai-Heng Feng
2020-04-21 4:51 ` Kai-Heng Feng
2020-07-23 15:57 ` [PATCH v2] nvme/pci: Add new quirk for SK hynix PC400 NLB off-by-one bug Kai-Heng Feng
2020-07-23 15:57 ` Kai-Heng Feng
2020-07-23 16:03 ` Christoph Hellwig
2020-07-23 16:03 ` Christoph Hellwig
2020-07-23 16:10 ` Kai-Heng Feng
2020-07-23 16:10 ` Kai-Heng Feng
2020-07-23 17:29 ` [PATCH v3] nvme/pci: Prevent SK hynix PC400 from using Write Zeroes command Kai-Heng Feng
2020-07-23 17:29 ` Kai-Heng Feng
2020-07-26 15:29 ` Christoph Hellwig
2020-07-26 15:29 ` Christoph Hellwig
2020-10-13 8:34 ` [PATCH] nvme-pci: Disable Write Zeroes on Sandisk Skyhawk Kai-Heng Feng
2020-10-13 8:34 ` Kai-Heng Feng
2020-10-14 0:20 ` Chaitanya Kulkarni
2020-10-14 0:20 ` Chaitanya Kulkarni
2020-10-15 5:09 ` Kai-Heng Feng
2020-10-15 5:09 ` Kai-Heng Feng
2020-10-16 14:04 ` Christoph Hellwig
2020-10-16 14:04 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200417125929.GA5053@lst.de \
--to=hch@lst.de \
--cc=axboe@fb.com \
--cc=kai.heng.feng@canonical.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.